Tianocore/edk2.git/EmbeddedPkg/Library/PrePiLib, branch dependabot/github_actions/github/codeql-action-4

EmbeddedPkg/PrePiLib: minor cleanup in FfsProcessSection ()

2025-09-11T21:05:29+00:00

Drop an else wrapper in FfsProcessSection () on the other side of an if-statemenmt that is an error return. Signed-off-by: Leif Lindholm

EmbeddedPkg/PrePiLib: eliminate unneeded variable in FfsProcessSection ()

2025-09-11T21:05:29+00:00

The "Found" variable provided only a deferred form of success handling, so eliminate it to improve readability. Signed-off-by: Leif Lindholm

EmbeddedPkg/PrePiLib: refactor FfsProcessSection ()

2025-09-11T21:05:29+00:00

Create some helper functions to make FfsProcessSection at least halfway readable by both humans and compilers. Signed-off-by: Leif Lindholm

EmbeddedPkg: CodeQL Fixes.

2025-01-15T11:18:04+00:00

Makes changes to comply with alerts raised by CodeQL. Most of the issues here fall into the following two categories: 1. Potential use of uninitialized pointer. 2. Inconsistent integer width in comparison. Co-authored-by: Taylor Beebe Co-authored-by: Ken Lautner Co-authored-by: Bret Barkelew Signed-off-by: Vineel Kovvuri[MSFT]

EmbeddedPkg/PrePiLib: Drop unused PCD PcdPrePiCpuIoSize

2023-02-04T10:55:05+00:00

The code never references the PCD so the INF should not reference it either. The last reference was moved to PrePiHobLib in commit 05e48e00834b32e4bd2 (dated 2011!) and dropped from there as well in commit 97106391955337155e7. Cc: Leif Lindholm Cc: Abner Chang Cc: Daniel Schaefer Reported-by: Sunil V L Signed-off-by: Ard Biesheuvel Reviewed-by: Sunil V L

EmbeddedPkg: Add back FfsFindSectionData

2023-01-19T08:35:59+00:00

In commit c673216f53 a new input parameter is added in FfsFindSectionData. That change breaks the build of ArmVirtPkg. In this patch FfsFindSectionData is added back. It calls FfsFindSectionDataWithHook with a NULL hook. Signed-off-by: Min Xu Reviewed-by: Jiewen Yao Acked-by: Gerd Hoffmann

EmbeddedPkg: Rename FfsFindSectionData as FfsFindSectionDataWithHook

2023-01-19T08:35:59+00:00

Commit c673216f53 introduces FFS_CHECK_SECTION_HOOK and add it as the second input parameter in FfsFindSectionData. This change breaks the build of ArmVirtPkg. To fix this issue, the new version of FfsFindSectionData is renamed as FfsFindSectionDataWithHook in this patch. In the following patch the original FfsFindSectionData will be added back. FfsFindSectionData is renamed as FfsFindSectionDataWithHook. Accordingly PeilessStartupLib in OvmfPkg should be updated as well. To prevent the build from being broken, the changes in OvmfPkg are in this patch. Signed-off-by: Min Xu Reviewed-by: Jiewen Yao Acked-by: Gerd Hoffmann

EmbeddedPkg/PrePiLib: Add FFS_CHECK_SECTION_HOOK when finding section

2023-01-18T03:04:27+00:00

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4152 EmbeddedPkg/PrePiLib provides the service of finding sections based on the input SectionType. But sometimes there maybe multiple sections with the same SectionType. FFS_CHECK_SECTION_HOOK is a hook which can be called to do additional check. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Cc: Gerd Hoffmann Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Acked-by: Ard Biesheuvel Signed-off-by: Min Xu Acked-by: Gerd Hoffmann

EmbeddedPkg: Fix a build error in FwVol.c in X64 arch

2022-01-27T06:19:05+00:00

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3814 CompressedDataLength is declared as UINTN which is UINT64 in X64 arch. But the second parameter of UefiDecompressGetInfo() is declared as UINT32. So a build error is triggered. To declare CompressedDataLength as UINT32 to fix the build error. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Signed-off-by: Min Xu

EmbeddedPkg: Apply uncrustify changes

2021-12-07T17:24:28+00:00

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3737 Apply uncrustify changes to .c/.h files in the EmbeddedPkg package Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Michael Kubacki Reviewed-by: Andrew Fish