Tianocore/edk2.git/EmbeddedPkg/Library/PrePiLib/FwVol.c, branch master

EmbeddedPkg: PrePiLib: Fix uninitialized variable warnings

2026-06-24T14:49:50+00:00

In FfsProcessSection(), delete CompressionSectionHeaderSize and move CompressedData to avoid the compiler warning without changing functional behavior. Signed-off-by: Tuan Phan

EmbeddedPkg, OvmfPkg: Produce FV3 HOBs for Extracted FVs

2026-06-13T09:06:33+00:00

EmbeddedPkg's PrePiLib and OvmfPkg's PeilessStartupLib (which uses PrePiLib) only produce FV2 HOBs for extracted FVs. However, FV3 HOBs have superceded FV2 HOBs for describing extracted FVs. This commit updates both of these libs to also produce FV3 HOBs, following PEI's pattern of producing an FV, FV2, and FV3 HOB for each extracted FV. Eventually, only FV3 HOBs will be produced, so this paves the way for that. Continuous-integration-options: PatchCheck.ignore-multi-package Signed-off-by: Oliver Smith-Denny

EmbeddedPkg, OvmfPkg: PrePiLib: Use Correct FvName in FV2 HOB Production

2026-06-13T09:06:33+00:00

PrePiLib is incorrectly producing FV2 HOBs. The FvName field of the FV2 HOB is intended to be the parent FV's name. This way the HOB consumer phase can identify when an FV has already been extracted: if the file name of the extracted FV and the parent FV name match in the FV2 HOB. With the incorrect FvName, DXE will re-extract the already extracted FV, which can be a large performance hit (some platforms we have seen ~1 second). This requires an update to FfsProcessFvFile to pass the parent FV handle through so the FV2 HOB can be correctly produced. OvmfPkg consumers are also updated. Continuous-integration-options: PatchCheck.ignore-multi-package Signed-off-by: Oliver Smith-Denny

EmbeddedPkg: PrePiLib: Zero Volume Info Buffer Before Writing

2026-06-13T09:06:33+00:00

FfsGetVolumeInfo() in PrePiLib does not zero the VolumeInfo buffer before writing to it. However, it has some fields that are expected to be zero if certain conditions are not met. For example, the FvName is expected to be all 0's if the extended header is not present in the FV. Currently, the FvName field will point to garbage if the caller does not zero the buffer first. Flip the expectation and have FfsGetVolumeInfo() zero the buffer before it writes to it. Signed-off-by: Oliver Smith-Denny

EmbeddedPkg: PrePiLib: Skip Extracting if FV3 HOB Found

2026-06-13T09:06:33+00:00

PrePiLib only searches for the existence of an FV2 HOB to determine if an FV has already been extracted. However, FV2 HOBs have been superceded by FV3 HOBs for describing extracted FVs. This commit updates PrePiLib to check for the existence of either an FV2 or FV3 HOB for this FV and skips extracting if either is found. Signed-off-by: Oliver Smith-Denny

EmbeddedPkg/PrePiLib: Prevent overread with FFS size macros

2026-04-13T14:12:17+00:00

Symptom:Unsafe typecasting may lead to out‑of‑bound memory access RootCause: FileSize and FileLength are declared as UINT32 and masked with 0x00FFFFFF to store only the lower 24 bits. Although this approach yields the correct result, it introduces a potential risk due to unsafe typecasting and dereferencing. Solution: Using the predefined macro FFS_FILE_SIZE() from MdePkg\Include\Pi\PiFirmwareFile.h, which safely performs the same operation by reconstructing the size using individual byte access. This commit also addresses the fix for coverity isssue "OVERRUN" Cc: Sachin Ganesh Signed-off-by: Gowtham M

EmbeddedPkg/PrePiLib: minor cleanup in FfsProcessSection ()

2025-09-11T21:05:29+00:00

Drop an else wrapper in FfsProcessSection () on the other side of an if-statemenmt that is an error return. Signed-off-by: Leif Lindholm

EmbeddedPkg/PrePiLib: eliminate unneeded variable in FfsProcessSection ()

2025-09-11T21:05:29+00:00

The "Found" variable provided only a deferred form of success handling, so eliminate it to improve readability. Signed-off-by: Leif Lindholm

EmbeddedPkg/PrePiLib: refactor FfsProcessSection ()

2025-09-11T21:05:29+00:00

Create some helper functions to make FfsProcessSection at least halfway readable by both humans and compilers. Signed-off-by: Leif Lindholm

EmbeddedPkg: CodeQL Fixes.

2025-01-15T11:18:04+00:00

Makes changes to comply with alerts raised by CodeQL. Most of the issues here fall into the following two categories: 1. Potential use of uninitialized pointer. 2. Inconsistent integer width in comparison. Co-authored-by: Taylor Beebe Co-authored-by: Ken Lautner Co-authored-by: Bret Barkelew Signed-off-by: Vineel Kovvuri[MSFT]