EDK II (mirror) https://git.radix-linux.su/Tianocore/edk2.git/atom?h=dependabot%2Fgithub_actions%2Fgithub%2Fcodeql-action-4 2025-04-18T03:48:07+00:00 2025-04-18T03:48:07+00:00 Dun Tan dun.tan@intel.com 2025-04-11T05:11:56+00:00 urn:sha1:be720b8d6cc01383b4eba6174c390798e4194491 This commit is to add two new APIs in EmbeddedPkg PrePiHobLib: 1.The GetNextMemoryAllocationGuidHob () returns the next instance of the Memory Allocation HOB with the matched GUID from a starting HOB pointer. 2.The TagMemoryAllocationHobWithGuid () searchs the HOB list for the Memory Allocation HOB with a matching base address and set the Name GUID. Then the instance of the tagged Memory Allocation HOB with matched base address is returned. Signed-off-by: Dun Tan <dun.tan@intel.com> 2025-01-15T11:18:04+00:00 Vineel Kovvuri[MSFT] vineelko@microsoft.com 2024-10-25T23:37:01+00:00 urn:sha1:aae044a130599427e3562fe5736d7b2d42777272 Makes changes to comply with alerts raised by CodeQL. Most of the issues here fall into the following two categories: 1. Potential use of uninitialized pointer. 2. Inconsistent integer width in comparison. Co-authored-by: Taylor Beebe <taylor.d.beebe@gmail.com> Co-authored-by: Ken Lautner <kenlautner3@gmail.com> Co-authored-by: Bret Barkelew <bret@corthon.com> Signed-off-by: Vineel Kovvuri[MSFT] <vineelko@microsoft.com> 2024-11-11T16:45:29+00:00 Michael Kubacki michael.kubacki@microsoft.com 2024-10-24T23:08:03+00:00 urn:sha1:b904377d0d54a784f9a9348d05088afc80de5c54 Removes the following types from the memory type information HOB produced: - `EfiBootServicesCode` - `EfiBootServicesData` - `EfiLoaderCode` - `EfiLoaderData` This follows the guidance in the whitepaper "A Tour Beyond BIOS Memory Map and Practices in UEFI BIOS". https://github.com/tianocore-docs/Docs/raw/master/White_Papers/A_Tour_Beyond_BIOS_Memory_Map_And_Practices_in_UEFI_BIOS_V2.pdf "NOTE: We recommend a platform only define the ReservedMemory, ACPINvs, ACPIReclaim, RuntimeCode, RuntimeData in Memory Type Information table, because OSes only request these regions to be consistent. There is no need to add BootServicesCode, BootServicesData, LoaderCode, LoaderData in memory type information table, because these regions will not be reserved during S4 resume." Since these memory types are not tracked in memory type information any longer it also reduces the number of resets that may need to occur to update memory type buckets that are not needed. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> 2024-09-05T17:08:51+00:00 Vishal Oliyil Kunnil vishalo@qti.qualcomm.com 2024-08-19T21:05:57+00:00 urn:sha1:013d51771a67ff87e6cb17a57e156ef4b6f4ec54 After updating Doxygen, we can see that SetBootMode returns the BootMode instead of status code as it should, fix it to return status. Signed-off-by: Vishal Oliyil Kunnil <quic_vishalo@quicinc.com> 2024-09-05T17:08:51+00:00 Vishal Oliyil Kunnil vishalo@qti.qualcomm.com 2024-08-19T21:05:57+00:00 urn:sha1:1204de7b50926b01394fefb28a04072305a39ca1 The Doxygen comment for SetBootMode and GetBootMode in PrePiHobLib/Hob.c does not match declaration in PrePiLib.h. The C file has it wrong. Align the text to match the header. Signed-off-by: Vishal Oliyil Kunnil <quic_vishalo@quicinc.com> 2024-01-26T03:40:09+00:00 Gua Guo gua.guo@intel.com 2024-01-11T05:07:50+00:00 urn:sha1:aeaee8944f0eaacbf4cdf39279785b9ba4836bb6 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166 Fix integer overflow in various CreateHob instances. Fixes: CVE-2022-36765 The CreateHob() function aligns the requested size to 8 performing the following operation: ``` HobLength = (UINT16)((HobLength + 0x7) & (~0x7)); ``` No checks are performed to ensure this value doesn't overflow, and could lead to CreateHob() returning a smaller HOB than requested, which could lead to OOB HOB accesses. Reported-by: Marc Beatove <mbeatove@google.com> Cc: Leif Lindholm <quic_llindhol@quicinc.com> Reviewed-by: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Abner Chang <abner.chang@amd.com> Cc: John Mathew <john.mathews@intel.com> Authored-by: Gerd Hoffmann <kraxel@redhat.com> Signed-off-by: Gua Guo <gua.guo@intel.com> 2021-12-07T17:24:28+00:00 Michael Kubacki michael.kubacki@microsoft.com 2021-12-05T22:53:56+00:00 urn:sha1:e7108d0e9655b1795c94ac372b0449f28dd907df REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3737 Apply uncrustify changes to .c/.h files in the EmbeddedPkg package Cc: Andrew Fish <afish@apple.com> Cc: Leif Lindholm <leif@nuviainc.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Reviewed-by: Andrew Fish <afish@apple.com> 2021-12-07T17:24:28+00:00 Michael D Kinney michael.d.kinney@intel.com 2021-12-03T02:00:41+00:00 urn:sha1:792433088c8bd67725bf1cc4a89408ec7a112719 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3760 Update all use of ', OPTIONAL' to ' OPTIONAL,' for function params. Cc: Andrew Fish <afish@apple.com> Cc: Leif Lindholm <leif@nuviainc.com> Cc: Michael Kubacki <michael.kubacki@microsoft.com> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> Reviewed-by: Andrew Fish <afish@apple.com> 2021-03-16T20:41:18+00:00 Matthew Carlson matthewfcarlson@gmail.com 2021-03-16T19:53:12+00:00 urn:sha1:66a31de7eeed62a7aa68fe0613a597a8bf08bc16 Currently there is a duplicate GUID shared by two INFs. This rolls the INF for the PrePiHobLib. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2381 Signed-off-by: Matthew Carlson <matthewfcarlson@gmail.com> Reviewed-by: Ard Biesheuvel <ardb@kernel.org> 2019-07-04T11:21:04+00:00 Cœur coeur@gmx.fr 2019-07-03T13:25:30+00:00 urn:sha1:c6a72cd79465594876626e738466441d8b3d61ca Fix various typos in EmbeddedPkg. Signed-off-by: Coeur <coeur@gmx.fr> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>