Tianocore/edk2.git/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial, branch master

DynamicTablesPkg/FdtHwInfoParserLib: Fix serial access size parsing

2026-09-29T03:58:12+00:00

Previously, access size values were taken as-is, instead of mapped to ACPI defines. This made for incorrect parsing of DWORD and QWORD access sizes. Signed-off-by: Djordje Nedic

DynamicTablesPkg/HwInfoParser: Add FdtGetTranslatedReg()

2026-09-11T09:05:39+00:00

The Devicetree Specification [1] defines the "ranges" property. """ The ranges property provides a means of defining a mapping or translation between the address space of the bus (the child address space) and the address space of the bus node’s parent (the parent address space). """ Add a FdtGetTranslatedReg() function, reading the "reg" property of a node and translating the base address through the "ranges" properties present in the node hierarchy. Make use of FdtGetTranslatedReg() wherever relevant. This allows to handle the presence of "ranges" property in a node hierarchy by default. [1] Spec. v0.4, s2.3.8 ranges Signed-off-by: Pierre Gondois

DynamicTablesPkg/HwInfoParser: Add FdtGetReg() helper

2026-09-11T09:05:39+00:00

Add a FdtGetReg() helper to fetch the "reg" property of a node. Use the newly introduce helper wherever relevant. Signed-off-by: Pierre Gondois

DynamicTablesPkg/HwInfoParser: Add FdtResolveInterrupt()

2026-09-11T09:05:39+00:00

The Devicetree Specification [1] defines the concept of interrupt mapping, interrupt domain, interrupt nexus and interrupt controller. An interrupt property might need to be translated through an interrupt nexus to obtain the interrupt type, id, flags. Add a FdtResolveInterrupt() function, resolving an interrupt property through interrupt nexuses until reaching the interrupt-controller node. Make use of FdtResolveInterrupt() wherever relevant. This allows to handle the presence of interrupt nexus by default. [1] Spec. v0.4, s2.4 Interrupts and Interrupt Mapping Signed-off-by: Pierre Gondois

DynamicTablesPkg/HwInfoParser: Add Size param to interrupt getters

2026-09-11T09:05:39+00:00

Add a Size parameter to: - FdtGetInterruptId() - FdtGetInterruptFlags() This allows to check the size of the interrupt data to parse inside the later functions. Signed-off-by: Pierre Gondois

DynamicTablesPkg/HwInfoParser: Relax GetNodeInterruptCells()

2026-09-11T09:05:39+00:00

FdtGetInterruptCellsInfo() expects to receive an interrupt controller node. However, a common use-case is to get the "#interrupt-cells" of a non interrupt-controller node in order to decode an "interrupts" property. Add a "SearchInHierarchy" parameter to FdtGetInterruptCellsInfo() to conditionnaly relax the function and either get the "#interrupt-cells" property: - from the input node - from the hierachy of the input node. Signed-off-by: Pierre Gondois

DynamicTablesPkg/HwInfoParser: Split FdtGetIntcParentNode()

2026-09-11T09:05:39+00:00

The Devicetree Specification [1] defines the concept of interrupt mapping, interrupt domain, interrupt nexus and interrupt controller. The "interrupt-controller" property defines a node as an interrupt controller. The "interrupt-map" property defines a node as an interrupt nexus. Both node types are defined as the root of an interrupt domain. A GIC (Generic Interrupt Controller) is an interrupt controller. The GIC version should be fetched to the matching device tree node. A node defining an interrupt domain might not necessarily be an interrupt controller and contain this information. Introduce 2 functions: - FdtGetIntControllerNode() - FdtGetIntDomainNode()` to distinguish the 2 concepts. As the presence of interrupt nexus/domains is currently not supported, replace FdtGetIntcParentNode() calls with FdtGetIntControllerNode(). The distinction will be useful in following patches. Also, update the detection of an interrupt domain to the presence of one of these properties: - interrupt-controller - interrupt-map instead of relying on the presence of the #interrupt-cells property, which is not a guarantee. [1] Spec. v0.4, s2.4 Interrupts and Interrupt Mapping Signed-off-by: Pierre Gondois

DynamicTablesPkg/HwInfoParser: Rename FdtGetIntcParentNode

2026-09-11T09:05:39+00:00

The interrupt parent of a node is: - the node pointed by the "interrupt-parent" property if the property is present - the direct parent otherwise. FdtGetIntcParentNode() doesn't aim to find the next parent node in the interrupt hierarchy. It aims to find the interrupt-controller node upon which the input node depends. This interrupt-controller node might be multiple nodes up in the device tree hierarchy. Thus, rename FdtGetIntcParentNode() to FdtGetIntcNode() to make the function name less ambiguous and prepare for the addition of a function which gets the next parent node in an interrupt hierarchy. No functional change. Signed-off-by: Pierre Gondois

DynamicTablesPkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

DynamicTablesPkg/FdtHwInfoParserLib/Serial: RISC-V: Convert to GSI

2025-12-02T20:52:41+00:00

In RISC-V, the GSI space is spread across multiple PLICs/APLICs. Hence, any device's IRQ number in the FDT should be appropriately converted to a GSI number based on its parent interrupt controller. Do this for UART parsing in RISC-V. Signed-off-by: Sunil V L