Tianocore/edk2.git/DynamicTablesPkg/Library/Common/AmlLib, branch master

DynamicTablesPkg/AmlLib: Fix root node cleanup leak

2026-09-23T12:23:44+00:00

AmlCreateRootNode() calls AmlDeleteRootNode() when SDT header allocation fails. However, AmlDeleteRootNode() rejects a NULL header and returns without freeing the root node, leaking the node allocation. Allow AmlDeleteRootNode() to handle a NULL SDT header and always free the root node. Signed-off-by: Amrathesh

DynamicTablesPkg/AmlLib: Fix data node cleanup leak

2026-09-23T12:23:44+00:00

AmlCreateDataNode() calls AmlDeleteDataNode() when buffer allocation fails. However, AmlDeleteDataNode() rejects a NULL buffer and returns without freeing the data node, leaking the node allocation. Allow AmlDeleteDataNode() to handle a NULL buffer and always free the data node. Signed-off-by: Amrathesh

DynamicTablesPkg/AmlLib: Fix fixed argument bounds check

2026-09-23T12:23:44+00:00

AmlSetFixedArgument() accepts an index equal to the fixed argument count. The count is an exclusive upper bound, so this permits an out-of-bounds write to the FixedArgs array. Require the index to be strictly less than the fixed argument count. Signed-off-by: Amrathesh

DynamicTablesPkg/AmlLib: Fix serialization buffer size handling

2026-09-23T12:23:44+00:00

AmlSerializeTree uses a reversed buffer size comparison. As a result, it returns success without serializing when the buffer is larger than needed and attempts serialization when the buffer is too small. Return EFI_BUFFER_TOO_SMALL when Buffer is NULL or the supplied buffer is too small, and always report the required size. Update AmlSerializeDefinitionBlock to handle the expected size query status. Signed-off-by: Amrathesh

DynamicTablesPkg: Add AmlLib logical equality generator

2026-09-10T10:21:41+00:00

Add AmlCodeGenEqual() to create an AML LEqual expression from two supplied operands. Use the existing AML_METHOD_PARAM representation for integer, method argument, and local variable operands. The generated equality expression can be used as a predicate by control-flow objects. Signed-off-by: Varshit Pandya

DynamicTablesPkg: Add AmlLib If code generator

2026-09-10T10:21:41+00:00

Add AmlCodeGenIf() to create an AML If object from a supplied predicate node. The API takes ownership of the predicate and returns an If node to which executable statements can subsequently be appended. Signed-off-by: Varshit Pandya

DynamicTablesPkg: Validate fixed AML argument is detached

2026-09-10T10:21:41+00:00

AmlSetFixedArgument() attaches NewNode to an AML object but does not currently verify that the node is detached. Passing an already attached node could leave the AML tree in an inconsistent state. Require non-NULL argument nodes to be detached before attaching them. Continue accepting NULL because callers use it to clear a fixed argument. Signed-off-by: Varshit Pandya

DynamicTablesPkg: Correct AML package length calculation

2026-09-10T10:21:41+00:00

Use AmlComputePkgLength() when calculating the package lengths for Device, ThermalZone, and Scope objects. The package-length encoding width is included in the encoded length and can itself increase when that width is added. AmlComputePkgLength() handles this boundary condition correctly. Signed-off-by: Varshit Pandya

DynamicTablesPkg: Add AmlLib Store generator

2026-09-10T10:21:41+00:00

Add AmlCodeGenStoreToName() to create an AML Store operation with a typed source operand and a named target. Support integer, method argument and local variable sources using the AML_METHOD_PARAM representation. Append the generated Store node to an optional parent object. Signed-off-by: Varshit Pandya

DynamicTablesPkg: Add AmlLib NamedField code generator

2026-09-10T10:21:41+00:00

Add AmlCodeGenFieldElemNamed() to create a named element within an AML Field list. The API validates the supplied NameSeg and field length, encodes the length using the AML FieldPkgLen format, and appends the resulting NamedField node to its parent Field object. Signed-off-by: Varshit Pandya