Tianocore/edk2.git/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlTree.c, branch master

DynamicTablesPkg/AmlLib: Fix fixed argument bounds check

2026-09-23T12:23:44+00:00

AmlSetFixedArgument() accepts an index equal to the fixed argument count. The count is an exclusive upper bound, so this permits an out-of-bounds write to the FixedArgs array. Require the index to be strictly less than the fixed argument count. Signed-off-by: Amrathesh

DynamicTablesPkg: Validate fixed AML argument is detached

2026-09-10T10:21:41+00:00

AmlSetFixedArgument() attaches NewNode to an AML object but does not currently verify that the node is detached. Passing an already attached node could leave the AML tree in an inconsistent state. Require non-NULL argument nodes to be detached before attaching them. Continue accepting NULL because callers use it to clear a fixed argument. Signed-off-by: Varshit Pandya

DynamicTablesPkg: Apply uncrustify changes

2021-12-07T17:24:28+00:00

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3737 Apply uncrustify changes to .c/.h files in the DynamicTablesPkg package Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Michael Kubacki Reviewed-by: Sami Mujawar

DynamicTablesPkg: Set EndTag's Checksum if RdList is modified

2021-10-08T15:39:42+00:00

ACPI 6.4, s6.4.2.9 "End Tag": "This checksum is generated such that adding it to the sum of all the data bytes will produce a zero sum." "If the checksum field is zero, the resource data is treated as if the checksum operation succeeded. Configuration proceeds normally." To avoid re-computing checksums, if a new resource data elements is added/removed/modified in a list of resource data elements, the AmlLib resets the checksum to 0. This patch also refactors the AmlAppendRdNode() function by getting the last Resource Data node directly instead of iterating over all the elements of the list of Resource Data node. Reviewed-by: Sami Mujawar Signed-off-by: Pierre Gondois

DynamicTablesPkg: AmlLib fix ECC errors

2020-10-21T13:33:03+00:00

Fix the following ECC reported errors in AmlLib. - [1008] File has invalid Non-ACSII char. - [9002] The function headers should follow Doxygen special documentation blocks in section 2.3.5 Comment does NOT have tail **/ Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov

DynamicTablesPkg: AML tree interface

2020-08-13T18:00:06+00:00

The AML tree is composite and has the following node types: - Root node. - Object node. - Data node. These nodes are part of the Fixed Arguments or the Variable arguments list in the AML tree. The AML tree interface provides functions to manage the fixed and the variable argument nodes in the AML tree. Signed-off-by: Pierre Gondois Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov