Tianocore/edk2.git/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c, branch master

DynamicTablesPkg/AmlLib: Fix root node cleanup leak

2026-09-23T12:23:44+00:00

AmlCreateRootNode() calls AmlDeleteRootNode() when SDT header allocation fails. However, AmlDeleteRootNode() rejects a NULL header and returns without freeing the root node, leaking the node allocation. Allow AmlDeleteRootNode() to handle a NULL SDT header and always free the root node. Signed-off-by: Amrathesh

DynamicTablesPkg/AmlLib: Fix data node cleanup leak

2026-09-23T12:23:44+00:00

AmlCreateDataNode() calls AmlDeleteDataNode() when buffer allocation fails. However, AmlDeleteDataNode() rejects a NULL buffer and returns without freeing the data node, leaking the node allocation. Allow AmlDeleteDataNode() to handle a NULL buffer and always free the data node. Signed-off-by: Amrathesh

DynamicTablesPkg: Validate AML package length on node creation

2026-09-10T10:21:41+00:00

Validate that the package length passed to AmlCreateObjectNode() fits within the 28-bit limit defined by the AML package-length encoding. Perform the validation centrally so that it applies consistently to all callers. Signed-off-by: Varshit Pandya

DynamicTablesPkg: Fix some spelling mistakes found by cspell

2024-08-01T19:53:47+00:00

When cspell is installed (via `npm install cspell`), CI checks for spelling mistakes. There are currently a very large number of them: some are genuine mistakes while others are words or acryonyms that cspell doesn't know. Fix a few of the misspellings in DynamicTablesPkg. Signed-off-by: Rebecca Cran

DynamicTablesPkg: Apply uncrustify changes

2021-12-07T17:24:28+00:00

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3737 Apply uncrustify changes to .c/.h files in the DynamicTablesPkg package Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Michael Kubacki Reviewed-by: Sami Mujawar

DynamicTablesPkg: Clear pointer in node creation fcts

2021-10-08T15:39:42+00:00

The following functions: - AmlCreateRootNode() - AmlCreateObjectNode() - AmlCreateDataNode() create a node and return it by populating a pointer. This pointer should only be considered/used if the function returns successfully. Otherwise, the value stored in this pointer should be ignored. For their error handling, some other functions assume that this pointer is reset to NULL if an error occurs during a node creation. To make this assumption correct, explicitly clear this input pointer. Reviewed-by: Sami Mujawar Signed-off-by: Pierre Gondois

DynamicTablesPkg: AmlLib fix ECC errors

2020-10-21T13:33:03+00:00

Fix the following ECC reported errors in AmlLib. - [1008] File has invalid Non-ACSII char. - [9002] The function headers should follow Doxygen special documentation blocks in section 2.3.5 Comment does NOT have tail **/ Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov

DynamicTablesPkg: AML node definitions

2020-08-13T18:00:06+00:00

AML has a complex grammar, and this makes runtime modifications on an AML byte stream difficult. A solution is to parse the AML bytecode and represent it in a tree data structure, henceforth called the AML tree. The AML tree is composite in the sense it has the following node types: - A 'Root node' that represents the root of the AML tree. - An 'Object node' that contains the OP Code (AML Encoding). - A 'Data node' that contains a data buffer. The Root node contains the Definition block header (ACPI header) and a Variable Argument list. The Object node is composed of an array of Fixed Arguments and a Variable Argument list. Fixed arguments can be either Object Nodes or Data nodes. Their placement (index) in the Fixed Argument array is defined by the AML encoding of the enclosing Object Node. Variable arguments can be Object nodes or Data nodes. Following is a depiction of a typical AML tree: (/) # Root Node \ |-{(N1)->...} # Variable Argument list, N1 is \ # an Object Node \ /-i # Child of fixed argument b \ / |- [a][b][c][d] # Fixed Arguments |- {(e)->(f)->(g)} # Variable Arguments \ \-h # Child of variable argument e Signed-off-by: Pierre Gondois Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov