Tianocore/edk2.git/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c, branch masterEDK II (mirror)https://git.radix-linux.su/Tianocore/edk2.git/atom?h=master2026-07-31T12:56:11+00:00DynamicTablesPkg/AmiLib: Fix stack corruption in AmlCodeGenRdInterrupt2026-07-31T12:56:11+00:00Tuan Phantuan.phan@oss.qualcomm.com2026-07-24T04:49:37+00:00urn:sha1:82dd8ab1b374a907bff6a009d5f0efc510d53a98
In AmlCodeGenRdInterrupt(), the IRQ list was copied directly into an
EFI_ACPI_EXTENDED_INTERRUPT_DESCRIPTOR structure allocated on the stack.
Since the structure only contains storage for the first interrupt entry,
copying multiple IRQs would write beyond the allocated buffer and corrupt
the stack.
Fix this issue by allocating the descriptor dynamically with sufficient
space to accommodate the entire IRQ list. This ensures all interrupt entries
are copied safely without overwriting adjacent stack memory.
Signed-off-by: Tuan Phan <tuan.phan@oss.qualcomm.com>
DynamicTablesPkg: Move CheckAddressSpaceFields() to AmlUtility.c2026-07-10T23:45:20+00:00Pierre Gondoispierre.gondois@arm.com2026-07-08T14:54:08+00:00urn:sha1:10aef94c8b963099ece9c1a8dea5dfd1ea095730
Move the CheckAddressSpaceFields() function to AmlUtility.c
to allow other files to re-use it.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
DynamicTablesPkg/AmlLib: Remove invalid ASSERT for IRQ macro generation2025-12-11T10:37:26+00:00Abdul Lateef AttarAbdulLateef.Attar@amd.com2025-12-07T06:57:29+00:00urn:sha1:14aa197f71cc7bc7bb7ecd8184dfb062fd581d03
The ACPI specification does not require legacy IRQs (x86) to be
ActiveLow when EdgeTriggered or vice-versa.
Hence the ASSERT checking for ActiveLow when EdgeTriggered is
removed for IRQ macro generation non-ARM architecture.
The IRQNoFlags macro defaults to EdgeTrigger and ActiveHigh
configuration, demonstrating that this combination is valid.
Reference: ACPI Specification 6.5
- Section 19.6.66: IRQ (Interrupt Resource Descriptor Macro)
- Section 19.6.67: IRQNoFlags (Interrupt Resource Descriptor Macro)
Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
DynamicTablesPkg: Adds AML code generation for serial UART RD2025-07-21T13:50:05+00:00Abdul Lateef AttarAbdulLateef.Attar@amd.com2025-06-24T10:42:13+00:00urn:sha1:7d8760875a7f16312f88cf80821b25387c764a4e
Adds AML code generation for Serial UART resource descriptor.
This commit introduces helper functions to generate
AML resource data for serial UART resource descriptor.
Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
DynamicTablesPkg: Adds AML code generation for IRQ2025-07-21T13:50:05+00:00Abdul Lateef AttarAbdulLateef.Attar@amd.com2025-06-24T07:28:46+00:00urn:sha1:d1f84858228caeeff926b70e43d389eff34363c2
Adds AML code generation for IRQ resource descriptor.
This commit introduces helper functions to generate
AML resource data for IRQ resource descriptors.
Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
DynamicTablesPkg: Drop the unnecessary comparision of UINT8 max value2024-10-24T10:37:22+00:00Sudeep Hollasudeep.holla@arm.com2024-10-23T12:40:54+00:00urn:sha1:8af71632d6552e637a2ce29c579c70ccc562ba7b
Clang build breaks with the following error:
| DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c:1441:20:
| error: result of comparison of constant 256 with expression of type 'UINT8'
| (aka 'unsigned char') is always false [-Werror,-Wtautological-constant-out-of-range-compare]
| 1441 | (AccessSize > 256)) ||
| | ~~~~~~~~~~ ^ ~~~
| 1 error generated.
AccessSize is UINT8 and the maximum value for UINT8 is 255, so the
comparision is unnecessary. Drop the check to fix the build.
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
DynamicTablesPkg: AML code generation for IO resouce descriptor.2024-08-30T01:46:19+00:00Abdul Lateef AttarAbdulLateef.Attar@amd.com2024-08-07T10:27:36+00:00urn:sha1:6a7be5a8418ab6397375e32e399e9523db9d4293
Add helper functions to generate AML resource data
for I/O resource descriptor.
Cc: Pierre Gondois <pierre.gondois@arm.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
DynamicTablesPkg: Corrects AmlCodeGenRdWordBusNumber parameters2023-12-22T08:48:25+00:00Abdul Lateef AttarAbdulLateef.Attar@amd.com2023-11-29T10:10:44+00:00urn:sha1:f8c918c46f9565b67c01739bb92c0819b9d795a0
Corrects the parameters of AmlCodeGenRdWordBusNumber() to
UINT16 to generate word bus number.
Cc: Pierre Gondois <pierre.gondois@arm.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
DynamicTablesPkg: AML Code generation for word I/O ranges2023-12-22T08:48:25+00:00Abdul Lateef AttarAbdulLateef.Attar@amd.com2023-11-29T09:46:46+00:00urn:sha1:ea65643547098b9ee70733b221f775e6d3aa8e11
Add helper functions to generate AML resource data
for word I/O.
Cc: Pierre Gondois <pierre.gondois@arm.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
DynamicTablesPkg/AmlLib: Enumerate memory attributes2023-10-23T18:38:59+00:00Jeshua Smithjeshuas@nvidia.com2023-10-05T16:38:49+00:00urn:sha1:309450db268c8721afa102c7c49adccd153b0e88
AmlCodeGenRdQWordMemory's and AmlCodeGenRdDWordMemory's Cacheable
and MemoryRangeType parameters treat specific values as having
specific meanings as defined by the spec. This change adds enums to map
those meanings to their corresponding values.
Signed-off-by: Jeshua Smith <jeshuas@nvidia.com>
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com>
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>