Tianocore/edk2.git/BaseTools/Source, branch dependabot/github_actions/github/codeql-action-4.39.1

BaseTools: FvHandler: Safely update FV free-space nodes

2026-10-22T01:36:43+00:00

Current FV resize routine assumes that the final child is always a free- space node. However, when no such node exists, these routines can remove or overwrite valid trailing FFS nodes. One replacement path also inserts the free-space byte count instead of the constructed tree node. This change centralizes free-space node creation, resizing, and removal, using the helper for direct replacements and recursive parent resizing. Signed-off-by: Kun Qin

BaseTools: FMMTOperation: Use distinct FFS trees for repeated replacement

2026-10-22T01:36:43+00:00

Current `ReplaceFfs` reuses the parsed replacement FFS tree for every matching target. However, `FvHandler` mutates the tree while attaching it to a target, causing later replacements inherit state from an earlier replaced instance and hang the process. This change uses deep-copy of the replacement tree for each target to avoid the failure case. Signed-off-by: Kun Qin

BaseTools: Reject trailing content after !else and !endif

2026-10-08T03:58:55+00:00

The DSC parser accepts "!else if " as an unconditional !else branch without evaluating the trailing condition. This can select an unintended build branch instead of reporting the syntax error. For example, the following incorrect syntax is currently accepted: !if $(MODE) == 1 # Branch A !else if $(MODE) == 2 # Branch B !endif When MODE is 3, the parser treats the second directive as a plain !else and selects branch B. Replacing it with "!elseif $(MODE) == 2" would correctly select neither branch. Reject trailing content after !else and !endif. When the first word following !else is "if", suggest "!elseif " instead. Trailing comments remain valid because they are removed before directive parsing. Cc: Fei Shen Signed-off-by: Dongyan Qian

BaseTools/FMMT: Return non-zero exit status on failure

2026-09-29T17:12:07+00:00

FMMT catches exceptions from operations such as viewing a missing input file, prints the error, and then returns status 0. Callers and scripts treat that as success. Set status to 1 in the exception handler so the process exit code matches the failure. A regression test covers FMMT -v not-a-file. Signed-off-by: Zhaoqi Xu

BaseTools/FirmwareStorageFormat: Fix FV ext entry struct factory functions

2026-09-13T19:05:51+00:00

The Refine_FV_EXT_ENTRY_OEM_TYPE_Header() and Refine_FV_EXT_ENTRY_GUID_TYPE_Header() functions incorrectly return an instantiation attempt of the local class with `Structure` as an argument (e.g., `return ClassName(Structure)`) instead of returning the class itself (e.g., `return ClassName`). This causes FMMT to fail with: "expected EFI_FIRMWARE_VOLUME_EXT_ENTRY instance, got _ctypes.PyCStructType" When processing FVs that contain ext header entries of type 0x01 (OEM Type) or type 0x02 (GUID Type, used for FV UI Name when FvNameString = TRUE). Fix by returning the class directly, matching the pattern used by Refine_FV_Header() which correctly returns the class for subsequent .from_buffer_copy() calls. Signed-off-by: Michael D Kinney

BaseTools: Optimize parsing of byte-array PCD values

2026-09-06T23:50:31+00:00

This change adds a fast path for simple VOID* hexadecimal byte arrays, avoiding the generic expression tokenizer's repeated processing of large PCD values. Regression tests for both paths. It does not change the existing parser for structured and symbolic expressions. This reduces parsing time for a 28 KiB generated PCD from roughly 2 seconds to 50 milliseconds. Signed-off-by: Kun Qin

BaseTools/GenSec: Use SECTION_SIZE to read section size

2026-09-03T10:36:41+00:00

Replace the open-coded read of the 3-byte section Size[] field with the SECTION_SIZE() macro from Pi/PiFirmwareFile.h. The macro reads exactly the three Size[] bytes (endianness-safe) instead of a 4-byte load that over-reads the adjacent byte. No functional change. Verified by building BaseTools and running GenSec: python3 BaseTools/Edk2ToolsBuild.py -t GCC GenSec -s EFI_SECTION_RAW -o out.sec in.bin # in.bin: 100 bytes out.sec is 104 bytes: the 100-byte payload plus the 4-byte EFI_COMMON_SECTION_HEADER. The Size field of the header reads 0x000068, matching out.sec's size that is calculated by SECTION_SIZE. Generated with the following Coccinelle semantic patch: ```smpl @@ EFI_COMMON_SECTION_HEADER *E; typedef UINT32; @@ ( - *(UINT32 *)(E->Size) & 0x00FFFFFF + SECTION_SIZE (E) | - *(UINT32 *)E->Size & 0x00FFFFFF + SECTION_SIZE (E) ) ``` Signed-off-by: Mingjie Shen

BaseTools: Make DSC arch macro expansion owner-aware

2026-09-01T14:42:26+00:00

PR #12628 expanded architecture macros for every DSC record so component-private records match their component. A positive raw owner can also represent include provenance, so broad expansion changes records outside component scope. Expand architecture macros only for Component records and records whose owner maps to a final Component. Reset the owner mapping whenever the post-processed table is rebuilt to prevent stale ownership across DoPostProcess calls. Add regression coverage for component-private LibraryClasses and PCDs, nested and private includes, multiple architectures, unresolved macros, repeated sections, and repeated post-processing. Signed-off-by: Bob Chen (UST Global Singapore Pte Limited)

BaseTools/Python: Remove error message with email address

2026-08-28T10:04:05+00:00

Remove the "Please send email to devel@edk2.groups.io" message from the unhandled exception handlers in build.py, GenFds.py, Trim.py, and the UPT tools. Also remove the now-unused MSG_EDKII_MAIL_ADDR and MSG_SEARCH_FOR_HELP constants from Common/DataType.py and UPT/Logger/StringTable.py. Signed-off-by: Vishal Oliyil Kunnil

BaseTools/Build: Output warning message for library class mismatch

2026-08-06T04:55:34+00:00

Performs a check that will verify that the library instance implements the library specified in the dsc by ensuring a LIBRARY_CLASS definition exists in the INF [Defines] section and the value matches the library it says it is implementing. As an example, from a platform dsc file: BaseBmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.inf BaseBmpSupportLib is supposed to be of library class BmpSupportLib, but the dsc defines it incorrectly, the warning message will be displayed during build. Signed-off-by: Aaron Pop Co-authored-by: Poncho Figueroa