Tianocore/edk2.git/BaseTools/Source/Python, branch dependabot/github_actions/actions/github-script-9

BaseTools: Reject Inline Comments in tools_def

2026-04-21T00:18:43+00:00

There is a bug in BaseTools currently when an inline comment is used in tools_def. The comment is not stripped out and wreaks havoc down the line, causing BaseTools to get confused elsewhere and drop build options it should be applying. This fixes that behavior by following the build spec which states: Comments are only allows on separate lines and may not be appended appear on actual entry lines. Inline comments are now not allowed and the build will fail and specify why and where. Signed-off-by: Oliver Smith-Denny

BaseTools: Ecc: Update to ANTLR 4.13.2

2026-04-08T22:23:35+00:00

ANTLR 4.9 is broken in python 3.13 because it uses a library in the autogenerated files that is removed. This updates to 4.13.2 and also updates the autogen files, which contain support for python 3.13 as well as backwards compat. Signed-off-by: Oliver Smith-Denny

BaseTools: Ecc: Use SPDX in AutoGen Template

2026-04-08T22:23:35+00:00

The ANTLR autogen files are currently created without an SPDX identifer. Add the BSD-2-Clause-Patent ID. While here, correct the command to do the autogeneration by using the right filename. Signed-off-by: Oliver Smith-Denny

BaseTools: Ecc: Drop ANTLR 3 Support

2026-04-08T22:23:35+00:00

BaseTools hasn't been using ANTLR3 since at least 2019. Drop the files. Signed-off-by: Oliver Smith-Denny

BaseTools/Source/Python/Trim: Add -f/--source-code-format option

2026-03-06T19:47:31+00:00

Add --source-code-format option that can be NASM or not specified. This can be used for file format specific actions when --source-code is used. A NASM specific action is added to convert #line to %line to preserve reference the originating NASM source file for source level debug in NASM format. Without this change, the source level debug of NASM files loads the generated intermediate file in the build output directory. Signed-off-by: Michael D Kinney

BaseTools: fix mdlint issues

2026-03-04T22:02:33+00:00

Fix markdownlint formatting issues in READMEs. Signed-off-by: Sherry Fan

BaseTools/Eot: Apply CParser4 ANTLR 4.9 regeneration whitespace changes

2026-02-27T23:18:15+00:00

Whitespace-only changes produced by the ANTLR 4.9 code generator. Signed-off-by: Michael Kubacki

BaseTools/Eot: Regenerate CParser4 files with ANTLR 4.9

2026-02-27T23:18:15+00:00

BaseTools/Ecc: Apply CParser4 ANTLR 4.9 regeneration whitespace changes

2026-02-27T23:18:15+00:00

Whitespace-only changes produced by the ANTLR 4.9 code generator. Signed-off-by: Michael Kubacki

BaseTools/Ecc: Regenerate CParser4 files with ANTLR 4.9

2026-02-27T23:18:15+00:00

The CParser4 Python parser files (CLexer.py, CParser.py, CListener.py) were generated 7 years ago with ANTLR 4.7.1. Meanwhile, pip-requirements.txt pins antlr4-python3-runtime to version 4.9 in commit 4a7dd50, but the files were patched, not fully regenerated. This version mismatch produced two failures when running EccMain.py against non-trivial C code: 1. A runtime warning on every file parsed: "ANTLR runtime and generated code versions disagree: 4.9!=4.7.1" 2. A crash when parsing complex C constructs that exercise the struct/union definition rule in CParser.py: TypeError: '<' not supported between instances of 'tuple' and 'int' This occurs in antlr4/BufferedTokenStream.py getText() because the 4.9 runtime changed the expected argument types for that method, and the 4.7.1-generated parser was passing a tuple where an int is now required. This change regenerates the CParser4 files with ANTLR 4.9 to resolve the version mismatch. Steps used to regenerate the files: 1. Download the ANTLR 4.9 complete tool JAR: - `https://www.antlr.org/download/antlr-4.9-complete.jar` 2. Generate Python3 parser files from the grammar: ``` java -jar antlr-4.9-complete.jar ` -Dlanguage=Python3 -visitor ` -o BaseTools/Source/Python/Ecc/CParser4_new ` BaseTools/Source/Python/Ecc/CParser4/C.g4 ``` Signed-off-by: Michael Kubacki