EDK II (mirror) https://git.radix-linux.su/Tianocore/edk2.git/atom?h=trunk 2024-06-04T03:43:08+00:00 2024-06-04T03:43:08+00:00 kx kx@radix.pro 2024-06-04T03:43:08+00:00 urn:sha1:7e2ccccace24636f29ddc210b94606abd4c7e42b 2022-10-19T06:32:07+00:00 Pierre Gondois pierre.gondois@arm.com 2022-10-03T07:47:32+00:00 urn:sha1:b03dceb87f400e2e5437f775427fab5338532ee7 In an effort to clean the documentation of the above package, remove duplicated words. Cc: Bob Feng <bob.c.feng@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Reviewed-by: Bob Feng <bob.c.feng@intel.com> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> 2022-06-27T01:06:48+00:00 Rebecca Cran quic_rcran@quicinc.com 2022-06-19T22:07:09+00:00 urn:sha1:b600f253b3077943908431cd780dbc1a9ed1bc81 Signed-off-by: Rebecca Cran <quic_rcran@quicinc.com> Reviewed-by: Yuwei Chen <yuwei.chen@intel.com> Reviewed-by: Bob Feng <bob.c.feng@intel.com> 2022-03-28T01:45:05+00:00 wenyi,xie via groups.io xiewenyi2=huawei.com@groups.io 2022-03-18T06:09:24+00:00 urn:sha1:ec30a4a0c324cf24f1824ab5169923f854986798 REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3872 When doing ecc inf version check, the decimal type version number like 1.27 is treated as invalid version. So the code should be updated to support decimal type version number. Cc: Bob Feng <bob.c.feng@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Yuwei Chen <yuwei.chen@intel.com> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com> Reviewed-by: Bob Feng <bob.c.feng@intel.com> 2021-10-13T09:07:16+00:00 Chen, Christine Yuwei.Chen@intel.com 2021-10-12T04:07:38+00:00 urn:sha1:6ed6abd6c116e8599876a2876b77e172e800b13e Currently the realpath is used when parse modules, which shows the path with a drive letter in build log. In Windows 'subst' comand is used to associates a path with a drive letter, when use the mapped drive letter for build, with realpath function the build log will have different disk letter info which will cause confusion. In this situation, if use adspath function to show the path info, it will keep same letter with the mapped drive letter, which avoids confusion. This patch modifies the realpath to abspath. Cc: Bob Feng <bob.c.feng@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Signed-off-by: Yuwei Chen <yuwei.chen@intel.com> Reviewed-by: Bob Feng <bob.c.feng@Intel.com> 2021-03-18T02:04:18+00:00 Pierre Gondois Pierre.Gondois@arm.com 2021-03-17T09:59:37+00:00 urn:sha1:ce6c2b0016c2f68b6008acea1f24ed966b647147 The Ecc tool checks the format of the include guard. This check is currently done on all the names following the '#ifndef' statement. It should only be done on the first include guard. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3252 Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com> Reviewed-by: Liming Gao <liming.gao@intel.com> Reviewed-by: Bob Feng <bob.c.feng@intel.com> 2021-02-26T05:40:32+00:00 Pierre Gondois Pierre.Gondois@arm.com 2021-02-16T09:29:07+00:00 urn:sha1:6ffbb3581ab7c25a35041bac03b760af54f852bf The EDK II C Coding Standards Specification states that: "Names starting with one or two underscores, such as _MACRO_GUARD_FILE_NAME_H_, must not be used. They are reserved for compiler implementation." [1] The Ecc tool currently checks that the include guard end with a trailing underscore. Thus, the check and the error message should both be modified. The new check forces having one sole trailing underscore character, as the example in the specification shows: "FILE_NAME_H_" [1] This would allow to have more consistency. [1] Section 5.3.5 "All include file contents must be protected by a #include guard": https://edk2-docs.gitbook.io/ edk-ii-c-coding-standards-specification/5_source_files/53_include_files Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com> Reviewed-by: Sami Mujawar <Sami.Mujawar@arm.com> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> 2021-02-01T18:01:02+00:00 Kun Qin kun.q@outlook.com 2021-01-14T20:25:13+00:00 urn:sha1:4bae4f02f319a5874f19480733138c9eff460157 Function '_ModuleEntryPoint' is a pre-defined interface for various EFI module types and should not be caught violating EFI coding style. This change added '_ModuleEntryPoint' into exception list to fix EFI coding style error 8006 during CI build. Cc: Bob Feng <bob.c.feng@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Yuwei Chen <yuwei.chen@intel.com> Signed-off-by: Kun Qin <kun.q@outlook.com> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> Reviewed-by: Bob Feng <bob.c.feng@intel.com> 2020-12-22T01:26:10+00:00 Pierre Gondois Pierre.Gondois@arm.com 2020-12-10T13:47:50+00:00 urn:sha1:6899e6789a7f978175fc9cafec3459e4f4f8e1dc The Ecc tool currently reports the initialization of variables at declaraton if the variable is non-constant and declared in a function. Static variables locally defined in functions should also be allowed to be initialized at declaration. Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> 2020-12-22T01:26:10+00:00 Sami Mujawar sami.mujawar@arm.com 2020-10-22T08:42:51+00:00 urn:sha1:b23c5b9722b50d598f861c057122e91fa3e6b3fe The ECC tool crashes if a C file has an incorrect file header format. The file ArmPkg\Library\ArmMmuLib\AArch64\ArmMmuPeiLibConstructor.c has a file header in the incorrect format. It uses # to mark the header comments instead of enclosing the file header in /* */. This may have been a result of an INF file header being copied to a C file. A separate patch fixes the C file but ECC tool should not crash if a file with an incorrect header is found. Therefore, update the ECC tool to prevent it from crashing if an incorrect file header is found. With this change the ECC tool will report the incorrect header issue without crashing. Signed-off-by: Sami Mujawar <sami.mujawar@arm.com> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>