Tianocore/edk2.git/BaseTools/Source/C, branch dependabot/github_actions/actions/github-script-9

BaseTools: Add missing machine types while dumping Option Rom

2026-04-23T05:31:47+00:00

When dumping LOONGARCH64 or RISCV64 Option Rom by `EfiRom -d test.rom` command, the machine type is showed as `unknown`. This patch adds type lookup strings for the two architectures. Signed-off-by: Qihang Gao

BaseTools: Enable control flow guard for Windows builds

2026-03-26T02:28:23+00:00

Certain environments require Control Flow Guard (CFG) to be enabled at build time as part of their security hardening requirements. This change adds the necessary compiler and linker flags to enable CFG support. Signed-off-by: Kun Qin

BaseTools: Suppress C4028 warning to support older VS toolchain builds

2026-03-26T02:28:23+00:00

Add conditional suppression of MSVC warning C4028 (formal parameter different from declaration) when building with Visual Studio 2017 or earlier toolchain. This warning is triggered by brotli submodule and not emitted by newer compilers, hence a conditional supression is used. Signed-off-by: Kun Qin

BaseTools: GenFfs/GenFv/GenSec: Fixing Warning 4319 from MSVC

2026-03-13T19:14:49+00:00

This change fixes a warning newly emitted by the latest MSVC, which now treats this warning as an error and causes the build to fail. This change aligns operand types in bitwise expressions by casting sizeof results to UINT32, and promoting a UINT32 to UINTN where required to correctly apply the bitmask. Signed-off-by: Kun Qin

BaseTools/Source/C/Include/Common: Add back include guard

2026-02-27T07:15:11+00:00

Add include guards back to include files that use the same include guard macro in BaseTools/Source/C/Include/Common and MdePkg or MdeModulePkg. Signed-off-by: Michael D Kinney

BaseTools/Source/C/VfrCompile: Fix parallel make failures

2026-02-27T04:54:43+00:00

Update makefile rules to run antlr and dlg to completion before compiling any of the generated cpp files. Without this change, parallel make may start compiling some of the cpp files before both antlr and dlg have finished which produces syntax errors from compilation with partially generated files. Also use &: so the targets are treated as a group and the rule is only executed once for the entire group. Without this change, parallel make may run the rule actions more than once and modify the output while it is being used by another rule. Signed-off-by: Michael D Kinney

BaseTools: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Note: Some files in BaseTools are excluded from the change if they are autogenerated or direcly related to a header from a subproject, etc. In particular, headers in these directories were ignored: - BaseTools/Source/C/LzmaCompress/Sdk/ - BaseTools/Source/C/VfrCompile/Pccts/ Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

BaseTools/VfrCompile: Add #pragma once support

2026-02-23T21:01:28+00:00

The C preprocessor turns each .vfr file into a pre-processed .i file. At this step, the C preprocessor processes `#pragma once`. Then, VfrCompile is called (with `-n` to prevent preprocessing) to parse the pre-processed .i files. The .i files may still contain `#pragma once` lines. Currently, VfrCompile treats `once` as an unknown token, causing parse failures. Originally, this change was going to add a `PragmaOnce` token rule to the VFR lexer grammar (in VfrSyntax.g) that matched `#pragma once` lines and silently skipped them using `skip()` and `newline()`. The `newline()` call would keep line numbers stable for error reporting. This was consistent with how other preprocessor artifacts were already handled like `#line` directives (`LineDefinition` and `GccLineDefinition` tokens) and `extern` declarations (skipped with `mode(CPP_COMMENT)`). Writing a regular expression to match `#pragma once` was simple enough, but it makes overall pragma token recognition more fragile at the lexer level. When the lexer is walking the DFA state table, it could begin to match a `#pragma ` line but then not be able to match remaining characters to recognize tokens other than `once`. Instead, this change handles `#pragma once` lines in the VFR parser grammar in `vfrPragmaDefinition` alongside where `pack` is already handled. Signed-off-by: Michael Kubacki

Revert "BaseTools: Add support for out-of-tree builds"

2026-02-11T22:53:29+00:00

This reverts commit 3fe1d56cc98e011bbde8348f13dfa5e38c95f49e. PR https://github.com/tianocore/edk2/pull/11757 introduced a "Breaking Change" feature for out of tree builds of tools. This breaking change is blocking testing of edk2-stable202602 due to side effects on building FitGen tool in edk2-platforms. Revert this feature for the edk2-stable202602 release and work on this feature after the release. Signed-off-by: Michael D Kinney

Revert "BaseTools/Source/C/Makefile: Update OBJECTS using OS specific SEP"

2026-02-11T22:53:29+00:00

This reverts commit f0542ae07d5e5e4d311bf8ae33bf26b4b1acf9f4. PR https://github.com/tianocore/edk2/pull/11757 introduced a "Breaking Change" feature for out of tree builds of tools. This breaking change is blocking testing of edk2-stable202602 due to side effects on building FitGen tool in edk2-platforms. Revert this feature for the edk2-stable202602 release and work on this feature after the release. Signed-off-by: Michael D Kinney