Tianocore/edk2.git/BaseTools/Scripts/PatchCheck.py, branch dependabot/github_actions/github/issue-labeler-3.5

BaseTools: PatchCheck: Report File Line No, Not Patch

2026-09-08T17:27:21+00:00

Currently, when the GitDiffCheck runs and a failure is reported, PatchCheck reports what line of the patch failed, not the line number of the file. This is not particularly useful because a developer needs the file line number to go fix the issue. This patch updates the behavior to keep track of the file line number (based on the patch reported line numbers) and report that as where the failure occurred instead of the patch line number. Signed-off-by: Oliver Smith-Denny

BaseTools/PatchCheck.py: Skip length check for Co-authored-by line

2026-04-27T06:23:00+00:00

Signed-off-by: Yang Gang

BaseTools: Update wiki links

2026-02-10T05:44:46+00:00

The wiki has moved and this change updates links in BaseTools to reflect the new location. - New location: https://github.com/tianocore/tianocore-wiki.github.io - Rendered version: https://www.tianocore.org/tianocore-wiki.github.io/ - Old location: https://github.com/tianocore/tianocore.github.io/wiki More details: https://github.com/tianocore/edk2/discussions/11969 Signed-off-by: Michael Kubacki

BaseTools/PatchCheck.py: Disallow commit subject lines that end with period

2026-01-12T12:37:59+00:00

Signed-off-by: Mike Beaton

BaseTools: PatchCheck.py: Allow MultiPkg Commits For Subject Check

2025-09-05T06:32:06+00:00

Subject Check was added to PatchCheck.py to enforce that if a package was touched in a commit that it be referenced in the subject line. However, this is impractical for multipackage commits with many packages, e.g. when stack cookies were added, every package was touched, but in a rote way, and it is not reasonable to put every package in a subject line. This updates PatchCheck.py to check if ignore_multi_package is set and if so only require that package names be included in the subject if there are fewer than 3 packages touched. Otherwise, PatchCheck will require the message to start with `Global:` to indicate it touches more than 3 packages. Signed-off-by: Oliver Smith-Denny

BaseTools/PatchCheck.py: Check CI Options Before Parsing

2025-09-05T06:32:06+00:00

PatchCheck.py currently parses the CI options as the last step it does before reporting results. This means that the other checking logic cannot use any of the CI options that are passed in. This updates the order of operations to process CI options before running other checks so that they can be used in performing checks. Signed-off-by: Oliver Smith-Denny

BaseTools/PatchCheck.py: permit at least 20 characters after ':'

2025-07-02T20:14:21+00:00

Commit b55530ad4460 ("BaseTools/PatchCheck.py: verify commit message lists package(s)") introduced a check for the requirement to enumerate all modified packages in the commit subject line. But it did leave the maximum line length at 75 characters (for non-CVE commits), which can get a bit cramped for changes to several packages. Introduce a new arbitrary "at least 20 characters after the :" limit. Signed-off-by: Leif Lindholm

BaseTools/PatchCheck.py: clean up subject line length handling

2025-07-02T20:14:21+00:00

Use a temporary variable for max subject line length and log result of test in one location. Signed-off-by: Leif Lindholm

BaseTools/PatchCheck.py: drop redundant line count check

2025-07-02T20:14:21+00:00

Before doing the subject line length check, the script checks that the number of lines in the commit message (including subject) is not less than or equal to zero - and returns if it is. However, then the test for whether the subject line starts with a CVE tag inexplicably also checks for whether the number of lines are greater than or equal to one. This is just clutter, so drop it. Signed-off-by: Leif Lindholm

BaseTools/PatchCheck.py: verify commit message lists package(s)

2025-06-25T16:22:25+00:00

Verify that the subject line matches the basic {Package}[,Package]: format _or_ the Revert "" format. Non-package top-level directories are treated as packages. Suggested-by: Ard Biesheuvel Signed-off-by: Leif Lindholm