EDK II (mirror) https://git.radix-linux.su/Tianocore/edk2.git/atom?h=dependabot%2Fgithub_actions%2Factions%2Fsetup-python-6 2024-10-30T19:13:09+00:00 2024-10-30T19:13:09+00:00 kuqin12 42554914+kuqin12@users.noreply.github.com 2024-08-01T19:20:01+00:00 urn:sha1:79ad703b55a2534ec97b284d38349f6ff6dab8b8 Makes changes to comply with alerts raised by CodeQL. The issues here fall into the following category: 1. comparison-with-wider-type Signed-off-by: Eeshan Londhe <eeshanlondhe@microsoft.com> 2024-07-16T15:19:27+00:00 levi.yun yeoreum.yun@arm.com 2024-07-08T16:08:48+00:00 urn:sha1:690f13fcb4a7b74b30091c7067a18bb7971982d8 ASSERT_EFI_ERROR would be removed in release build. This means it would trigger wrong behavior when invalid pin number given to Get(), Set() and GetMode(). Adding error check routine for invalid pin number and before check the pin number, check first other argument given to each function. Signed-off-by: Levi Yun <yeoreum.yun@arm.com> 2023-04-10T14:19:57+00:00 Rebecca Cran rebecca@bsdio.com 2023-04-06T19:51:30+00:00 urn:sha1:f20e35982b9172b0823e76315686f962640fb894 __FUNCTION__ is a pre-standard extension that gcc and Visual C++ among others support, while __func__ was standardized in C99. Since it's more standard, replace __FUNCTION__ with __func__ throughout ArmPlatformPkg. Signed-off-by: Rebecca Cran <rebecca@bsdio.com> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com> Reviewed-by: Ard Biesheuvel <ardb@kernel.org> 2022-11-06T15:21:12+00:00 Ard Biesheuvel ardb@kernel.org 2022-10-24T16:53:35+00:00 urn:sha1:cc650a0378f86a4980e7a0d37fef90d46d33afe1 The NorFlashDxe driver in ArmPlatformPkg was shared between development platforms built by ARM Ltd, and virtual platforms that were once modeled after Versatile Express, but have very little in common with actual bare metal implementations. Both sides have migrated to a domain specific version of the driver, so we can retire the old one. Signed-off-by: Ard Biesheuvel <ardb@kernel.org> Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com> Reviewed-by: Sunil V L <sunilvl@ventanamicro.com> 2022-09-09T01:42:39+00:00 Michael Kubacki michael.kubacki@microsoft.com 2022-08-02T11:44:45+00:00 urn:sha1:917a7e3f347adb0721ff161a68309f51f621eec5 These debug messages are repeated in both NorFlashBlockIoReadBlocks() and NorFlashBlockIoWriteBlocks(): "NorFlashBlockIoWriteBlocks(MediaId=0x%x, Lba=%ld, BufferSize=0x%x" "bytes (%d kB), BufferPtr @ 0x%08x)\n" Although this requires 5 arguments, only 4 are provided. The kilobyte value was never given. This change removes that specifier so the 4 arguments match the 4 specifiers in the debug macro. Cc: Leif Lindholm <quic_llindhol@quicinc.com> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Reviewed-by: Ard Biesheuvel <ardb@kernel.org> Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com> 2022-06-22T14:57:31+00:00 Rebecca Cran rebecca@bsdio.com 2022-05-03T20:07:56+00:00 urn:sha1:3930d1791a0657a422d50f4d2e2d2683c36e34b8 The DEBUG output in LcdGraphicsBlt is overly verbose, and makes using the console difficult, for example when using the UiApp. Since the extra output should no longer be needed, delete the DEBUG lines. Signed-off-by: Rebecca Cran <rebecca@bsdio.com> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com> 2021-12-07T17:24:28+00:00 Michael Kubacki michael.kubacki@microsoft.com 2021-12-05T22:53:52+00:00 urn:sha1:40b0b23ed34f48c26d711d3e4613a4bb35eeadff REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3737 Apply uncrustify changes to .c/.h files in the ArmPlatformPkg package Cc: Andrew Fish <afish@apple.com> Cc: Leif Lindholm <leif@nuviainc.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Reviewed-by: Andrew Fish <afish@apple.com> 2021-12-07T17:24:28+00:00 Michael D Kinney michael.d.kinney@intel.com 2021-12-03T02:00:38+00:00 urn:sha1:2863ba97cac6c43df6b586be6aff3b382ffc2e00 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3760 Update all use of ', OPTIONAL' to ' OPTIONAL,' for function params. Cc: Andrew Fish <afish@apple.com> Cc: Leif Lindholm <leif@nuviainc.com> Cc: Michael Kubacki <michael.kubacki@microsoft.com> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> Reviewed-by: Andrew Fish <afish@apple.com> 2021-12-07T17:24:28+00:00 Michael D Kinney michael.d.kinney@intel.com 2021-11-17T03:21:14+00:00 urn:sha1:1d2482e1e362729543d8966754a216dee00924c7 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3739 Update all use of EFI_D_* defines in DEBUG() macros to DEBUG_* defines. Cc: Andrew Fish <afish@apple.com> Cc: Leif Lindholm <leif@nuviainc.com> Cc: Michael Kubacki <michael.kubacki@microsoft.com> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com> Reviewed-by: Ard Biesheuvel <ardb@kernel.org> 2021-04-15T19:24:14+00:00 Pierre Gondois Pierre.Gondois@arm.com 2021-02-09T17:32:28+00:00 urn:sha1:8948fb097419f37239ace47995ee46ab340c386e The DependencyCheck available in .pytool detects an unnecessary dependency of the NorFlashStandaloneMm.inf module over the EmbeddedPkg package. This patch removes this dependency. Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com> Tested-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>