Tianocore/edk2-platforms.git/Silicon/TexasInstruments, branch CodeCleanup

Omap35xxPkg/RealTimeClockLib: remove superfluous instance init steps

2023-10-24T13:19:17+00:00

RealTimeClockLib instances are consumed by edk2's EmbeddedPkg/RealTimeClockRuntimeDxe driver. In its entry point function InitializeRealTimeClock(), the driver: (1) calls LibRtcInitialize(), (2) sets the GetTime(), SetTime(), GetWakeupTime() and SetWakeupTime() runtime services to its own similarly-named functions -- where those functions wrap the corresponding RealTimeClockLib APIs, (3) installs EFI_REAL_TIME_CLOCK_ARCH_PROTOCOL with a NULL protocol interface. Steps (2) and (3) conform to PI v1.8 sections II-9.7.2.4 through II-9.7.2.7. However, this means that LibRtcInitialize() (of any RealTimeClockLib instance) should not itself (a) set the GetTime(), SetTime(), GetWakeupTime() and SetWakeupTime() runtime services, nor (b) install EFI_REAL_TIME_CLOCK_ARCH_PROTOCOL. The runtime service pointers will be overwritten in step (2) anyway, and step (3) will uselessly install a second (NULL-interface) EFI_REAL_TIME_CLOCK_ARCH_PROTOCOL instance in the protocol database. (The protocol only serves to notify the DXE Foundation about said runtime services being available.) Clean up Omap35xxPkg/RealTimeClockLib accordingly. (Note that the lib instance INF file already does not list UefiRuntimeServicesTableLib and gEfiRealTimeClockArchProtocolGuid.) Build-tested only (with "BeagleBoardPkg.dsc"). Cc: Ard Biesheuvel Cc: Leif Lindholm Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4565 Signed-off-by: Laszlo Ersek Message-Id: <20231020121903.44986-8-lersek@redhat.com> Acked-by: Ard Biesheuvel

Omap35xxPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent

2023-10-13T10:12:10+00:00

The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their SetVirtualAddressMap() notification functions. In particular, Omap35xxPkg/RealTimeClockLib *itself* doesn't even use LibRtcVirtualNotifyEvent() -- the function is defined with an empty body, clearly in an understandable, but misguided, attempt, to conform to the (bogus) library interface. Remove the function. Build-tested only (with "BeagleBoardPkg.dsc"). Cc: Leif Lindholm Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel

Silicon/, Platform/: Get rid of redundant toolchains flags

2023-01-17T09:23:10+00:00

The ARCHCC and ARCHASM flags are redundant, given that ARMv7-A with Thumb2 codegen has been the default for a long time, for all supported toolchains. So let's drop these definitions: this allows us to retire ARCHCC and ARCHASM entirely from EDK2. Signed-off-by: Ard Biesheuvel

Platform/ Silicon/: Drop remnants of RVCT toolchain support

2023-01-17T09:23:10+00:00

The RVCT toolchain family has been removed from EDK2 so let's get rid of the remaining references to it. This includes .asm versions of assembler source files that use a different idiom than GNU as. Signed-off-by: Ard Biesheuvel

Omap35xxPkg: InterruptDxe: add gEfiCpuArchProtocolGuid runtime dependency

2021-09-30T13:54:12+00:00

InterruptDxe requires gEfiCpuArchProtocolGuid: change the Depex line for TexasInstruments/Omap35xxPkg/InterruptDxe so the driver that provides gEfiCpuArchProtocolGuid is loaded before it. Signed-off-by: Rebecca Cran Reviewed-by: Ard Biesheuvel Reviewed-by: Leif Lindholm

Silicon/TexasInstruments: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-31T06:20:25+00:00

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for RegisterFilterLibNull which will be consumed by IoLib and BaseLib. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Dandan Bi Reviewed-by: Michael D Kinney

Platform,Silicon: fix beagleboard tautological compares

2020-11-26T16:20:24+00:00

Fix two instances of masking a single bit and testing another. Cc: Ard Biesheuvel Signed-off-by: Leif Lindholm Acked-by: Ard Biesheuvel

Omap35xxPkg/LcdGraphicsOutputDxe: add missing protocol reference

2020-05-04T13:12:36+00:00

ArmPkg's ArmLib recently dropped an unnecessary reference to gEfiCpuArchProtocolGuid, causing the build to fail for BeagleBoard, due to the fact that LcdGraphicsOutputDxe does need it, but lacks the reference, which no longer gets satisfied transitively through ArmLib. So add the reference to LcdGraphicsOutputDxe directly. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm

Silicon/TexasInstruments/Omap35xxPkg: switch to new MMC host protocol name

2020-04-30T07:46:33+00:00

The protocol name for EmbeddedPkg's version of the MMC host protocol was changed to reflect that this protocol is not the one that the UEFI spec defines. So update OMAP3's MMC host DXE driver accordingly. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm

Silicon/TexasInstruments/Omap35xxPkg: fix path references

2019-06-11T10:10:32+00:00

Fix up all the path references to Omap35xxPkg itself, which have gone stale after the move into edk2-platforms. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm