Tianocore/edk2-platforms.git/Silicon/Synopsys/DesignWare/Drivers, branch CodeCleanup

Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus

2023-07-29T07:03:42+00:00

The EFI spec (see UEFI 2.10, 24.1.12) requires EFI_SIMPLE_NETWORK's GetStatus() method to handle NULL InterruptStatus pointers by not reading nor clearing the interrupt status from the device. However, EmacGetDmaStatus (part of the DwEmacSnpDxe GetStatus() implementation) did not correctly handle NULL IrqStat, despite already being tagged as an OPTIONAL argument. This made calling GetStatus() with a NULL pointer (for example, the call in MnpRecycleTxBuf) either corrupt memory or straight-up crash. Make it EFI spec compliant, by adding proper NULL pointer checks around RI_SET_MSK and TI_SET_MSK retrieval/clearing. Signed-off-by: Yang Wang [ardb: update commit log according to Pedro's suggestion] Acked-by: Pedro Falcato Reviewed-by: Ard Biesheuvel

Silicon/Synopsys/DesignWare: Casts to avoid void* pointer arithmetic

2020-08-05T10:04:18+00:00

By default, gcc allows void* pointer arithmetic. This is a GCC extension. However, the C reference manual states that void* pointer "cannot be operands of addition or subtraction operators". Cf s5.3.1 "Generic Pointers". This patch adds casts to avoid doing void* pointer arithmetic. Signed-off-by: Pierre Gondois Reviewed-by: Leif Lindholm

Silicon/Synopsys/DesignWare: import eMMC DXE driver from EmbeddedPkg

2020-05-04T13:14:36+00:00

Incorporate the driver for the DesignWare eMMC host controller that is based on the obsolete MMC host controller protocol that is defined in EmbeddedPkg. This driver does not follow the UEFI driver model, and is only kept around for its only users, which is the HiKey platform, which is rapidly reaching obsolescence itself, at which point this driver may be removed again. To prevent inadvertent use in new platforms, add a PCD that needs to be changed from its default value in order for the driver to be functional. Signed-off-by: Ard Biesheuvel Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Leif Lindholm

Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Add DesignWare EMAC driver

2019-07-19T09:32:18+00:00

Add driver support for the Ethernet MAC based on Synopsys DesignWare 3504-0 Universal 10/100/1000 Ethernet MAC and KSZ9031 PHY Cc: Ard BieSheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Loh Tien Hock Signed-off-by: Ooi Tzy Way Reviewed-by: Leif Lindholm