Tianocore/edk2-platforms.git/Silicon/NXP/Library/Pcf8563RealTimeClockLib, branch CodeCleanup

NXP/Pcf8563RealTimeClockLib: hide LibRtcVirtualNotifyEvent

2023-10-13T10:12:01+00:00

The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their SetVirtualAddressMap() notification functions. Rename LibRtcVirtualNotifyEvent() to VirtualNotifyEvent(), and make it static, in preparation for removing the LibRtcVirtualNotifyEvent() declaration from the lib class header later. Build-tested only (with "DeveloperBox.dsc"). Cc: Leif Lindholm Cc: Masami Hiramatsu Cc: Meenakshi Aggarwal Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel

Silicon/NXP/Pcf8563RealTimeClockLib: Clear Nanosecond field in GetTime

2021-07-28T10:43:43+00:00

Clear unsupported Nanosecond field of the EFI_TIME data structure. Without this fix, date/time commands on UEFI shell fail to set because of the invaild parameter error. This is tested on the SynQuacer DeveloperBox platform which also uses 'Pcf8563' RTC chip. Signed-off-by: Masami Hiramatsu Reported-by: Kazuhiko Sakamoto

Silicon/NXP: Replace BSD License with BSD+Patent License

2019-05-17T21:22:35+00:00

https://bugzilla.tianocore.org/show_bug.cgi?id=1373 Replace BSD 2-Clause License with BSD+Patent License. This change is based on the following emails: https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html RFCs with detailed process for the license change: V3: https://lists.01.org/pipermail/edk2-devel/2019-March/038116.html V2: https://lists.01.org/pipermail/edk2-devel/2019-March/037669.html V1: https://lists.01.org/pipermail/edk2-devel/2019-March/037500.html Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney Reviewed-by: Leif Lindholm

Silicon/NXP/Pcf8563RealTimeClockLib: add Voltage-low handling

2018-06-20T10:50:31+00:00

BcdToDecimal8() in LibGetTime() asserts with the following condition. 1) RTC device has not been initialized yet, RTC device returns indeterminate value with VL bit(1) 2) DEBUG build UEFI boot fails with assertion when it satisfies above conditions. Aside from boot failure, UEFI shell commands "date/time" expect that getting time from RTC should succeed when user sets the time. ShellCommandRunTime() performs GetTime()->update time->SetTime(), if the first GetTime() fails, user can not set time. With that, simply returning EFI_DEVICE_ERROR in LibGetTime() is not applicable to VL bit handling. To avoid this situation, even if it only occurs in DEBUG build, RTC driver should check the VL bit in the VL_seconds register. This VL bit is voltage-low detector, it means integrity of the clock information is not guaranteed if it sets to 1. In this case, driver return dummy date/time(01/01/2000 00:00:00) to proceed succeeding process. linux driver also checks this bit when driver gets the time from RTC. If VL bit is 1, linux driver discard the retreived time data. Note that if VL bit is 1, GetTime() returns always 01/01/2000 00:00:00 until user sets date/time. Contributed-under: TianoCore Contribution Agreement 1.1 Co-authored-by: Yoshitoyo Osaki Signed-off-by: Masahisa Kojima Reviewed-by: Ard Biesheuvel

Silicon/NXP/Pcf8563RealTimeClockLib: avoid driver binding protocol

2018-01-25T13:08:35+00:00

Instead of registering a notification callback on the driver binding protocol, and attempting to connect our I2C master handle each time a new driver is registered, switch to the more obvious approach of registering a notification callback on the I2C master protocol directly. The original code was written under the assumption that it would make the RTC available at an earlier time, but given that all handles that are created during the execution of a driver entry point are connected by DXE core right away (i.e., before StartImage() returns), this is not really necessary, and in fact, may result in the driver already having been connected by the time we attempt to connect it. Note that it is now up to the platform to ensure that ConnectController() is called for the handle if DXE core does not call it by itself, or does call it but at a time when no I2C master protocol driver is available yet. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm

Silicon: fix typo in gPcf8563RealTimeClockLibI2cMasterProtocolGuid

2018-01-25T13:08:32+00:00

Do a global replace of gPcf8563RealTimeClockLibI2cMasterProtolGuid with gPcf8563RealTimeClockLibI2cMasterProtocolGuid. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm

Silicon/NXP: add RTC support library for PCF8563 I2C IP

2017-11-25T22:31:01+00:00

Add a RealTimeClockLib implementation for the NXP PCF8563 as used on the Socionext Developer Box board. Note that the standard I2C protocol stack does not support runtime use, so this driver invokes the I2C master protocol directly. This requires support from the platform side as well, and so this driver will only attach to a I2C master that has the gPcf8563RealTimeClockLibI2cMasterProtolGuid protocol installed on its handle. It is up to the platform to ensure that the driver producing the I2C master protocol in question is runtime capable, and is not shared with the I2C protocol stack (i.e., it should not have the I2C Bus Configuration Management protocol installed as well). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm