Tianocore/edk2-platforms.git/Silicon/Marvell, branch CodeCleanup

Platform/SbsaQemu: fix .dsc line endings

2024-06-21T11:28:46+00:00

A patch adding a mapping for ImagePropertiesRecordLib introduced a bunch of LF line endings in otherwise CRLF files, so clean that up. Cc: Ard Biesheuvel Cc: Chuong Tran Cc: Graeme Gregory Cc: Marcin Juszkiewicz Cc: Marcin Wojtas Cc: Meenakshi Aggarwal Cc: Narinder Dhillon Cc: Nhi Pham Cc: Rebecca Cran Cc: Sami Mujawar Cc: Thomas Abraham Signed-off-by: Leif Lindholm Reviewed-by: Ard Biesheuvel Reviewed-by: Marcin Juszkiewicz

Silicon/Marvell/Armada7k8k: Add ImagePropertiesRecordLib Instance

2023-12-01T08:07:32+00:00

ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Signed-off-by: Taylor Beebe Cc: Marcin Wojtas Cc: Leif Lindholm

multiple Arm platforms: set WritePolicyValid for all cache types

2023-11-22T15:12:53+00:00

acpiview complains: ERROR: On Arm based systems, all cache properties must be provided in the cache type structure. Missing 'Write Policy Valid' flag. ACPI specification says: > Set to 1 if the write policy attribute described is valid. A value > of 0 indicates that, where possible, processor architecture specific > discovery mechanisms should be used to ascertain the value of this > attribute. Signed-off-by: Marcin Juszkiewicz Reviewed-by: Leif Lindholm

Silicon/Marvell: Restructure package

2023-11-16T17:09:52+00:00

Current Marvell package structure makes it difficult to add new silicon packages that reuse common elements without creating nested DEC files. This patch creates a new MarvellSiliconPkg folder and moves the current common elements inside it. Also gMarvellTokenSpaceGuid has been renamed to gMarvellSiliconTokenSpaceGuid to align with new package name. Signed-off-by: Narinder Dhillon Reviewed-by: Leif Lindholm

Silicon/Marvell/RealTimeClockLib: remove superfluous instance init steps

2023-10-24T13:19:17+00:00

RealTimeClockLib instances are consumed by edk2's EmbeddedPkg/RealTimeClockRuntimeDxe driver. In its entry point function InitializeRealTimeClock(), the driver: (1) calls LibRtcInitialize(), (2) sets the GetTime(), SetTime(), GetWakeupTime() and SetWakeupTime() runtime services to its own similarly-named functions -- where those functions wrap the corresponding RealTimeClockLib APIs, (3) installs EFI_REAL_TIME_CLOCK_ARCH_PROTOCOL with a NULL protocol interface. Steps (2) and (3) conform to PI v1.8 sections II-9.7.2.4 through II-9.7.2.7. However, this means that LibRtcInitialize() (of any RealTimeClockLib instance) should not itself (a) set the GetTime(), SetTime(), GetWakeupTime() and SetWakeupTime() runtime services, nor (b) install EFI_REAL_TIME_CLOCK_ARCH_PROTOCOL. The runtime service pointers will be overwritten in step (2) anyway, and step (3) will uselessly install a second (NULL-interface) EFI_REAL_TIME_CLOCK_ARCH_PROTOCOL instance in the protocol database. (The protocol only serves to notify the DXE Foundation about said runtime services being available.) Clean up Silicon/Marvell/RealTimeClockLib accordingly (it only has code that's redundant for step (3); it does not try to set "gRT" fields). (Note that the lib instance INF file already does not list gEfiRealTimeClockArchProtocolGuid.) Build-tested only (with "Armada70x0Db.dsc"). Cc: Leif Lindholm Cc: Marcin Wojtas Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4565 Signed-off-by: Laszlo Ersek Message-Id: <20231020121903.44986-6-lersek@redhat.com> Acked-by: Ard Biesheuvel

Armada7k8k/RealTimeClockLib: hide LibRtcVirtualNotifyEvent

2023-10-13T10:11:57+00:00

The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their SetVirtualAddressMap() notification functions. Rename LibRtcVirtualNotifyEvent() to VirtualNotifyEvent(), and make it static, in preparation for removing the LibRtcVirtualNotifyEvent() declaration from the lib class header later. Also hoist the function definition above the reference. Build-tested only, with the following platforms: - Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc - Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc - Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc - Platform/SolidRun/Cn913xCEx7Eval/Cn913xCEx7Eval.dsc ("Platform/Marvell/Cn913xDb/Cn913xDbA.dsc" fails to build regardless: "build" complains that "Silicon/Marvell/OcteonTx/DeviceTree/T91/$(PLATFORM_NAME).inf" is missing, and as far as I can see, not even the "Silicon/Marvell/OcteonTx/DeviceTree" directory exists.) Cc: Leif Lindholm Cc: Marcin Wojtas Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel

Silicon/Marvell: Fix setting I2cStatus in MvI2cEnableConf

2023-05-10T22:36:50+00:00

Fix setting I2cStatus in MvI2cEnableConf. Signed-off-by: Rebecca Cran Reviewed-by: Marcin Wojtas

Silicon/Armada7k8k: Use MdeModulePkg's SataControllerDxe

2023-05-10T06:15:13+00:00

As part of an effort to remove OvmfPkg/SataControllerDxe, switch to the generic version in MdeModulePkg. Cc: Leif Lindholm Cc: Marcin Wojtas Signed-off-by: Pedro Falcato Acked-by: Ard Biesheuvel

Silicon/Marvell: Drop use of NONSECURE ARM memory region type

2023-02-15T18:34:24+00:00

The ARM memory region types with the NONSECURE qualification should only be used in places where this makes a difference, i.e., in the secure world. The Marvell firmware generally runs at EL2, which is non-secure only (in ARM v8.0) so the NONSECURE marking is unnecessary here, and should be dropped. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm

Marvell: Add VariableFlashInfoLib

2022-06-10T09:16:57+00:00

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 This patch adds an instance for the library class VariableFlashInfoLib that was recently introduced in MdeModulePkg. This change is made to allow the new variable driver to build that has a dependency on this library class and does not require any further platform changes. Signed-off-by: Marcin Wojtas Reviewed-by: Michael Kubacki Reviewed-by: Sunny Wang