EDK II sample platform branches and tags (mirror) https://git.radix-linux.su/Tianocore/edk2-platforms.git/atom?h=CodeCleanup 2023-11-16T17:09:52+00:00 2023-11-16T17:09:52+00:00 Narinder Dhillon ndhillon@marvell.com 2023-11-02T03:45:52+00:00 urn:sha1:ec5de71d83f3a6327c90887456782d15565e6e36 Current Marvell package structure makes it difficult to add new silicon packages that reuse common elements without creating nested DEC files. This patch creates a new MarvellSiliconPkg folder and moves the current common elements inside it. Also gMarvellTokenSpaceGuid has been renamed to gMarvellSiliconTokenSpaceGuid to align with new package name. Signed-off-by: Narinder Dhillon <ndhillon@marvell.com> Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com> 2022-04-20T08:25:36+00:00 Marcin Wojtas mw@semihalf.com 2021-12-20T03:17:50+00:00 urn:sha1:fe223fb30f748d94d73fd9183b2581c193331c72 This patch adds missing parameter's and SNP instance status checks in SnpReceive callback. Additionally, the local variables declarations are cleaned-up. Signed-off-by: Marcin Wojtas <mw@semihalf.com> Reviewed-by: Sunny Wang <sunny.wang@arm.com> 2022-04-20T08:25:32+00:00 Marcin Wojtas mw@semihalf.com 2021-12-20T03:16:12+00:00 urn:sha1:8092564d9f271cb09df2fa33bc2ac186cb4bedc5 This patch adds missing parameter's and SNP instance status checks. Signed-off-by: Marcin Wojtas <mw@semihalf.com> Reviewed-by: Sunny Wang <sunny.wang@arm.com> 2022-04-20T08:25:26+00:00 Marcin Wojtas mw@semihalf.com 2021-12-20T02:37:50+00:00 urn:sha1:19fe0f1f6b3084951fd19a7680d1cb4563b46bc4 Error checking for invalid input parameters was too hard. Replace ASSERT with returning error value. Moreover set EtherType only when we are sure it won't be dereferencing NULL pointer. Signed-off-by: Marcin Wojtas <mw@semihalf.com> Reviewed-by: Sunny Wang <sunny.wang@arm.com> 2022-04-20T08:25:22+00:00 Marcin Wojtas mw@semihalf.com 2021-12-20T01:59:35+00:00 urn:sha1:b465601d7e48b9e0935b7ad70b554e52caff6ff0 This patch adds missing parameter's and SNP instance status checks in SnpGetStatus callback. Signed-off-by: Marcin Wojtas <mw@semihalf.com> Reviewed-by: Sunny Wang <sunny.wang@arm.com> 2022-04-20T08:24:42+00:00 Marcin Wojtas mw@semihalf.com 2021-12-20T01:31:46+00:00 urn:sha1:5e1a433e86d8251a705fc56adc377fbdcad18851 The SNP MCastIpToMac callback was unsupported in Pp2Dxe driver. Implement it. Signed-off-by: Marcin Wojtas <mw@semihalf.com> Reviewed-by: Sunny Wang <sunny.wang@arm.com> 2022-04-20T08:24:36+00:00 Marcin Wojtas mw@semihalf.com 2021-12-20T01:10:26+00:00 urn:sha1:3c35ca6ec9cf2de1e719a7b70778bb70c99ee404 Add sanity check if the SNP instance pointer is not NULL in SnpStart/Stop callbacks. Signed-off-by: Marcin Wojtas <mw@semihalf.com> Reviewed-by: Sunny Wang <sunny.wang@arm.com> 2022-04-20T08:24:33+00:00 Marcin Wojtas mw@semihalf.com 2021-12-19T20:53:33+00:00 urn:sha1:7eac6e55c988d640f9617020feec0b5442fa3092 Until now the Pp2SnpReceiveFilters callback unconditionally returned EFI_SUCCESS. Allow proper handling of the input values on the protocol level. Keep the HW registers intact. Signed-off-by: Marcin Wojtas <mw@semihalf.com> Reviewed-by: Sunny Wang <sunny.wang@arm.com> 2022-04-20T08:24:16+00:00 Marcin Wojtas mw@semihalf.com 2021-12-19T19:42:43+00:00 urn:sha1:2955702e3929ea106e70d66ce3e8473e0ef01d5c The SnpShutdown callback requires updating the instance state and also disabling hardware interfaces. For that purpose reuse Pp2Halt routine. Signed-off-by: Marcin Wojtas <mw@semihalf.com> Reviewed-by: Sunny Wang <sunny.wang@arm.com> 2020-08-05T10:04:04+00:00 Pierre Gondois pierre.gondois@arm.com 2020-07-30T19:15:09+00:00 urn:sha1:dd588aa68615dbe86deed19c85230c28d86f4161 By default, gcc allows void* pointer arithmetic. This is a GCC extension. However, the C reference manual states that void* pointer "cannot be operands of addition or subtraction operators". Cf s5.3.1 "Generic Pointers". This patch adds casts to avoid doing void* pointer arithmetic. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> Reviewed-by: Leif Lindholm <leif@nuviainc.com>