Tianocore/edk2-platforms.git/Silicon/AMD/Styx, branch CodeCleanup

Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz

2024-06-21T11:31:20+00:00

PcdArmArchTimerFreqInHz is about to be removed, as it is now obsolete. Some platforms already explicitly set it to 0, which is the default. And some modules reference it in their .inf without actually ever using it. Drop these redundant uses first. Cc: Ard Biesheuvel Cc: Chuong Tran Cc: Graeme Gregory Cc: Marcin Juszkiewicz Cc: Meenakshi Aggarwal Cc: Nhi Pham Cc: Rebecca Cran Cc: Sami Mujawar Cc: Thomas Abraham Cc: Wenyi Xie Signed-off-by: Leif Lindholm Reviewed-by: Ard Biesheuvel Reviewed-by: Nhi Pham

Styx/RealTimeClockLib: hide LibRtcVirtualNotifyEvent

2023-10-13T10:11:53+00:00

The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their SetVirtualAddressMap() notification functions. Rename LibRtcVirtualNotifyEvent() to VirtualNotifyEvent(), and make it static, in preparation for removing the LibRtcVirtualNotifyEvent() declaration from the lib class header later. Also hoist the function definition above the reference. Build-tested only (with "OverdriveBoard.dsc", "CelloBoard.dsc", "Overdrive1000Board.dsc"). Cc: Leif Lindholm Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel

Silicon/AMD/Styx: Update for IORT revision macro renaming

2022-07-29T18:38:10+00:00

The IORT Specification E.d updates the IORT table revision to 5. To reflect this change the IORT header file has been updated to rename the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00. Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro in the IORT table for Styx platform to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00. Signed-off-by: Sami Mujawar Reviewed-by: Pierre Gondois Reviewed-by: Ard Biesheuvel

Silicon/AMD: Update Styx code to work with changes ARM_CORE_INFO struct

2022-01-30T10:27:13+00:00

The ARM_CORE_INFO struct has been updated so the MPIDR is now a single field instead of separate cluster/core fields. Update the Styx code in AcpiPlatformDxe, PlatInitPei and StyxDtbLoaderLib. Signed-off-by: Rebecca Cran

Silicon/Styx: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15T10:43:25+00:00

Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Daniel Schaefer Acked-by: Leif Lindholm

Platform/AMD/Styx: remove unused RP0 device

2021-01-08T15:48:25+00:00

The RP0 device has no _HID or _CID or any other identifying attribute, and its use of _ADR within the scope of the PNP0A08 device object suggests that _ADR carries a PCIe dev/fn identifier (like the EXPn device objects earlier in the file), whereas in reality, the address it carries is the MMIO address of the ECAM window. So let's just drop it. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm

Platform/AMD/Styx: implement PCIe _DSM #5 to preserve boot allocations

2021-01-08T15:48:22+00:00

Now that we have gained support for resizable BARs in EDK2, there is no longer a need for the OS to reallocate MMIO BAR resources. So let's implement _DSM #5 properly to inform the OS that boot time allocations may be preserved. While at it, clean up the implementation of _DSM, and only retain the methods that we actually need: #0 exposing the fact that #0 and #5 are the only ones implemented, and #5 as explained above. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm

Platform/AMD/Styx: simplify PCIe root bus MMIO resources

2021-01-08T15:48:20+00:00

There is no need to split up adjacent MMIO resources into separate DWordMemory() or QWordMemory() declarations, so just merge them together. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm

Silicon/AMD: update Styx to use PcdSet*S APIs

2020-11-26T16:20:19+00:00

The non-status reporting PcdSet functions were deprecated and have now been removed. Update Styx code to assert on error status. Cc: Ard Biesheuvel Signed-off-by: Leif Lindholm Acked-by: Ard Biesheuvel

Silicon/AMD/StyxSpiFvDxe: declare missing GUID dependency

2020-01-17T07:41:16+00:00

StyxSpiFvDxe depends on gEfiEventVirtualAddressChangeGuid, but got away with not declaring it in its INF because of a transitive dependency. However, this dependency got dropped in core EDK2, resulting in build failures of the Styx platform. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm