Tianocore/edk2-platforms.git/Platform/RaspberryPi, branch CodeCleanup

Platform/RaspberryPi: Check for Boot Discovery Policy change.

2024-03-12T09:55:21+00:00

This patch adds checks if Boot Discovery Policy has been changed. Only in that case EfiBootManagerRefreshAllBootOption() should be called. Signed-off-by: Grzegorz Bernacki Reviewed-by: Ard Biesheuvel

Platform/RaspberryPi: Update PCIe MMIO window for DT

2024-03-11T14:22:46+00:00

Since we are updating the DT memory map and telling it how we have configured the PCIe, there isn't a reason for moving the MMIO window. In fact this appears to fix OpenBSD+DT as well as it makes the linux XHCI reset sequence happier. Signed-off-by: Jeremy Linton Reviewed-by: Ard Biesheuvel

Platform/RaspberryPi: Give the user control over the XHCI mailbox

2024-03-11T14:18:22+00:00

It's a complete tossup whether removing the mailbox call after we have set up the XHCI works for a given kernel+distro in DT mode. So lets give users who want to try DT the option of flipping this on/off. Users that don't want to have to deal with DT, can use ACPI. Signed-off-by: Jeremy Linton Reviewed-by: Ard Biesheuvel

Platform/RaspberryPi: Cleanup menu visibility

2024-03-11T14:16:23+00:00

Lets allow some of these options to change when the system is in ACPI+DT mode. Plus the fan temp should be disabled when ACPI isn't enabled. Signed-off-by: Jeremy Linton Reviewed-by: Ard Biesheuvel

Platform/RaspberryPi: Add ImagePropertiesRecordLib Instance

2023-12-01T08:07:31+00:00

ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Signed-off-by: Taylor Beebe Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Jeremy Linton

multiple Arm platforms: set WritePolicyValid for all cache types

2023-11-22T15:12:53+00:00

acpiview complains: ERROR: On Arm based systems, all cache properties must be provided in the cache type structure. Missing 'Write Policy Valid' flag. ACPI specification says: > Set to 1 if the write policy attribute described is valid. A value > of 0 indicates that, where possible, processor architecture specific > discovery mechanisms should be used to ascertain the value of this > attribute. Signed-off-by: Marcin Juszkiewicz Reviewed-by: Leif Lindholm

Platform/RPi4: fix build

2023-03-13T12:55:36+00:00

MpServicesTest was dropped in favor of EfiMpServiceProtocolShellUnitTest. Update the dsc file accordingly. Signed-off-by: Gerd Hoffmann

Platform/RPi4: Add EFI_MP_SERVICES_PROTOCOL support

2023-02-03T12:43:19+00:00

Fix the ARM_MPCORE_INFO table and incorporate the DXE driver and test app to the build so that EFI_MP_SERVICES_PROTOCOL can be used and tested on Raspberry Pi 4. Note that the test app is not added to the image - it can be taken from the build directory and executed from the UEFI shell. Signed-off-by: Ard Biesheuvel Acked-by: Laszlo Ersek Reviewed-by: Rebecca Cran

Platform/RaspberryPi: fix pci DT node address in SyncPcie()

2022-10-10T09:14:17+00:00

To make sure the XHCI controller does not get reset by Linux in DT mode, we remove its pci parent node from the device tree. However, the pci node address has been updated in the Raspberry Pi 4 device tree [1] and no longer matches the one we are trying to remove in SyncPcie(). This results in the XHCI controller actually being reset by Linux, which leads to errors during USB initialization: [ 3.563963] xhci_hcd 0000:01:00.0: xHCI Host Controller [ 3.569538] xhci_hcd 0000:01:00.0: new USB bus registered, assigned bus number 1 [ 3.577452] xhci_hcd 0000:01:00.0: hcc params 0x002841eb hci version 0x100 quirks 0x0000040000000890 [ 3.587725] xhci_hcd 0000:01:00.0: xHCI Host Controller [ 3.593115] xhci_hcd 0000:01:00.0: new USB bus registered, assigned bus number 2 [ 3.600693] xhci_hcd 0000:01:00.0: Host supports USB 3.0 SuperSpeed [ 3.608106] hub 1-0:1.0: USB hub found [ 3.612026] hub 1-0:1.0: 1 port detected [ 3.616819] hub 2-0:1.0: USB hub found [ 3.620726] hub 2-0:1.0: 4 ports detected [ 3.875902] usb 1-1: new high-speed USB device number 2 using xhci_hcd [ 4.008123] usb 1-1: device descriptor read/64, error -71 [ 4.256088] usb 1-1: device descriptor read/64, error -71 [ 4.495882] usb 1-1: new high-speed USB device number 3 using xhci_hcd [ 4.628111] usb 1-1: device descriptor read/64, error -71 [ 4.872083] usb 1-1: device descriptor read/64, error -71 [ 5.407888] usb 1-1: new high-speed USB device number 4 using xhci_hcd [ 6.023964] xhci_hcd 0000:01:00.0: Setup ERROR: setup address command for slot 1. [ 6.239977] xhci_hcd 0000:01:00.0: Setup ERROR: setup address command for slot 1. This patch allows matching any address for the pci node, thus working with both legacy and new device trees. [1] https://lore.kernel.org/all/20210831125843.1233488-1-nsaenzju@redhat.com/ Fixes: efff29cdcdb7 ("Platform/RaspberryPi: Always use non translating DMA in DT mode") Signed-off-by: Adrien Thierry Reviewed-by: Jeremy Linton Tested-by: Jeremy Linton

RaspberryPi: Platform Build: Resolving newly introduced dependency

2022-08-16T17:53:14+00:00

The new changes in SecureBootVariableLib brought in a new dependency of PlatformPKProtectionLib. This change added the new library instance from SecurityPkg to resolve RaspberryPi platforms build. Signed-off-by: Kun Qin Reviewed-by: Jeremy Linton