Tianocore/edk2-platforms.git/Platform/RaspberryPi/Drivers/VarBlockServiceDxe, branch master

Platform/RaspberryPi: Drop platform specific EfiResetSystemLib

2024-07-30T15:41:39+00:00

Drop the now unused EfiResetSystemLib implementation, which has been superseded by the generic one from EDK2. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm

Platform/RaspberryPi: Switch to generic reset runtime

2024-07-30T15:41:36+00:00

Drop the reference to the special reset runtime DXE driver in EmbeddedPkg, and move to the one in MdeModulePkg shared between all architectures. This version implements reset notifications, allowing us to retire the home grown version of that functionality in a subsequent patch. Add depexes to the components that rely on the reset notification protocols to ensure that they are not dispatched before those protocols are made available by the reset runtime DXE driver. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm

Platform/RaspberryPi/VarBlockServiceDxe: Register for reset notification

2024-07-30T15:41:31+00:00

In addition to setting up the home grown reset notification, register with the generic EFI protocol that does the same. This event is triggered from the reset runtime implemented in MdeModulePkg, to which we will be switching the RPi platforms in a subsequent patch. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm

Platform/RaspberryPi/VarBlockServiceDxe: Refactor DumpVars event handler

2024-07-30T15:41:29+00:00

The DumpVars() routine is called directly and via an event notification callback, and the latter therefore defines the function's prototype, even though the arguments are unused. We will introduce another callback into this logic, but via a reset notifier, which has yet another prototype. So to keep things tidy, drop the formal parameters from DumpVars() and invoke it via a helper function that discards the arguments when called as a event notification callback. We will do the same for the reset notification once that functionality gets added. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm

Platform/RaspberryPi: Use depex based dispatch order for varstore

2024-07-30T15:41:24+00:00

The VarBlockServiceDxe driver needs to be dispatched before the common VariableRuntimeDxe, but we are currently relying on FDF order and lack of transitive dependencies for this, which is fragile, and will break once we move to the generic reset runtime. So use the existing helper library for this, which can be plugged into the generic variable drivers, and force them to depex on a GUID that can be installed as a NULL protocol in VarBlockServiceDxe. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm

Platform/RaspberryPi: Add system/user defined reset delay

2021-01-04T17:08:28+00:00

Due to the method in which NV variables are stored on removable media for the Raspberry Pi platform, and the manner in which we dump updated variables right before reset, it is possible, and has been repeatedly demonstrated with SSD-based USB 3.0 devices, that the updated file does not actually end up being written to permanent storage, due to the device write-cache not having enough time to be flushed before reset. To compensate for this, since we don't know of a generic method that would allow turning off USB mass storage devices write cache (and also because we are seeing an issue that seems related for SD-based media), we add a new reset delay PCD, which can be set by the user, and which we also set as required when NV variables are being dumped. Our testing show that, with more than 3 seconds of extra delay, the storage media has enough time to finalize its internal write, thus solving the issue of configuration changes not being persisted. Signed-off-by: Pete Batard Reviewed-by: Andrei Warkentin Tested-by: Samer El-Haj-Mahmoud

Platforms/RPi3: Restructure platform in preparation for Pi 4

2019-10-21T14:32:32+00:00

In preparation for adding Raspberry Pi 4 support, the Pi 3 platform is restructured by factorizing all the drivers and libraries that are going to be commonly used by the two platforms. Because much of the Pi 4 SoC is an extension of the Pi 3 one this means that almost everything, except the ACPI tables, is moved up into a new common RaspberryPi/ subdirectory that will serve both platforms. The .dec is also moved to this directory, under a new RaspberryPi.dec name, and existing references to it are updated. This commit requires the edk2-non-osi in use to contain commit 243e55f622ea in order to build. Signed-off-by: Pete Batard Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Leif Lindholm