Tianocore/edk2-platforms.git/Platform/Qemu, branch CodeCleanup

SbsaQemu: use FEAT_RNG for EFI_RNG_PROTOCOL

2024-07-04T11:40:02+00:00

By default we have Neoverse-N2 cpu which supports FEAT_RNG feature. This allows us to add RngDxe to have EFI_RNG_PROTOCOL available on Neoverse-N2 and 'max' cpu cores. Commit 5de5e230a80bed083360da95ba16a2c4a001620d (in EDK2) enabled that for ArmVirt platform. RNDR is implemented by both Neoverse-N2 and 'max' cpu implemented by QEMU. Other cpu models lack it which prevents the RngDxe driver from running, resulting in the same situation as before. TRNG is not implemented in TCG mode but is required by RngDxe to run. On older cpu cores nothing changes. Signed-off-by: Marcin Juszkiewicz Reviewed-by: Leif Lindholm

SbsaQemu: reformat all sources using uncrustify

2024-06-23T08:15:12+00:00

uncrustify is required in EDK2 repository. SbsaQemu (and other platforms in edk2-platforms) code was free from using it IIRC. Reformat all files to make new contributions easier. We can recommend formatting sources without generating extra work for developers. Signed-off-by: Marcin Juszkiewicz Reviewed-by: Leif Lindholm

Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz

2024-06-21T11:31:20+00:00

PcdArmArchTimerFreqInHz is about to be removed, as it is now obsolete. Some platforms already explicitly set it to 0, which is the default. And some modules reference it in their .inf without actually ever using it. Drop these redundant uses first. Cc: Ard Biesheuvel Cc: Chuong Tran Cc: Graeme Gregory Cc: Marcin Juszkiewicz Cc: Meenakshi Aggarwal Cc: Nhi Pham Cc: Rebecca Cran Cc: Sami Mujawar Cc: Thomas Abraham Cc: Wenyi Xie Signed-off-by: Leif Lindholm Reviewed-by: Ard Biesheuvel Reviewed-by: Nhi Pham

Platform/SbsaQemu: fix .dsc line endings

2024-06-21T11:28:46+00:00

A patch adding a mapping for ImagePropertiesRecordLib introduced a bunch of LF line endings in otherwise CRLF files, so clean that up. Cc: Ard Biesheuvel Cc: Chuong Tran Cc: Graeme Gregory Cc: Marcin Juszkiewicz Cc: Marcin Wojtas Cc: Meenakshi Aggarwal Cc: Narinder Dhillon Cc: Nhi Pham Cc: Rebecca Cran Cc: Sami Mujawar Cc: Thomas Abraham Signed-off-by: Leif Lindholm Reviewed-by: Ard Biesheuvel Reviewed-by: Marcin Juszkiewicz

QemuSbsa: enable WriteCombine for the FrameBuffer

2024-06-19T07:23:06+00:00

QEMU no longer permits misaligned access to device memory, which breaks QemuVideoDxe on SbsaQemu. c1d1910be6e04a8b1a73090cf2881fb698947a6e commit in EDK2 fixed it by enabling WriteCombine for Framebuffer memory. This change enables that fix. Signed-off-by: Marcin Juszkiewicz Reviewed-by: Ard Biesheuvel

SbsaQemu: do not set Timer interrupts

2024-04-25T11:17:05+00:00

Timer interrupts are set by ArmPkg.dec to recommended values. We do not need to repeat it (and we missed HypVirtIntrNum one). Signed-off-by: Marcin Juszkiewicz Reviewed-by: Leif Lindholm

SbsaQemu: add memory space for the high memory nodes

2024-03-28T13:15:30+00:00

To support more memory nodes, we refer to the implement of "OvmfPkg/Fdt/HighMemDxe" to add memory space for the high memory nodes except the first one. Signed-off-by: Xiong Yining Tested-by: Marcin Juszkiewicz Reviewed-by: Leif Lindholm

Platform/SbsaQemu: drop use of DeviceTree

2024-03-28T12:53:57+00:00

There is no need for EDK2 to know that there is DeviceTree around. All hardware information is read using functions from SbsaQemuHardwareInfoLib library. Signed-off-by: Marcin Juszkiewicz Signed-off-by: Xiong Yining Reviewed-by: Leif Lindholm

Platform/SbsaQemu: use SbsaQemuHardwareInfoLib for cpu information

2024-03-28T12:53:52+00:00

We have SbsaQemuHardwareInfoLib to ask for hardware details. No need to parse DeviceTree anymore. Signed-off-by: Marcin Juszkiewicz Signed-off-by: Xiong Yining Reviewed-by: Leif Lindholm

Platform/SbsaQemu: add SbsaQemuHardwareInfoLib

2024-03-28T12:53:47+00:00

This library provides functions to check for hardware information. For now it covers CPU ones: - amount of cpu cores - MPIDR value for cpu core - NUMA node id for cpu core Values are read from TF-A using platform specific SMC calls. Signed-off-by: Marcin Juszkiewicz Signed-off-by: Xiong Yining Reviewed-by: Leif Lindholm