Tianocore/edk2-platforms.git/Platform/Intel/SimicsOpenBoardPkg, branch CodeCleanup

Platform/Intel: Set PcdAcpiBaseAddress for PEI MM Communication

2024-07-07T07:41:18+00:00

Set PcdAcpiBaseAddress to 0x400 for PEI MM communication. Signed-off-by: Wei6 Xu Co-authored-by: Jiaxin Wu

Platform/Intel: Install an SMM Control PPI

2024-07-07T07:41:18+00:00

Install an instance of EFI_PEI_MM_CONTROL_PPI. This PPI provides a standard way for other modules to trigger software SMIs. Signed-off-by: Ray Ni Co-authored-by: Jiaxin Wu

Platform/Intel: Consume SmmRelocationInit interface

2024-07-05T14:28:32+00:00

Do the smm relocation during platform init. Signed-off-by: Jiaxin Wu

Platform/Intel: Enable the PcdSmrrEnable

2024-06-28T05:30:54+00:00

This patch is to enable the PcdSmrrEnable since the simics report it has the capability to enable the smrr. Signed-off-by: Jiaxin Wu

Platform/Intel: Add AmdSvsmLib to required DSC files

2024-04-17T18:35:04+00:00

Any DSC file that uses the UefiCpuPkg MpInitLib library now requires the AmdSvsmLib library. Update the DSC files to include the AmdSvsmLib NULL library implementation. Cc: Leif Lindholm Cc: Michael D Kinney Cc: Sai Chaganty Cc: Nate DeSimone Cc: Chasel Chiu Cc: Kelly Steele Cc: Zailiang Sun Signed-off-by: Tom Lendacky

SimicsOpenBoardPkg: auto-gen & fix SEC ProcessLibraryConstructorList() decl

2024-03-08T08:44:35+00:00

declares a bogus ProcessLibraryConstructorList() for SimicsOpenBoardPkg's SEC module. Rely on AutoGen for (properly) declaring ProcessLibraryConstructorList(). Update the call. Build-tested with: - appending the following directories to PACKAGES_PATH: Drivers Features/Intel Features/Intel/Debugging Features/Intel/Network Features/Intel/OutOfBandManagement Features/Intel/PowerManagement Features/Intel/SystemInformation Features/Intel/UserInterface Platform/Intel Silicon/Intel - commenting out "SimicsIch10BinPkg/UndiBinary/UndiDxe.inf" in "Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc" and "Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf" - running the command build -a IA32 -a X64 -b DEBUG \ -m Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf \ -p Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc \ -t GCC5 Cc: Nate DeSimone Cc: Sai Chaganty Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 Signed-off-by: Laszlo Ersek Message-Id: <20240305120126.70259-3-lersek@redhat.com> Reviewed-by: Michael D Kinney

SimicsOpenBoardPkg: Set PcdDxeIplSwitchToLongMode to FALSE

2023-07-28T03:33:46+00:00

Set PcdDxeIplSwitchToLongMode to FALSE if the execution mode is not IA32 PEI + X64 DXE. Signed-off-by: Dun Tan Reviewed-by: Ray Ni Cc: Nate DeSimone Cc: Zhiguang Liu

SimicsOpenBoard: Use default 10ms as delay between INIT and SIPI

2023-06-05T04:56:03+00:00

Today the delay is 10us but the QSP simulates the multiprocessor by dividing time into segments and serializing processors within a segment. The length of the segment is configurable and Simics open board is configured using 100us. But the firmware configures the delay between INIT and SIPI is 10us. That results a possible senarino that BSP sends a INIT and SIPI in one segment (100us) while APs are still in SMM environment. The INIT is queued but SIPI is ignored by Simics, resulting all APs being put in wait-for-SIPI state when they receive INIT. Signed-off-by: Ray Ni Cc: Nate DeSimone Reviewed-by: Zhiguang Liu

SimicsOpenBoardPkg: Disable DriverBindingSupport perf logging

2023-05-30T08:35:38+00:00

DriverBindingSupport() is called lots of time during post. If it's also included in the perf logging, it's very easy to use all the FPDT table memory pre-allocated at EndOfDxe because the driver binding connect process happens after EndOfDxe. PcdExtFpdtBootRecordPadSize was added for holding the perf-logging records after EndOfDxe. But the DriverBindingSupport records are just too many. For example, SimicsOpenBoardPkg has to set this PCD to almost 100x bigger than the default value in order to hold all the perf-logging records. Platform developers are usually not aware of missing some records after EndOfDxe because those records are all about driverbinding support/start/stop. But if we add more perf-logging inside SMM, those SMM records will be missed in the final FPDT table because DxeCorePerformanceLib collects those SMM records at ReadyToBoot event. Since the FPDT cannot hold all driverbinding records, it definitely cannot hold those SMM records as well. So in order to hold all SMM perf loggings, either platform should set PcdExtFpdtBootRecordPadSize to a large enough value, or as what this patch does, to disable the driverbinding support perf-logging. Signed-off-by: Ray Ni Cc: Nate DeSimone Reviewed-by: Zhiguang Liu Cc: Michael D Kinney

SimicsOpenBoardPkg: Add "dp" command in performance build

2023-05-30T08:35:38+00:00

Signed-off-by: Ray Ni Cc: Nate DeSimone Reviewed-by: Zhiguang Liu Cc: Michael D Kinney