Tianocore/edk2-platforms.git/Platform/Hisilicon/D03/Library, branch CodeCleanup

Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz

2024-06-21T11:31:20+00:00

PcdArmArchTimerFreqInHz is about to be removed, as it is now obsolete. Some platforms already explicitly set it to 0, which is the default. And some modules reference it in their .inf without actually ever using it. Drop these redundant uses first. Cc: Ard Biesheuvel Cc: Chuong Tran Cc: Graeme Gregory Cc: Marcin Juszkiewicz Cc: Meenakshi Aggarwal Cc: Nhi Pham Cc: Rebecca Cran Cc: Sami Mujawar Cc: Thomas Abraham Cc: Wenyi Xie Signed-off-by: Leif Lindholm Reviewed-by: Ard Biesheuvel Reviewed-by: Nhi Pham

Hisilicon/DS3231RealTimeClockLib: remove superfluous instance init steps

2023-10-24T13:17:57+00:00

RealTimeClockLib instances are consumed by edk2's EmbeddedPkg/RealTimeClockRuntimeDxe driver. In its entry point function InitializeRealTimeClock(), the driver: (1) calls LibRtcInitialize(), (2) sets the GetTime(), SetTime(), GetWakeupTime() and SetWakeupTime() runtime services to its own similarly-named functions -- where those functions wrap the corresponding RealTimeClockLib APIs, (3) installs EFI_REAL_TIME_CLOCK_ARCH_PROTOCOL with a NULL protocol interface. Steps (2) and (3) conform to PI v1.8 sections II-9.7.2.4 through II-9.7.2.7. However, this means that LibRtcInitialize() (of any RealTimeClockLib instance) should not itself (a) set the GetTime(), SetTime(), GetWakeupTime() and SetWakeupTime() runtime services, nor (b) install EFI_REAL_TIME_CLOCK_ARCH_PROTOCOL. The runtime service pointers will be overwritten in step (2) anyway, and step (3) will uselessly install a second (NULL-interface) EFI_REAL_TIME_CLOCK_ARCH_PROTOCOL instance in the protocol database. (The protocol only serves to notify the DXE Foundation about said runtime services being available.) Clean up Hisilicon/DS3231RealTimeClockLib accordingly. (Note that the lib instance INF file already does not list UefiBootServicesTableLib, UefiRuntimeServicesTableLib, and gEfiRealTimeClockArchProtocolGuid.) Build-tested only (with the D03 and D05 platforms). Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Wenyi Xie Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4565 Signed-off-by: Laszlo Ersek Message-Id: <20231020121903.44986-2-lersek@redhat.com> Acked-by: Ard Biesheuvel

Hisilicon/DS3231RealTimeClockLib: drop LibRtcVirtualNotifyEvent

2023-10-13T10:11:29+00:00

The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their SetVirtualAddressMap() notification functions. In particular, DS3231RealTimeClockLib *itself* doesn't even use LibRtcVirtualNotifyEvent() -- the function is defined with an empty body, clearly in an understandable, but misguided, attempt, to conform to the (bogus) library interface. Remove the function. Build-tested only (with the Hisilicon platforms). Cc: Leif Lindholm Cc: Wenyi Xie Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel

Hisilicon: rename OemMiscLib class to HisiOemMiscLib

2023-10-13T10:11:01+00:00

Edk2 commit [1] introduced the library class header to ArmPkg; commit [2] introduced the first OemMiscLib instance to ArmPkg; and commit [3] introduced (retroactively) the library class itself to ArmPkg. Alas, when all these edk2 commits were made, edk2-platforms already had a (Hisilicon-specific) library class called OemMiscLib -- and many of the Hisilicon modules would use both "HisiPkg.dec" and "ArmPkg.dec". Therefore the edk2 OemMiscLib brought about a library class conflict, breaking both edk2-platforms and edk2-non-osi content. Rename the original OemMiscLib class to HisiOemMiscLib, and update all references. This patch is necessary for building the D03, D05, D06, HiKey, and HiKey960 platforms. [1] 2c7c64fc04a0 ("ArmPkg: Add Library/OemMiscLib.h", 2021-02-08) [2] 0e51d7e445e0 ("ArmPkg: Add Universal/Smbios/OemMiscLibNull", 2021-02-08) [3] d03f71dd8be6 ("ArmPkg: Add missing library headers to ArmPkg.dec", 2021-04-28) Cc: Leif Lindholm Cc: Wenyi Xie Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel

Hisilicon: Convert UNI files from UTF-16 to UTF-8

2019-10-03T22:04:07+00:00

https://bugzilla.tianocore.org/show_bug.cgi?id=2199 Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Michael D Kinney Acked-by: Ard Biesheuvel

Platform/Hisilicon: Replace BSD License with BSD+Patent License

2019-05-17T21:21:35+00:00

https://bugzilla.tianocore.org/show_bug.cgi?id=1373 Replace BSD 2-Clause License with BSD+Patent License. This change is based on the following emails: https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html RFCs with detailed process for the license change: V3: https://lists.01.org/pipermail/edk2-devel/2019-March/038116.html V2: https://lists.01.org/pipermail/edk2-devel/2019-March/037669.html V1: https://lists.01.org/pipermail/edk2-devel/2019-March/037500.html NOTE: The following files with a missing license are not modified by this patch series. These files will be address in a future patch. Silicon/Hisilicon/Hi1610/Hi1610AcpiTables/D03Iort.asl Silicon/Hisilicon/Hi1616/D05AcpiTables/D05Iort.asl Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Iort.asl Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620IortNoSmmu.asl Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney Reviewed-by: Leif Lindholm

Hisilicon/D0x: Rename StartupAp() function

2019-03-21T18:01:16+00:00

As suggestion of community, 'AP' is a bit unfortunate to use in EDK2 context. PI specifies 'BSP' for Boot-strap Processor, as the one executing all of the EDK2 code. It then uses 'AP' to refer to Additional Processors, which can be assigned tasks using the EFI_MP_SERVICES_PROTOCOL. In a TianoCore context, this should be 'BSP'. So, Rename StartupAp() to StartUpBSP. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm

Hisilicon/D0x: Delete some header files

2019-03-21T17:51:07+00:00

As some interfaces exposed only by implementations in edk2-non-osi, so delete corresponding header files and modify code to make build. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm

Hisilicon/D0x: Remove and tidy some codes about SerdesLib

2019-03-21T17:51:00+00:00

As some definitions are about OemMiscLib, so move them from SerdesLib.h to OemMiscLib.h and drop some useless function definitions. After doing this, some unnecessary references can be removed for D03/D05. SerdesLib is useless for SmbiosMiscDxe and D06, so remove it and delete SerdesLib.h for D06. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm

Hisilicon/D0x: Update SMBIOS type9 info

2018-09-03T15:21:10+00:00

Move board level code to OemMiscLibD0x for unifying D0x. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm