Tianocore/edk2-platforms.git/Platform/ARM/VExpressPkg/ConfigurationManager, branch CodeCleanup

Platform/ARM: FVP: Add ETE device if supported by FVP

2023-10-30T11:18:42+00:00

When ETE is enabled in the FVP model the firmware can check the debug feature register ID_AA64DFR0_EL1.TraceVer field to identify the presence of FEAT_ETE and add an ETE device to the CPU node in the AML CPU hierarchy. This enables the Operating System driver to probe and enable ETE support. Note: To enable ETE support in the FVP REvC model 1. Build TF-A with the CTX_INCLUDE_AARCH32_REGS=0 build flag set, otherwise this results in an exception when booting TF-A 2. Set the model parameters to enable TRBE as this is required for ETE -C cluster0.has_trbe=1 -C cluster1.has_trbe=1 3. Set the ETE plugin for the model --plugin \libete-plugin.[so|dll] Signed-off-by: Sami Mujawar Reviewed-by: Pierre Gondois

Platform/ARM: FVP: Specify TRBE interrupt in MADT GICC

2023-10-30T11:18:42+00:00

When TRBE is enabled the FVP model uses the PPI 15 (i.e. INT ID 31) as the TRBE interrupt. Ref: https://www.kernel.org/doc/Documentation/ devicetree/bindings/arm/arm,trace-buffer-extension.yaml Therefore, check the debug feature register ID_AA64DFR0_EL1.TraceBuffer field to see if TRBE is enabled and configure the TRBE interrupt in the GICC structure in the MADT ACPI table. Note: To enable TRBE support in the FVP REvC model 1. Build TF-A with the CTX_INCLUDE_AARCH32_REGS=0 build flag set, otherwise this results in an exception when booting TF-A. 2. Set the model parameters to enable TRBE -C cluster0.has_trbe=1 -C cluster1.has_trbe=1 Signed-off-by: Sami Mujawar Reviewed-by: Pierre Gondois

Platform/ARM: Add dynamic CPU node generation for FVP

2023-10-30T11:18:42+00:00

Add support to dynamically generate the CPU nodes in SSDT. Signed-off-by: Sami Mujawar Reviewed-by: Pierre Gondois

Platform/ARM: Bump Dsdt/Ssdt ACPI table revision

2022-11-01T12:06:02+00:00

From ACPI 5.1, s19.5.28 DefinitionBlock (Declare Definition Block): Note: For compatibility with ACPI versions before ACPI 2.0, the bit width of Integer objects is dependent on the ComplianceRevision of the DSDT. If the ComplianceRevision is less than 2, all integers are restricted to 32 bits. Otherwise, full 64-bit integers are used. The version of the DSDT sets the global integer width for all integers, including integers in SSDTs. To be up-to-date with the latest table revision, bump the version of all dsdt/ssdt tables that are relying on an ACPI specification version above 2.0. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar

Platform/ARM: FVP: Update for IORT revision macro renaming

2022-07-29T18:37:52+00:00

The IORT Specification E.d updates the IORT table revision to 5. To reflect this change the IORT header file has been updated to rename the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00. Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro in the Configuration Manager for FVP platform to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00. Signed-off-by: Sami Mujawar Reviewed-by: Pierre Gondois

Platform/ARM: FVP: set IORT RC address limit for FVP RevC

2022-04-29T13:31:55+00:00

When booting Linux on FVP RevC, Linux reports the following error: ACPI: IORT: [Firmware Bug]: Root complex missing memory address limit This issue is due to the RC Address Limit not being configured in the configuration manager for the platform. Set the value to 64 as the RevC FVP can use the full width, fixing the error. Signed-off-by: Edward Pickup Reviewed-by: Ard Biesheuvel

Platform/ARM: FVP: Fix variable usage in GetArmNameSpaceObject()

2021-07-13T17:03:13+00:00

Building with Clang showed that `RootComplexCount` and `DeviceIdMappingArrayCount` were unused. Use the variables where they were intended to be used. Signed-off-by: Joey Gouly Reviewed-by: Sami Mujawar

Platform/ARM/VExpressPkg: Remove non-ASCII characters

2021-02-17T16:36:46+00:00

The patch at "4be8625ab1b008057ae9a500aa8978be2a02d6e2 Platform/ARM/VExpressPkg: Add support for FVP RevC model" introduced a new file SsdtPci.asl. The file SsdtPci.asl had a few non-ASCII characters in the code comments. These resulted in the Trim utility generating a warning that caused the firmware build to fail on a Linux development PC. Therefore, remove the non-ASCII characters as it results in builds failures on a Linux development PC. Note: This issue was not observed on a Windows development PC. Signed-off-by: Sami Mujawar Reviewed-by: Thomas Abraham

Platform/ARM/VExpressPkg: Add Virtio Block Device description

2021-02-13T10:24:23+00:00

The FVP model implements a Virtio block device that can be accessed from a Guest OS if it has an appropriate driver. It is targeted primarily at Linux, which has a built-in Virtio block driver. VirtioBlockDevice allows to use a file on the host that is specified using the models image_path parameter, as a hard drive in the Guest OS. Therefore, add the Virtio block device description to the DSDT. Signed-off-by: Sami Mujawar Reviewed-by: Ard Biesheuvel

Platform/ARM/VExpressPkg: Add SMC91x device description

2021-02-13T10:24:20+00:00

The FVP model implements a SMSC 91C111 ethernet controller that can be configured for network access. Therefore, add description for a SMSC 91C111 device in the DSDT. Signed-off-by: Sami Mujawar Reviewed-by: Ard Biesheuvel