EDK II sample platform branches and tags (mirror) https://git.radix-linux.su/Tianocore/edk2-platforms.git/atom?h=CodeCleanup 2024-05-29T15:45:55+00:00 2024-05-29T15:45:55+00:00 sahil sahil@arm.com 2024-05-29T08:55:12+00:00 urn:sha1:ed8969bc7bbff30c3b9d725789cbba997721e25e This patch adds an optional functionality in NorFlashDxe to fetch and print NOR Flash information from NorFlashInfoLib using its JEDEC ID. NOR Flash libraries will implement a function "NorFlashReadID" which will fetch and return JEDEC ID. This JEDEC ID can be then printed along with the NOR Flash info by NorFlashInfoLib. If this functionality is not needed then the function can just return EFI_UNSUPPORTED. Signed-off-by: sahil <sahil@arm.com> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com> Reviewed-by: levi.yun <yeoreum.yun@arm.com> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com> 2024-05-29T15:45:55+00:00 sahil sahil@arm.com 2024-05-29T08:55:11+00:00 urn:sha1:c3a505d0c3d4c9bcc8c9266e0ee6ae8c21744b15 This patch adds error_handler1 and error_handler2 labels in NorFlashCreateInstance() function to handle the cleanup. error_handler1: Frees just the Instance structure as the ShadowBuffer is not allocated yet. error_handler2: Frees both Instance and Instance->ShadowBuffer. Signed-off-by: sahil <sahil@arm.com> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com> 2024-05-29T15:45:54+00:00 sahil sahil@arm.com 2024-05-29T08:55:10+00:00 urn:sha1:d87cd6dda5cc3295a26c4c465ccf0c976ce38b62 This variable holds the QSPI controller's base address. It is defined in ARM.dec as well with the default value of 0x0. In case a platform is not using it, they can just ignore this variable and the default value of 0x0 will be propogated and the variable will not be used. Signed-off-by: sahil <sahil@arm.com> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com> Reviewed-by: levi.yun <yeoreum.yun@arm.com> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com> 2024-05-29T15:45:54+00:00 sahil sahil@arm.com 2024-05-29T08:55:09+00:00 urn:sha1:44c4c207aeaa9f315ce7cf14fbd0cdbacd2dfdc4 NorFlashDeviceLib can be used to provide implementations of different NOR Flash to NorFlashDxe, i.e. NorFlashDxe links with NorFlashDeviceLib and the platforms can specify their respective NorFlashDeviceLib instances. This patch adds the following major changes: 1. Adds changes in NorFlashDxe to look for NorFlashDeviceLib instead of NorFlash.c for flash specific implementation 2. Remove NorFlash.c and NorFlash.h as they are no longer required. 3. Add changes to platform description files to provide P30NorFlashDeviceLib as NorFlashDeviceLib Signed-off-by: sahil <sahil@arm.com> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com> Reviewed-by: levi.yun <yeoreum.yun@arm.com> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com> 2024-05-29T15:45:41+00:00 sahil sahil@arm.com 2024-05-29T08:55:07+00:00 urn:sha1:e85e06c24e2f940e4117a4fef3daa9d58824a031 NorFlashDeviceLib can be used to provide implementations of different NOR Flash to NorFlashDxe, i.e. NorFlashDxe links with NorFlashDeviceLib and the platforms can specify their respective NorFlashDeviceLib instances. This patch splits NorFlash.h and moves out the function prototypes and macros that are expected by NorFlashDxe to be implemented by any Nor Flash implementation to NorFlashDeviceLib.h file. Signed-off-by: sahil <sahil@arm.com> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com> Reviewed-by: levi.yun <yeoreum.yun@arm.com> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com> 2024-05-29T12:59:37+00:00 sahil sahil@arm.com 2024-05-29T08:55:06+00:00 urn:sha1:b1c0f5def444e711087fdda80b99f05b6c30e130 This patch makes local functions not being used outside NorFlash.c STATIC. Also, NorFlashWriteBuffer() is specific to a particular flash implementation and need not be implemented by other NOR flash device IPs. Signed-off-by: sahil <sahil@arm.com> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com> 2024-05-29T12:59:26+00:00 sahil sahil@arm.com 2024-05-29T08:55:05+00:00 urn:sha1:8bd26399f3e0330f4d7e18c009b586b5aa0c534e This patch removes NorFlashReadCfiData() and NorFlashWrite() prototypes from NorFlash.h as these are not implemented or used anywhere in NorFlashDxe driver. Signed-off-by: sahil <sahil@arm.com> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com> 2024-05-29T12:59:18+00:00 sahil sahil@arm.com 2024-05-29T08:55:04+00:00 urn:sha1:9ce62ba79ddfc4bc2d4330723acd7160e621e8bb Refactoring done in this patch has two major parts: 1. Moving out NorFlashUnlockAndEraseSingleBlock and NorFlashWriteFullBlock functions from NorFlashDxe.c and NorFlashStandaloneMm.c to NorFlash.c files. 2. At the same time, we are adding NorFlashLock and NorFlashUnlock functions which will take care of TPL related operations needed by functions mentioned in point 1. These functions are implemented in NorFlashDxe.c but are just dummy placeholder functions in NorFlashStandaloneMm.c file. Signed-off-by: sahil <sahil@arm.com> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com> Reviewed-by: levi.yun <yeoreum.yun@arm.com> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com> 2024-05-29T12:59:08+00:00 sahil sahil@arm.com 2024-05-29T08:55:03+00:00 urn:sha1:d4a6ba2977203ff0d7489aff2157bb2ef7eec1a0 This patch splits NorFlash.h and adds NorFlashCommon.h which will have all the flash independent functions and macros. Whereas all the flash specific functions will be in NorFlash.h header file. Signed-off-by: sahil <sahil@arm.com> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com> Reviewed-by: levi.yun <yeoreum.yun@arm.com> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com> 2024-05-29T12:59:00+00:00 sahil sahil@arm.com 2024-05-29T08:55:02+00:00 urn:sha1:0e59ef1589442db8d3ff68bbe77f15f6716ca17a Moving this function from NorFlash.c to NorFlashDxe.c as it is not dependent on any particular flash implementation. Signed-off-by: sahil <sahil@arm.com> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com> Reviewed-by: levi.yun <yeoreum.yun@arm.com> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>