Tianocore/edk2-platforms.git/Features/ManageabilityPkg/Library, branch CodeCleanup

ManageabilityPkg: Add TransportLib instance for IPMI SSIF

2024-05-29T10:13:46+00:00

This adds ManageabilityTransportSsifLib instance following the manageability transport framework to support IPMI SSIF protocol. Signed-off-by: Nhi Pham

ManageabilityPkg: Add NULL PlatformBmcReadyLib instance

2024-05-29T10:13:46+00:00

The NULL library is used when there is no platform specific implementation of PlatformBmcReadyLib. In that case, the state of BMC is always ready. Signed-off-by: Nhi Pham

ManageabilityPkg: Uncrustify on C source files

2023-10-30T07:40:58+00:00

Run Uncrustify on the C source files those were modified in commit ID from 3f4c4384 to 28ff8f29. Signed-off-by: Abner Chang Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Konstantin Aladyshev Acked-by: Laszlo Ersek Reviewed-by: Nickle Wang

ManageabilityPkg/Ipmi: IPMI Get System Interface Capabilities Command

2023-10-27T01:29:29+00:00

Implment AppFn, 0x57 command. Signed-off-by: Abner Chang Cc: Abdul Lateef Attar Cc: Nickle Wang Reviewed-by: Abdul Lateef Attar

PldmProtocolDxe: Correct TID argument usage

2023-10-26T04:54:53+00:00

Currently the PLDM source/destination TID arguments for the PldmSubmit function are not actually used in any way in the underlying MCTP communication. The code just uses MCTP source/destination EID PCDs. So we have to restructure code to actually use provided PLDM TIDs. On the other case the PldmSubmitCommand function from the PldmProtocolLib doesn't even accept the source/destination TID arguments. To address both these facts correct TID argument usage in the following way: - by default the TID values are taken from the built-time PCDs, - user have an ability to provide custom TIDs either via PldmSubmit function arguments or by calling PldmSetTerminus API. Signed-off-by: Abner Chang Signed-off-by: Konstantin Aladyshev Reviewed-by: Abner Chang

ManageabilityPkg: Update the algorithm of using MCTP endpoint ID PCD

2023-10-26T04:53:30+00:00

Although MtcpSubmit function receives source and destination MCTP EID arguments these value are not used in any way currently. Instead the code always uses EID values from the PCDs. To correct this issue modify function interface to receive source and destination MCTP EIDs via pointers and use PCD values only if the pointers are NULL. Signed-off-by: Konstantin Aladyshev Signed-off-by: Abner Chang Reviewed-by: Abner Chang

ManageabilityPkg: Support both MCTP and IPMI in KCS tranport library

2023-10-26T04:52:49+00:00

The Manageability KCS transport library needs to support requests both from MCTP and IPMI transports. Currently the code only handles IPMI case correctly. In the MCTP case the communication should be based on the MCTP-over-KCS specification (DSP0254). This specification defines a special KCS binding header and trailer structures that need to be present in every MCTP message. The header structure contains a length field, therefore response packet size is not needed to be known beforehand. The trailer structure contains a PEC checksum that can be used to check itegrity of the response message. Modify Manageability KCS transport library code to check which message is processed (IPMI or MCTP) and handle each case correctly based on its own specification. Tested: - The IPMI KCS communication is tested by Abner Chang, - The MCTP KCS communication is tested by Konstantin Aladyshev on the AMD EthanolX CRB. Signed-off-by: Konstantin Aladyshev Signed-off-by: Abner Chang Reviewed-by: Abner Chang

ManageabilityPkg: Ipmi Get/Set Boot Options

2023-07-12T02:20:09+00:00

BZ #: 4455. Support parameter selectors for IPMI Get/Set boot options. The size of the response data is now dependent on the parameter selector, rather than being fixed. Cc: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Signed-off-by: Brit Chesley Reviewed-by: Abner Chang Reviewed-by: Isaac Oram

ManageabilityPkg: Use DEBUG_MANAGEABILITY

2023-05-31T08:05:46+00:00

Use debug print level DEBUG_MANAGEABILITY in ManageabilityPkg. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Tinh Nguyen Reviewed-by: Nickle Wang Reviewed-by: Abdul Lateef Attar

ManageabilityPkg: Replace FUNCTION with func