Tianocore/edk2-platforms.git/Features/ManageabilityPkg/Include, branch CodeCleanupEDK II sample platform branches and tags (mirror)https://git.radix-linux.su/Tianocore/edk2-platforms.git/atom?h=CodeCleanup2024-07-19T09:23:05+00:00ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol2024-07-19T09:23:05+00:00Nickle Wangnicklew@nvidia.com2023-04-11T13:47:19+00:00urn:sha1:a9422dade55d4eb40329048d254d5ba4feb7db57
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4773
This change implements the blob transfer protocol used in OpenBmc
documented here: https://github.com/openbmc/phosphor-ipmi-blobs
Signed-off-by: Nick Ramirez <nramirez@nvidia.com>
Co-authored-by: Nickle Wang <nicklew@nvidia.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
Cc: Tinh Nguyen <tinhnguyen@amperemail.onmicrosoft.com>
Cc: Nhi Pham <nhi@os.amperecomputing.com>
Cc: Thang Nguyen OS <thang@amperemail.onmicrosoft.com>
Cc: Mike Maslenkin <mike.maslenkin@gmail.com>
ManageabilityPkg: Add PlatformBmcReadyLib library header2024-05-29T10:13:46+00:00Nhi Phamnhi@os.amperecomputing.com2024-05-24T07:39:37+00:00urn:sha1:290037aceac8628d4a26f6d0682a26289aac3146
The PlatformBmcReadyLib provides platform specific implementation to
check the BMC state.
Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
ManageabilityPkg/IpmiProtocol: Extend support for SSIF transport2024-05-29T10:13:46+00:00Nhi Phamnhi@os.amperecomputing.com2024-05-24T07:25:30+00:00urn:sha1:6d545464d0e33ec688e8b7fa702d17f5069926f9
This extends support for SMBUS System Interface (SSIF) transport based
on the IPMI specification.
Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
ManageabilityPkg: Add useful defines for IPMI LUN and NetFn2024-05-29T10:13:46+00:00Nhi Phamnhi@os.amperecomputing.com2024-05-24T07:11:10+00:00urn:sha1:e38a4b31c9cd56b8677154452abda627e68bc5d3
This adds useful defines for IPMI BMC Logical Unit Number (LUN) and the
maximum value of Net Function (NetFn) to use across transport modules.
According to the IPMI specification, unless otherwise specified,
commands are listed as mandatory must be accessed through LUN 00b.
Hence, this patch defaults LUN 00b for all IPMI BMC commands.
Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
ManageabilityPkg: Uncrustify on C source files2023-10-30T07:40:58+00:00Abner Changabner.chang@amd.com2023-10-26T07:58:37+00:00urn:sha1:dc8de7cc888fa883deeb59466c34046c1c08a203
Run Uncrustify on the C source files those were
modified in commit ID from 3f4c4384 to 28ff8f29.
Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Konstantin Aladyshev <aladyshev22@gmail.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Nickle Wang <nicklew@nvidia.com>
ManageabilityPkg/Ipmi: Remove IpmiCommandLib.h from ManageabilityPkg2023-10-28T02:35:28+00:00Abner Changabner.chang@amd.com2023-10-05T13:45:20+00:00urn:sha1:ada70acdd7c06acb3f7ccbbbc7c48ac5874eaf1e
Remove duplicate IpmiCommandLib.h and use the one
under MdeModulePKg instead.
Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Reviewed-by: Nickle Wang <nicklew@nvidia.com>
PldmSmbiosTransferDxe: Implement Set PLDM terminus ID API2023-10-26T04:55:34+00:00Abner Changabner.chang@amd.com2023-10-16T13:56:22+00:00urn:sha1:26011742a01a3d5241634ee10116779f3f654299
Currently all PLDM functions inside the PLDM_SMBIOS_TRANSFER_PROTOCOL
use PLDM terminus PCDs for the MCTP addressing.
Add additional function to the protocol API to provide user a way to
use custom TIDs.
Signed-off-by: Abner Chang <abner.chang@amd.com>
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Reviewed-by: Abner Chang <abner.chang@amd.com>
PldmProtocolDxe: Correct TID argument usage2023-10-26T04:54:53+00:00Abner Changabner.chang@amd.com2023-10-16T13:55:37+00:00urn:sha1:f4ae5d78c3b36aadf8fe36a08878e72a6655e30f
Currently the PLDM source/destination TID arguments for the PldmSubmit
function are not actually used in any way in the underlying MCTP
communication. The code just uses MCTP source/destination EID PCDs. So
we have to restructure code to actually use provided PLDM TIDs.
On the other case the PldmSubmitCommand function from the
PldmProtocolLib doesn't even accept the source/destination TID
arguments.
To address both these facts correct TID argument usage in the following
way:
- by default the TID values are taken from the built-time PCDs,
- user have an ability to provide custom TIDs either via PldmSubmit
function arguments or by calling PldmSetTerminus API.
Signed-off-by: Abner Chang <abner.chang@amd.com>
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Reviewed-by: Abner Chang <abner.chang@amd.com>
ManageabilityPkg: Correct value for the MCTP TAG_OWNER response bit2023-10-26T04:53:45+00:00Konstantin Aladyshevaladyshev22@gmail.com2023-10-05T14:44:59+00:00urn:sha1:82943790727ba92daa564a34ea495b9f160c9164
Currently the MCTP TAG_OWNER bit is checked against 1 both in MTCP
request and response.
According to the MTCP Base specification in case of the MCTP response
the TAG_OWNER bit should be equal to 0.
Correct MCTP_MESSAGE_TAG_OWNER_RESPONSE flag value to fix the issue.
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Reviewed-by: Abner Chang <abner.chang@amd.com>
ManageabilityPkg: Update the algorithm of using MCTP endpoint ID PCD2023-10-26T04:53:30+00:00Konstantin Aladyshevaladyshev22@gmail.com2023-10-05T11:19:24+00:00urn:sha1:3b36a9f08f1c50507f14ab58e27cd9506175e552
Although MtcpSubmit function receives source and destination MCTP EID
arguments these value are not used in any way currently. Instead the
code always uses EID values from the PCDs.
To correct this issue modify function interface to receive source and
destination MCTP EIDs via pointers and use PCD values only if the
pointers are NULL.
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Signed-off-by: Abner Chang <abner.chang@amd.com>
Reviewed-by: Abner Chang <abner.chang@amd.com>