Tianocore/edk2-platforms.git/Features/Ext4Pkg, branch CodeCleanup

Ext4Pkg: Fix CRC16 checksumming on block groups

2023-12-03T23:36:16+00:00

Old filesystems (around 2008 and older) do not use CRC32c but rather CRC16-ANSI. Previously, the CalculateCrc16Ansi function was broken and gave us wrong checksums. Adapt to the new interface. And while we're at it, fix the checksum algorithm itself - the crc16 algorithm just skips over the bg_checksum, and does not checksum it. This problem was found out-of-list when older ext4 filesystems (that use crc16 checksums) failed to mount with "corruption". BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4609 Signed-off-by: Pedro Falcato Cc: Savva Mitrofanov Cc: Marvin Häuser Reviewed-by: Marvin Häuser

Ext4Pkg: Advertise CSUM_SEED as supported

2023-05-09T16:47:54+00:00

We had added support for CSUM_SEED but accidentally forgot to advertise it in gSupportedIncompatFeat. This made it (erroneously) impossible to mount CSUM_SEED filesystems. Detected by attempting to mount a relatively new mkfs.ext4'd filesystem. Cc: Marvin Häuser Signed-off-by: Pedro Falcato Reviewed-by: Marvin Häuser

Ext4Pkg: Improve extent node validation on the number of entries

2023-05-09T16:47:48+00:00

Improve the extent tree node validation by validating the number of entries the node advertises against the theoretical max (derived from the size of on-disk structs and the block size (or i_data, if inline extents). Previously, we did not validate the number of entries. This could be exploited for out-of-bounds reads and crashes. Cc: Marvin Häuser Fixes: d9ceedca6c8f ("Ext4Pkg: Add Ext4Dxe driver.") Reported-by: Savva Mitrofanov Signed-off-by: Pedro Falcato Reviewed-by: Marvin Häuser

Ext4Pkg: Move unicode collation initialization to Start()

2023-02-24T00:29:04+00:00

There have been reports[1] of failures to boot due to unicode collation protocols not being available at Ext4Dxe load time. Therefore, attempt to initialize unicode collation at Start() time, like done previously in FatPkg/EnhancedFatDxe. By doing so, we move collation initialization to BDS, where the module responsible for protocol installation should have already been loaded and ran. [1]: https://edk2.groups.io/g/devel/message/100312 Cc: Ard Biesheuvel Cc: Marvin Häuser Fixes: d9ceedca6c8f ("Ext4Pkg: Add Ext4Dxe driver.") Signed-off-by: Pedro Falcato Acked-by: Ard Biesheuvel Reviewed-by: Marvin Häuser

Ext4Pkg: Fix double-free in Ext4ReadSymlink

2023-02-17T19:03:31+00:00

The SymlinkTmp was deallocated unconditionally, so we shouldn't free it again on EFI_ERROR Cc: Marvin Häuser Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: e81432fbacb7 ("Ext4Pkg: Add symbolic links support") Signed-off-by: Savva Mitrofanov Reviewed-by: Marvin Häuser Reviewed-by: Pedro Falcato

Ext4Pkg: Correct memory leak in Ext4ReadSlowSymlink

2023-02-08T16:25:02+00:00

We need to free SymlinkTmp before exiting if SymlinkSizeTmp != ReadSize condition is true. Reported-by: Marvin Häuser Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: e81432fbacb7 ("Ext4Pkg: Add symbolic links support") Signed-off-by: Savva Mitrofanov Reviewed-by: Marvin Häuser Reviewed-by: Pedro Falcato

Ext4Pkg: Filter out directory entry names containing \0 as invalid

2023-02-08T16:25:02+00:00

The directory entry name conventions forbid having null-terminator symbols in its body and can lead to undefined behavior conditions and crashes Cc: Marvin Häuser Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: 89b2bb0db263 ("Ext4Pkg: Fix and clarify handling regarding non-utf8 dir entries") Signed-off-by: Savva Mitrofanov Reviewed-by: Pedro Falcato Reviewed-by: Marvin Häuser

Ext4Pkg: Fix build on MSVC

2023-02-08T16:24:11+00:00

Accessing array using index of uint64 type makes MSVC compiler to include `__allmul` function in NOOPT which is not referenced in IA32. So we null-terminate the string using ReadSize, which should be equal to SymlinkSizeTmp after correct reading. Also add missing MultU64x32 in Ext4Read. Cc: Marvin Häuser Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: 7c46116b0e18 ("Ext4Pkg: Add ext2/3 support") Fixes: e81432fbacb7 ("Ext4Pkg: Add symbolic links support") Signed-off-by: Savva Mitrofanov Reviewed-by: Marvin Häuser Reviewed-by: Pedro Falcato

Ext4Pkg: Add missing exit status in Ext4OpenDirent

2023-02-08T16:23:58+00:00

Missing EFI_OUT_OF_RESOURCES exit status on failed Ext4CreateDentry leads to NULL-pointer dereference in Ext4GetFileInfo (passing NULL buffer in Ext4ReadDir) Cc: Marvin Häuser Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: 21b1853880d5 ("Ext4Pkg: Add a directory entry tree.") Signed-off-by: Savva Mitrofanov Reviewed-by: Pedro Falcato Reviewed-by: Marvin Häuser

Ext4Pkg: Check VolumeName allocation correctness in Ext4GetVolumeName

2023-02-08T16:23:58+00:00

Missing check in some cases leads to failed StrCpyS call in Ext4GetVolumeLabelInfo. Also correct condition that checks Inode pointer for being NULL in Ext4AllocateInode Cc: Marvin Häuser Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: cfbbae595eec ("Ext4Pkg: Add handling of EFI_FILE_SYSTEM_VOLUME_LABEL GetInfo().") Signed-off-by: Savva Mitrofanov Reviewed-by: Pedro Falcato Reviewed-by: Marvin Häuser