Tianocore/edk2-platforms.git/Features/Ext4Pkg/Ext4Dxe/BlockGroup.c, branch master

Ext4Pkg: Fix CRC16 checksumming on block groups

2023-12-03T23:36:16+00:00

Old filesystems (around 2008 and older) do not use CRC32c but rather CRC16-ANSI. Previously, the CalculateCrc16Ansi function was broken and gave us wrong checksums. Adapt to the new interface. And while we're at it, fix the checksum algorithm itself - the crc16 algorithm just skips over the bg_checksum, and does not checksum it. This problem was found out-of-list when older ext4 filesystems (that use crc16 checksums) failed to mount with "corruption". BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4609 Signed-off-by: Pedro Falcato Cc: Savva Mitrofanov Cc: Marvin Häuser Reviewed-by: Marvin Häuser

Ext4Pkg: Add inode number validity check

2023-02-08T16:23:19+00:00

We need to validate inode number to prevent reading non-existent and incorrect inodes so we checks that inode number valid across opened partition before we read it in Ext4ReadInode. Cc: Marvin Häuser Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: d9ceedca6c8f ("Ext4Pkg: Add Ext4Dxe driver.") Signed-off-by: Savva Mitrofanov Acked-by: Marvin Häuser

Ext4Pkg: Fix bug in EXT4_HAS_GDT_CSUM

2022-09-05T22:36:08+00:00

Caught when running clang-tidy on this code. Also tidies up some logic in BlockGroup.c Cc: Marvin Häuser Signed-off-by: Pedro Falcato Reviewed-by: Marvin Häuser

Ext4Pkg: Code correctness and security improvements

2022-08-06T23:24:07+00:00

This changes tends to improve security of code sections by fixing integer overflows, missing alignment checks, unsafe casts, also simplified some routines, fixed compiler warnings and corrected some code mistakes. - Set HoleLen to UINT64 to prevent truncation in Ext4Read function - Replace EXT4_BLOCK_NR with 32-bit EXT2_BLOCK_NR in BlockMap, because by specification files using block maps must be placed within the first 2^32 blocks of a filesystem - Replace UNREACHABLE with ASSERT (FALSE) in case of new checksum algorithms, due to it is an invariant violation rather than unreachable path - Solve compiler warnings. Initialize all fields in gExt4BindingProtocol Fix comparison of integer expressions of different signedness - Field name_len has type CHAR8, while filename limit is 255 (EXT4_NAME_MAX), so because structure EXT4_DIR_ENTRY would be unchangeable in future, we could drop this check without any assertions - Simplify Ext4RemoveDentry logic by using IsNodeInList - Fix possible int overflow in Ext4ExtentsMapKeyCompare - Return bad block type in Ext4GetBlockpath - Adds 4-byte aligned check for superblock group descriptor size field Cc: Marvin Häuser Cc: Pedro Falcato Cc: Vitaly Cheptsov Signed-off-by: Savva Mitrofanov Reviewed-by: Marvin Häuser Reviewed-by: Pedro Falcato

Ext4Pkg: Replace the CRC implementations with BaseLib

2022-06-14T15:56:00+00:00

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3871 Since the existing CRC16/CRC32c implementations have been/will be a part of BaseLib, use BaseLib and remove the Crc16.c/Crc32c.c. Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Pedro Falcato Acked-by: Liming Gao

Ext4Pkg: Add Ext4Dxe driver.

2021-08-19T16:37:57+00:00

Adds a UEFI EXT4 filesystem driver that implements the EFI_FILE_PROTOCOL and EFI_SIMPLE_FILE_SYSTEM_PROTOCOL. Cc: Leif Lindholm Cc: Michael D Kinney Cc: Bret Barkelew Signed-off-by: Pedro Falcato Reviewed-by: Michael D Kinney

Revert "Ext4Pkg: Add Ext4Dxe driver." to correct Author

2021-08-19T16:37:49+00:00

This reverts commit ac10729d2c9482aff7c37545c8d84d38b685c1d9. Signed-off-by: Michael D Kinney

Ext4Pkg: Add Ext4Dxe driver.

2021-08-18T05:17:53+00:00