OpenBMC Distribution (mirror) https://git.radix-linux.su/BMC/tmp/openbmc.git/atom?h=fplus 2024-03-19T17:32:45+00:00 2024-03-19T17:32:45+00:00 Andrew Geissler geissonator@yahoo.com 2024-03-19T16:41:51+00:00 urn:sha1:72972ba4d787f94904e73f976af36ab472e09533 The gerrit logs get filled with this message due to the gerrit issue where it can no longer lookup secondary email addresses for the OWNERS function: User 'edtanous@google.com' does not resolve to any account. As Ed is in the root of openbmc/openbmc, this gets triggered a lot. Move over to Eds preferred email address in gerrit. Change-Id: Id7d2075f4b9bdea2dcb01d82d1e5989ea09f31d8 Signed-off-by: Andrew Geissler <geissonator@yahoo.com> 2021-07-26T13:39:46+00:00 Brad Bishop bradleyb@fuzziesquirrel.com 2021-05-24T14:10:10+00:00 urn:sha1:f7bba8da769e6e363b8a6dede69b8d6eec1e065d More committers are needed to improve commit throughput and overall OpenBMC project robustness. Ed Tanous and Patrick Williams have expressed interest and have an established OpenBMC contribution history as justification. Andrew Geissler has already been maintaining the upstream bitbake metadata for some time now. Change-Id: I881963e4615a59e180401e45a84a557af90242a1 Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com> 2021-02-03T16:16:58+00:00 Andrew Geissler geissonator@yahoo.com 2021-02-03T16:16:58+00:00 urn:sha1:779a182c6adac1c33ae63e0a20f73e19e97047d3 Signed-off-by: Andrew Geissler <geissonator@yahoo.com> Change-Id: Iac0374bc3f229ff7c4456d3ddaf7101ab3fe9b21 2021-01-25T13:40:53+00:00 Ed Tanous edtanous@google.com 2021-01-06T00:55:36+00:00 urn:sha1:5ff169f12d35c5e55ccc88d0e064d8cd39f87031 The gerrit owners plugin allows much more tight grained control over what files in a repository require which approvals. This would allow OpenBMC to use the primary openbmc/openbmc repository for most recipe, distro, and conf file submissions, relying on the owners plugin to gate code checked into meta layers for which they were not allowed. At this time, this file only has the effect of automatically adding owners to gerrit reviews. It requires a separate config change to the rules.pl and project.config to start obeying these for the submissions. My intention with this commit is to first populate the OWNERS files into the subtreed meta-* directories. After that the autobump scripts will push the new changes into the main tree, and we will end up with openbmc/openbmc that now posesses OWNERS files for all the meta layers. Once that is in place, we can then enable the owners plugin on openbmc/openbmc. If it has any unintended impact, we can always roll it back, and go back to the owners plugin being non-enforcing. This commit includes the root OWNERS commit. Open questions that I suspect we can answer later and as we have more experience with this. 1. Should we set inherited to true in all cases, some cases, or never? Inherited means that directories above the one specified inherit the privileges above it, ie, the sub OWNER can merge anything in the tree below it. I suspect this will need to be a case by case basis. 2. Is there a way to specify a special OWNERS file for meta layers that we don't own (meta-oe and others) that provides messages back to the submitter automatically that they should submit their changes directly to upstream? For the moment, the permissions just roll up to the root, and require the root maintainer to comment directly, but it seems likely we could automate this. Tested: I've built a gerrit test project as a test that enables these changes, and submitted https://gerrit.openbmc-project.xyz/c/openbmc/owners-plugin-test/+/39365 and https://gerrit.openbmc-project.xyz/c/openbmc/owners-plugin-test/+/39366 As examples of both positive (should be allowed to merge) and negative (shouldn't be allowed to merge) tests. In both cases, they act as expected, where even if the negative commit is +2 code review and +1 verified, it will not be allowed to merge until the owner +2s it. signed-off-by: Ed Tanous <ed@tanous.net> Change-Id: I6f33acfd12382f8eb7cb1e9ae56046c40de18635