BMC/OpenBmc/webui-vue.git/src, branch master

Fix reversed expand chevron in the event log table

2026-09-17T03:10:51+00:00

The expand button in Event Logs draws its chevron upside down in both states: collapsed shows an up chevron, expanded shows a down one. _tables.scss rotates the icon 180 degrees for any button inside a .table-row-expand cell that does not carry .collapsed: .table-row-expand .btn:not(.collapsed) svg { transform: rotate(180deg); } EventLogs opts into that rule through tdClass: 'table-row-expand' but never applies .collapsed to the button, so the selector matches in both states and the rotation is permanent. The template swaps two icons by hand, chevron--down when collapsed and chevron--up when expanded, and the constant rotation inverts each of them. The swap predates the rule and was correct when written. Before f4861f9 the stylesheet rotated only .btn.collapsed, which these buttons never match, so nothing was rotated and the explicit icons showed through. Inverting the selector to :not(.collapsed) captured every button that had opted out of the class. Adopt the pattern the other nine pages using .table-row-expand already follow, Certificates and every Inventory table among them: bind .collapsed to the row state and render chevron--down alone, letting the stylesheet supply the flip. chevron--down rotated 180 degrees is chevron--up exactly, the two path definitions mapping onto each other point for point under (x,y) -> (32-x, 32-y), so the rendered result is what the template always intended. IconChevronUp is then unused and is removed. Tested: eslint and vite build are clean on the modified file. A scan of every .vue file using .table-row-expand confirms this was the last one not binding .collapsed; the other nine already did. Confirmed in a browser: the expand chevron points down while the row is collapsed and up while it is expanded. Change-Id: I2b0e28ca31d6a363c3f18cf308f17dbf09e74c0f Signed-off-by: Bill Chan

Revert policy selection on save error

2026-09-15T06:29:40+00:00

When a readonly user changes the policy and clicks save, the failed request left the radio group stuck on the new selection. Replace the split computed getter/setter with a local `selectedPolicy` data property and explicitly reset it to the store value on error. Change-Id: I1785384f0a654c8daa447a70e44336bb22ffa4d2 Signed-off-by: Vedangi Mittal

Fix form conditions that test nonexistent properties

2026-08-28T02:47:57+00:00

Four conditions read a property that does not exist, so none of them evaluates the way its author intended. DateTime guards a block that shifts the third NTP address into the second slot after a successful save. The condition reads this.form.ntp.thirdAddres, while the form model defines thirdAddress, so it has never been true. Correcting the name would not make the block run: submitForm filters the empty entry out of the request and then calls setNtpValues(), which rebuilds form.ntp from the compacted list, so by the time the callback runs the second address is already populated and the third already empty. updateDateTime does not commit ntpServers either, so the watcher cannot reopen a hole. Remove the block rather than correct the name - a correctly spelled condition that is always false reads as live code, and invites a later refactor to revive a shift that would then run twice. The guard above it, if (!isNTPEnabled) return, existed only to protect that block and goes with it. ModalSettings and ModalAddDestination test validators that are not declared. lockoutDuration is validated by minValue but the template reads minvalue; lockoutThreshold and port are validated by minValue and maxValue but their templates read minLength and maxLength. Each reference yields undefined and the conditions negate it, so the branch is taken every time the invalid-feedback block renders, leaving the range message in the DOM even for a valid field, where CSS hides it. The message that appears is the right one today only because each of those fields has a single other validator; it would become wrong, silently, as soon as another one is added. Test the validator's $invalid flag instead, which is the form these same files already use for required.$invalid and ipAddress.$invalid. Negating the validator entry itself would not work either: in Vuelidate 2 it is an object, so the branch would never be taken. Tested: In a browser against a QEMU BMC, machine cypress, with each case run on this commit and on its parent. Settings > Date and time, NTP selected, first address set, second empty, third set: after Save the third value appears in the second field within 100ms and the third field is empty, identically before and after this change. That compaction is setNtpValues() inside submitForm, not the removed block. The success toast still appears. Account policy settings: a lockout threshold of 99999 reports "Value must be between 0 - 65535" and an empty one reports "Field required"; with unlock method set to manual, a lockout duration of 0 reports "Must be at least 1" and an empty one "Field required". SNMP alerts > Add destination: a port of 99999 and a port of abc both report "Value must be between 0 - 65535", while 161 and empty are accepted. Every one of those messages is identical before and after. The only difference observed is that before this change the range message is present but hidden for a valid field, and after it nothing is rendered. Also verified that every corrected name is declared where it is now read, that a scan of all .vue files reports no Vuelidate reference whose validator is undeclared in the same file, that eslint passes on all three files, and that prettier 3.4.2 reports both modal files clean. Change-Id: Ib59a22296452e890877e784d3077b166d6d81fc5 Signed-off-by: Bill Chan

Fix auth popup on login page with env builds

2026-08-20T14:29:19+00:00

The ~@/ prefix in @font-face url() declarations is webpack-specific syntax. Vite 6 does not strip the tilde, so the font URLs are left unresolved in the compiled CSS output and the font files are never emitted to dist/. When the browser loads the login page and requests a font at the broken path, bmcweb cannot find a matching route in webroutes::routes and — because no session exists — returns 401 with WWW-Authenticate: Basic, triggering the browser credentials popup. Remove the leading ~ so Vite resolves the @/ alias correctly, copies the font files into dist/assets/, and rewrites the CSS references to proper absolute paths that bmcweb registers and serves without auth. Fixes both _intel.scss and _ibm.scss which share the same pattern. Tested: Confirmed that with .env.intel loaded, there is no longer an auth popup when loading the login page. Change-Id: Ie2a40bed55da057ae75bac111736cb947bac5dc4 Signed-off-by: Jason M. Bills

Fix translation bugs and remove unused keys

2026-08-20T09:25:37+00:00

- Fix three structural bugs found by locale audit: - ka-GE: rename pageFirmware.sectionTitleHostCards to sectionTitleBiosCards to match the key used by FirmwareCardsBios.vue. - ru-RU: move global.offline.okToRetryCancelToLogin out of global.toast.offline to global.offline, restoring the correct nesting path that matches en-US and ka-GE. - PostCodeLogs: fix deleteAllLogs confirm dialog to reference pagePostCodeLogs.modal.deleteAllMessage/Title instead of pageEventLogs.modal.*, decoupling the two pages so future wording changes to Event Logs cannot silently affect Post Code Logs. - TableDns: fix delete action title passed as a raw key string literal to TableRowAction; wrap with i18n.global.t() so the translated string is rendered instead of the key path. - Remove 30 unused translation keys from all three locale files (en-US, ru-RU, ka-GE). They were not being used. Change-Id: I7edd9b326e1a4ad096508d5ed1661e1234c7f571 Signed-off-by: Nikhil Ashoka

Fix header checkbox select-all in View All mode

2026-08-13T04:49:26+00:00

When "View All" is selected under Items per Page, perPage is 0. The selection logic fell back to `this.perPage || 10`, treating the falsy 0 as a page size of 10. Clicking the header checkbox therefore selected only the first 10 displayed logs instead of all of them, and the selected count did not reflect the true total. Treat perPage === 0 as "View All" so the computed page bounds span every item. The calculation is centralized in a getPageBounds() helper shared by the select-all handler and the header checkbox state logic, keeping the two paths consistent. Also fix a UI state bug where, after a resolve/unresolve action, the row checkboxes appeared unselected but the selection header remained visible and still referenced the stale selection. clearSelectedRows() is now called in a finally() block so it runs whether the dispatch succeeds or fails, keeping the selection state consistent. fix issue for: https://github.com/openbmc/webui-vue/issues/142 Change-Id: I46b33c1d73c633d6c7df446ceecaf4222be9ea90 Signed-off-by: Aravinth Sri Krishna Raja Raghavan

show specific error for duplicate SNMP alert destination

2026-08-12T13:44:58+00:00

Use findMessageId() to detect ResourceAlreadyExists in the redfish error response and show a specific toast instead of the generic add destination error. Tested: Adding a duplicate SNMP destination on AST2600 EVB shows the specific error toast instead of the generic one. Related: https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/90890 https://gerrit.openbmc.org/c/openbmc/phosphor-snmp/+/92218 https://gerrit.openbmc.org/c/openbmc/bmcweb/+/93102 Change-Id: I5a4fc6541c246085099aaad7d2515bb84805cb16 Signed-off-by: Vijaysankar Ravi

Replace v-model with :model-value in Policies

2026-08-12T13:31:34+00:00

* Replaced v-model with :model-value on SSH, IPMI, vTPM, RTAD toggles and Session Timeout select, since the bound computed properties are read-only getters backed by the Vuex store. * Removed no-op setters (set(newValue) { return newValue; }) from all five computed properties that existed solely to satisfy v-model's two-way binding requirement. * Simplified rtadState and vtpmState boolean expressions from if/else blocks to a single equality check. * State changes continue to flow through the existing @update:model-value handlers which dispatch the appropriate Vuex store actions. * This change is a follow-up action from https://gerrit.openbmc.org/c/openbmc/webui-vue/+/89544 which implemented Basic Auth using :model-value — applying the same pattern consistently across all other policy toggles on the page. * Tested: Policies page loads correctly, all toggles and session timeout select reflect store state. Enable/Disable interactions dispatch store actions as expected. Change-Id: Ibb2ee51615ed23a397dd9b99eb99e2920320f8a4 Signed-off-by: Nikhil Ashoka

Fix toast visibility and auto-hide behavior

2026-07-20T17:19:53+00:00

In bootstrap-vue-next 0.40.8 a toast's modelValue controls visibility: a number auto-hides after that many milliseconds, true shows until dismissed, and false is never rendered. Because non-success toasts were created with modelValue: false, only success toasts (which used a numeric value) ever appeared. Give every variant a valid modelValue so error, info, and warning toasts render. Success toasts auto-dismiss after 10s; all other variants stay visible until the user closes them manually so important messages are not missed. Change-Id: I2d885aa81d3cfb040d3e29f570f8c8855beae0f1 Signed-off-by: Aravinth Sri Krishna Raja Raghavan

Add Access Denied alert to SOL console

2026-06-25T06:39:00+00:00

Non-admin users navigating to the Serial Over LAN page had no clear feedback — the page either failed silently or showed a generic error. Show the SOL button and nav item to all users and render an Access Denied alert when the session lacks the required privilege. A reusable AccessDeniedAlert global component is introduced so other restricted pages can adopt the same pattern with a single line. Change-Id: Ifbb93bb966c801b3a72230e8f3b752b62ef22929 Signed-off-by: Aravinth Sri Krishna Raja Raghavan