summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2025-08-23Remove unused variablesEd Tanous2-4/+0
In one of the migrations, these are no longer used. Remove them. Change-Id: Id4f8f9129ff26b4e264b9ef6c526862081f67f0c Signed-off-by: Ed Tanous <etanous@nvidia.com>
2025-08-22Refactor Manager Reset ActionsMyung Bae2-168/+148
This refactors manager reset action handling codes and also merges the requestRoute function into one. - handleManagerResetAction - handleManagerResetToDefaultsAction - handleManagerResetActionInfo This also rearranges requestRouteManager setup functions into one. - requestRoutesManager - requestRoutesManagerCollection Tested: - Perform Manager Reset actions - Redfish Service Validator passes Change-Id: Ia76719d98aac8b871f0f275b0bc99999562fe796 Signed-off-by: Myung Bae <myungbae@us.ibm.com>
2025-08-21Refactor Managers codeMyung Bae1-238/+236
This refactors manager handling code by breaking out the route bodies of codes instead of keeping the large code lines in requestRoute function. - handleManagerGet - handleManagerPatch - handleManagerCollectionGet Tested: - Compare GET /redfish/v1/Managers before and after the change - Redfish Service Validator passes Change-Id: Idaa9cc904fd8b42f22389af2230f37e9af05d596 Signed-off-by: Myung Bae <myungbae@us.ibm.com>
2025-08-21IndicatorLED: Add compile option for deprecated propertyJanet Adkins6-25/+71
The IndicatorLED property has been deprecated by Redfish since September 2020. The Redfish Service Validator reports a WARNING for this property: ``` WARNING - IndicatorLED: The given property is deprecated: This property has been deprecated in favor of the `LocationIndicatorActive` property. ``` The LocationIndicatorActive property is now implemented in bmcweb in all places where IndicatorLED was implemented. So a new meson option (redfish-allow-deprecated-indicatorled) is being added to control whether this property is part of get or patch requests. The option is disabled by default with plans to remove the option by March 2026. Tested: - Built with option enabled and confirmed IndicatorLED still part of Redfish responses and can be patched. - Built with option disabled and confirmed Redfish Service Validator no longer reports the warning. - Built with option disabled and confirmed IndicatorLED no longer part of Redfish responses and patch fails appropriately. ``` curl -k -H "X-Auth-Token: $token" -H "Content-Type: application/json" -X PATCH -d '{"IndicatorLED":"Blinking"}' https://${bmc}/redfish/v1/Systems/system { "error": { "@Message.ExtendedInfo": [ { "@odata.type": "#Message.v1_1_1.Message", "Message": "The property IndicatorLED is not in the list of valid properties for the resource.", "MessageArgs": [ "IndicatorLED" ], "MessageId": "Base.1.19.PropertyUnknown", "MessageSeverity": "Warning", "Resolution": "Remove the unknown property from the request body and resubmit the request if the operation failed." } ], "code": "Base.1.19.PropertyUnknown", "message": "The property IndicatorLED is not in the list of valid properties for the resource." } } curl -k -H "X-Auth-Token: $token" -H "Content-Type: application/json" -X PATCH -d '{"IndicatorLED":"Off"}' https://${bmc}/redfish/v1/Chassis/chassis { "error": { "@Message.ExtendedInfo": [ { "@odata.type": "#Message.v1_1_1.Message", "Message": "The property IndicatorLED is not in the list of valid properties for the resource.", "MessageArgs": [ "IndicatorLED" ], "MessageId": "Base.1.19.PropertyUnknown", "MessageSeverity": "Warning", "Resolution": "Remove the unknown property from the request body and resubmit the request if the operation failed." } ], "code": "Base.1.19.PropertyUnknown", "message": "The property IndicatorLED is not in the list of valid properties for the resource." } } ``` Change-Id: I2c0d415a7a54aa3122b18d2a1aa69bd9259d567e Signed-off-by: Janet Adkins <janeta@us.ibm.com>
2025-08-20Make declaration consistentEd Tanous1-1/+1
Declare this inline void, not the other way around to be consistent. This is done to support regex fixing of elements. Change-Id: Ibfec17042b94c07ddc34048881fe5c7d0a290971 Signed-off-by: Ed Tanous <etanous@nvidia.com>
2025-08-20Fix namespaceEd Tanous1-1/+1
This comment snuck in, probably added by clang-format. Fix it. Change-Id: I0c272922c040ab80e9f5849698b063b0cfaea9e8 Signed-off-by: Ed Tanous <ed@tanous.net>
2025-08-20Systems: Update LocationIndicatorActive propertyJanet Adkins3-92/+82
Modify get/set of LocationIndicatorActive property for Systems to use identifying association instead of hard-coding led group.[1] History: Almost 5 years ago IBM added support for this property to the Systems.[2] That original implementation assumed the system and chassis shared the same LED and just looked at the enclosure_identify_blink and enclosure_identify like the existing IndicatorLED property did. IBM renamed these functions getSystemLocationIndicatorActive and setSystemLocationIndicatorActive.[3] The interest from other companies has mostly been around IndicatorLED (old deprecated LED property).[4] Today, LEDs have the association documented above and used elsewhere like PowerSupplies, Fans, etc. Switching to this association: 1) follows the design 2) allows multiple chassis support 3) doesn't assume your system led is your chassis led. This is the last caller of the getSystemLocationIndicatorActive() and setSystemLocationIndicatorActive() functions so they are being removed. [1] https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/58299 [2] https://gerrit.openbmc.org/c/openbmc/bmcweb/+/36886 [3] https://gerrit.openbmc.org/c/openbmc/bmcweb/+/57765 [4] https://gerrit.openbmc.org/c/openbmc/bmcweb/+/27301 Tested: - Redfish Service Validator passes - Confirm able to set and get LED 1. Get for Systems ``` curl -k -H "X-Auth-Token: $token" -X GET https://${bmc}/redfish/v1/Systems/system { { "@odata.id": "/redfish/v1/Systems/system", "@odata.type": "#ComputerSystem.v1_22_0.ComputerSystem", ... "LocationIndicatorActive": false, ... } ``` 2. Set for Systems ``` curl -k -H "X-Auth-Token: $token" -H "Content-Type: application/json" -X PATCH -d '{"LocationIndicatorActive": true}' https://${bmc}/redfish/v1/Systems/system curl -k -H "X-Auth-Token: $token" -X GET https://${bmc}/redfish/v1/Systems/system { "@odata.id": "/redfish/v1/Systems/system", "@odata.type": "#ComputerSystem.v1_22_0.ComputerSystem", ... "LocationIndicatorActive": true, ... } ``` Change-Id: I1c06621586148d4b299b1f8e1ee1fb0ccdc51f10 Signed-off-by: George Liu <liuxiwei@inspur.com> Signed-off-by: Janet Adkins <janeta@us.ibm.com> Co-authored-by: George Liu <liuxiwei@inspur.com>
2025-08-19Clean up .clang-tidyEd Tanous1-39/+0
This file was originally created by listing all clang-tidy checks (from version 7 ish) and dumping them into a file. Over time it has evolved, but now there are quite a few people using this file as an example to enable other repos with tidy, so lets "tidy up" the checks we enable in this list that probably shouldn't be enabled. OSX-specific checks are removed. We don't deploy code on osx The one google style guide check is removed for use of explicit. In practice this didn't help much. boost-use-to-string is removed. To my knowledge it has never flagged a failure. Change-Id: Ic4c0fdc31d66219d77ca30a2ce8ee514e52176b3 Signed-off-by: Ed Tanous <etanous@nvidia.com>
2025-08-18Fix 204/304 incorrectly tracing CRITICAL messageAbiola Asojo2-4/+2
Resolve tracing of CRITICAL message on 1xx, 204(no-content) and 304(not modified) when there is no body in the response. The code is changed to check that 1xx, 204 and 304 response with payloadsize of 0 will not trace the CRITICAL message. Removed setting of no_content on PATCH that was being done before other functions are called. Tested: Used the following commands to check that the CRITICAL message is no longer being traced for no-content and not modified response with no body. 204 no-content ``` curl -k -H "Content-Type: application/json" \ -d '{"PowerRestorePolicy":"LastState"}' \ -X PATCH https://${bmc_ip}/redfish/v1/Systems/system ``` ``` curl -k -H "Content-Type: application/json" \ -H "X-Auth-Token: $bmc_token" -X PATCH \ -d '{"LocationIndicatorActive":true}' \ https://${bmc_ip}/redfish/v1/Managers/bmc ``` 304 not modified ``` curl -k -i https://${bmc_ip}/redfish/ --etag-save etag.out \ -H 'If-Modified-Since: Tue, 21 Nov 2050 08:00:00 GMT' HTTP/1.1 200 OK Allow: GET . . . ETag: "B3A9EAA1" Content-Type: application/json Date: Thu, 14 Aug 2025 22:07:27 GMT Content-Length: 26 ETAG=`cat etag.out`; echo $ETAG curl -k -i https://${bmc_ip}/redfish/ -H "If-None-Match: ${ETAG}" HTTP/1.1 304 Not Modified Allow: GET . . . ETag: "B3A9EAA1" Date: Thu, 14 Aug 2025 22:16:27 GMT Content-Length: 0 ``` Change-Id: I98cc096c1f7e506687d4a6bf5a2e51b2231c0d68 Signed-off-by: Abiola Asojo <abiola.asojo@ibm.com>
2025-08-18Generate update registryAlexander Hansen5-13/+471
Generate the update registry, needed to return correct error messages from update service. Change-Id: Ifaa699cad8531070aea47d2476c1834df7c61e08 Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
2025-08-16Fix Crashdump LogServices SubordinateOverrides privilegesMyung Bae1-26/+7
This updates SubordinateOverrides permissions on Crashdump LogServices. 1) GET methods ``` - /redfish/v1/Systems/<str>/LogServices/Crashdump/ - /redfish/v1/Systems/<str>/LogServices/Crashdump/Entries/<str>/ ``` 2) POST methods ``` - /redfish/v1/Systems/<str>/LogServices/Crashdump/Actions/LogService.ClearLog/ - /redfish/v1/Systems/<str>/LogServices/Crashdump/Actions/LogService.CollectDiagnosticData/ ``` Tested: - Redfish Validator passes Change-Id: Ief83b4aa6a778ee1ed0d0de8725979a5c1266e56 Signed-off-by: Myung Bae <myungbae@us.ibm.com>
2025-08-14Processor: add support for Ampere CPUsRebecca Cran1-0/+5
Add support for Ampere CPUs to processor.hpp. They use the ARM architecture and the ARM-A64 (AArch64) instruction set. Change-Id: I49ebe574928cf71e4efa07a7448686b13690bde5 Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
2025-08-14Fix : PATCH always returns 204 response for invalid argumentsChandramohan Harkude1-1/+0
Problem: It is observed that PATCH request network protocol using request ``` curl -k -u ${credentials} -X PATCH https://${IP}/redfish/v1/Managers/bmc/NetworkProtocol -d '{"NTP": {"ProtocolEnabled": true, "NTPServers": ["\n"]}}' -H "Content-Type:application/json" returns 204 response. Root cause : The 400 Bad response set by bmcweb when NTP server set value "NTPServers": ["\n"] is overridden by "ProtocolEnabled" response value of 204 therefore we were getting 204 response for invalid arguments as well. Fix : Check the response of "NTPServers" value in async object and set the response code The MRs for PDI and phosphor network are as below https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/82693 https://gerrit.openbmc.org/c/openbmc/phosphor-networkd/+/82694 Testing: curl -k -u ${credentials} -X PATCH https://${IP}/redfish/v1/Managers/bmc/NetworkProtocol -d '{"NTP": {"ProtocolEnabled": true, "NTPServers": ["\n"]}}' -H "Content-Type:application/json" { "error": { "@Message.ExtendedInfo": [ { "@odata.type": "#Message.v1_1_1.Message", "Message": "The property 'NTP/NTPServers/' with the requested value of '[\"\\n\"]' could not be written because the value does not meet the constraints of the implementation.", "MessageArgs": [ "NTP/NTPServers/", "[\"\\n\"]" ], "MessageId": "Base.1.19.PropertyValueIncorrect", "MessageSeverity": "Warning", "Resolution": "None." } ], "code": "Base.1.19.PropertyValueIncorrect", "message": "The property 'NTP/NTPServers/' with the requested value of '[\"\\n\"]' could not be written because the value does not meet the constraints of the implementation." } } ``` Change-Id: Icfbfc3d065a6a307344093eef8b2eb3e39c70f83 Signed-off-by: Chandramohan Harkude <chandramohan.harkude@gmail.com>
2025-08-14Fix clang c++23 warningEd Tanous1-1/+0
This warning was added when we were on c++20, and we didn't want warnings about c++23 features. We're on c++23 now, so it's not needed Change-Id: Ie062f4536b745ca76fd3364ecb642ff18812dc96 Signed-off-by: Ed Tanous <etanous@nvidia.com>
2025-08-13flip http2 flag for generate auth cert integration testMalik Akbar Hashemi Rafsanjani1-4/+4
this commit is enhancing the gen auth cert test by using better flag option for http2 and not flipping the value Change-Id: I989606807ba0f286a16c1e6e3f1bfc5dbe6a430d Signed-off-by: Malik Akbar Hashemi Rafsanjani <malikrafsan@meta.com>
2025-08-13update service: extract get version callbackAlexander Hansen1-62/+56
Extract getSoftwareVersionCallback from inline lambda for readability reasons. Tested: Next patches in series. Change-Id: I5b89bcfb47b55336bbbe70063bb68f94f2513a21 Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
2025-08-13update service: extract function from lambdaAlexander Hansen1-63/+60
Extract handleUpdateServiceFirmwareInventoryGetCallback for readability reasons. Tested: on Tyan s8030. fw inventory response as before. ``` curl --insecure --user root:root https://${bmc}/redfish/v1/UpdateService/FirmwareInventory/HostSPIFlash_7715 { "@odata.id": "/redfish/v1/UpdateService/FirmwareInventory/HostSPIFlash_7715", "@odata.type": "#SoftwareInventory.v1_1_0.SoftwareInventory", "Description": "Unknown image", "Id": "HostSPIFlash_7715", "Name": "Software Inventory", "Status": { "Health": "Warning", "HealthRollup": "OK", "State": "Disabled" }, "Updateable": true, "Version": "Unknown" } ``` Change-Id: Ib71edd91c82dfe1893f7eca1d53b0b05f5bf1415 Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
2025-08-13add integration testing for auth using http2Malik Akbar Hashemi Rafsanjani1-5/+22
with this commit, we will make the integration testing of `generate_auth_certificate` to use http2 by default this is aligned with previous commit to enable http2 for mutual TLS Change-Id: I79bb95ef1ad3aaa597900c122372a06d205386f2 Signed-off-by: Malik Akbar Hashemi Rafsanjani <malikrafsan@meta.com>
2025-08-13Enable Mutual TLS for http2 connectionsEd Tanous3-8/+11
Passing the TLS-provided credentials from the HTTP connection to the http2 connection got missed, and appears to break mutual TLS for http2 connections. Pass the credentials. Tested: Mutual TLS is now functional on http2 connections as shown in the next patch. Change-Id: Ia2bbcd5383dae859baa96908b76f221b9c74632c Signed-off-by: Ed Tanous <etanous@nvidia.com>
2025-08-12Fix handling of ssl_key_handler for WebUIMyung Bae3-5/+8
The previous commit 90cd2e1 [1] causes WebUI to fail to load and connect. It is because a global static var (`hasWebuiRoute`) is instantiated per compile unit and it ends up causing the inconsistency of the value of it. Tested: - Verify WebUI to load successful - Redfish Service Validator passes [1] https://github.com/openbmc/bmcweb/commit/90cd2e1d2e2228b0c575c9a3b6b2dc75eac9eb68 Change-Id: I09c3a9a831528e25c09299b0ee15993974d94d88 Signed-off-by: Myung Bae <myungbae@us.ibm.com>
2025-08-12Refactor multipart update parameter extractionrajeeranjan1-77/+102
This commit extracts helper functions to improve code readability: - parseFormPartName(): Parses the 'name' parameter from Content- Disposition - processUpdateParameters(): Handles UpdateParameters JSON processing The extractMultipartUpdateParameters() function is refactored to use these helpers, making the code more modular and easier to understand. This is a pure refactoring with no functional changes. Change-Id: I9bfd3c92666bbe362512d9fdd9472a4e44ad2241 Signed-off-by: Ed Tanous <etanous@nvidia.com> Signed-off-by: Rajeev Ranjan <ranjan.rajeev1609@gmail.com>
2025-08-11meson: simplify sdbusplus dependencyPatrick Williams1-6/+1
There is a lot of cruft in the sdbusplus dependency that is no longer needed: 1. Use "dependency" with wrap file support rather than "subproject". 2. Remove "include_type: system" since this is part of sdbusplus itself now. 3. Leverage wrap file "provides" directives for dependency variable lookup. Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I419aed22297e004a0808d3a05f1d69abca326943
2025-08-07identity.hpp: add header guardAlexander Hansen1-0/+2
Add `#pragma once` to a header file. Noticed this issue when trying unity build in yocto environment. ``` bbmcweblib.a.p/bmcweblib-unity0.cpp | In file included from ../git/redfish-core/lib/network_protocol.hpp:14, | from /home/alexander/openbmc/build/s8030/tmp/work/arm1176jzs-openbmc-linux-gnueabi/bmcweb/1.0+git/build/../git/redfish-core/src/redfish.cpp:30, | from libbmcweblib.a.p/bmcweblib-unity0.cpp:13: | ../git/include/identity.hpp:7:20: error: redefinition of 'std::string getHostName()' | 7 | inline std::string getHostName() | | ^~~~~~~~~~~ | In file included from /home/alexander/openbmc/build/s8030/tmp/work/arm1176jzs-openbmc-linux-gnueabi/bmcweb/1.0+git/build/../git/http/mutual_tls.cpp:7, | from libbmcweblib.a.p/bmcweblib-unity0.cpp:1: | ../git/include/identity.hpp:7:20: note: 'std::string getHostName()' previously defined here | 7 | inline std::string getHostName() | | ^~~~~~~~~~~ | ninja: build stopped: subcommand failed. | INFO: autodetecting backend as ninja ``` Tested: Inspection only. Change-Id: Ib7811ee12da763203b50fc81d39d642d2de3e212 Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
2025-08-05Fix patching MetricReportDefinition's ReportActionMichal Orzel1-56/+23
Due to missing code, successful PATCH requests on `MetricReportDefinition` resource with changed `ReportActions` property always returned internal error. This change corrects that behavior by adding handler exit when dbus method call doesn't return any error. Error handling process has been reviewed and optimized, to make sure that `verifyCommonErrors` gets called for every request. Tested: 1. Add simple report definition via POST on /redfish/v1/TelemetryService/MetricReportDefinitions, with some initial value of `ReportActions` property. 2. PATCH request on created `MetricReportDefinition` resource with new value of `ReportActions` property. 3. Verified that response code is same as expected (204). Change-Id: Ieef1b53fa6e1f7095e878abe3a71c0a6080dccbd Signed-off-by: Michal Orzel <michalx.orzel@intel.com>
2025-07-31Multi-host helper functionsOliver Brewka1-0/+142
The change implements the getComputerSystemIndex function which leverages the xyz.openbmc_project.ManagedHost interface to retrieve the index corresponding to the host the request was made for, when on a multi-host machine. On single-host the index always defaults to 0. It is not the perfect solution, but it is a starting point to introduce multi-host support to bmcweb, allowing for power control, via redfish and in general something we can build from. More efficient ways of doing things are already discussed, but will need more time to design properly. The implementation relies on the experimental-redfish-multi-computer-system meson flag to give bmcweb an indication, whether it is running on single- or multi-host and to drop unsupported redfish resources for the time being. Multi-host meson options needed: -Dexperimental-redfish-multi-computer-system=enabled -Dredfish-system-uri-name= These helper functions are needed for the multi-host patches further down the patch chain. Tested: All relevant tests have been made in the following patches. Change-Id: Ie481aa8b05903dab59f39a1134463ac0c54aa781 Signed-off-by: Oliver Brewka <oliver.brewka@9elements.com>
2025-07-30Correct determination of Trigger's MetricTypeMichal Orzel1-26/+37
Determining triggers type only by checking existence of either `DiscreteThresholds` or `NumericThresholds` is wrong, because both properties are always present in their dbus interface representation. This leads to situations, where: - `Trigger` resources, which were supposed to be numeric, contain properties exclusive to discrete ones (like `DiscreteTriggerCondition`), - `Trigger` resources, which were supposed to be discrete, have `MetricType` set to `Numeric` (because `NumericThresholds` property exists as an empty array). To fully determine trigger's type, a check for `Discrete` property value need to be made. Tested: 1. POST three different triggers on /redfish/v1/TelemetryService/Triggers: - simple numeric trigger (`MetricType` set to `Numeric`, non-empty `NumericThresholds`) - simple discrete trigger (`MetricType` set to `Discrete`, `DiscreteTriggerCondition` set to `Specified`, non-empty `DiscreteTriggers`) - simple discrete on-change trigger (`MetricType` set to `Discrete`, `DiscreteTriggerCondition` set to `Changed`, empty `DiscreteTriggers`) 2. Verified `MetricType` value of created `Trigger` resources: - simple numeric trigger has `MetricType` set to `Numeric`, - simple discrete trigger has `MetricType` set to `Discrete`, - simple discrete on-change trigger has `MetricType` set to `Discrete`. Change-Id: Ifc7033eda0fb52fa42e292e1dc36dc433e9ea022 Signed-off-by: Michal Orzel <michalx.orzel@intel.com>
2025-07-25Work around nlohmann changesEd Tanous2-18/+51
https://github.com/nlohmann/json/issues/4475 recently changed behavior that we rely on in a lot of places, and unit tests appear to have caught the failure. Functionally, this changes the readJson* class of values to attempt to read as the type requested first, then attempt to read as the opposite int/uint type requested, with a range check. In addition, the range check functions now need updated to handle comparisons between non-similar value types. Luckily c++20 added cmp_less/greater type functions that we can make use of. Tested: unit tests pass. Change-Id: If114bd55225a3a9948e80a407b19b69f50d048b6 Signed-off-by: Ed Tanous <etanous@nvidia.com>
2025-07-24Fix potential increment past end in ethernetEd Tanous1-2/+5
Coverity warns that this is a bug. GCC-15 treats it as a hard error. Incrementing past the end of an iterator is undefined behavior, so add a check to ensure it never happens. This was originally submitted as part of a larger change here: https://gerrit.openbmc.org/c/openbmc/bmcweb/+/81720 But because this is now breaking the build, put this in its own commit. Tested: Not great testing available for this, and Redfish array behavior is very subtle. Inspection only. Change-Id: I15669bb7212fbd330cf1022670c9ad558ffabe73 Signed-off-by: Ed Tanous <etanous@nvidia.com>
2025-07-23Trace URI when body on 204/304Abiola Asojo3-7/+19
Trace URI on the existing CRITICAL message when a body exists but HTTP return code was Informational responses (100 – 199), no-content (204), or not_modified (304). Tested: With these changes, the URI is traced on the CRITICAL message: ``` curl --http2 -k -H "Content-Type: application/json" \ -d '{"PowerRestorePolicy":"LastState"}' \ -X PATCH https://${bmc}/redfish/v1/Systems/system root@p10bmc:~# journalctl | grep Response Jun 20 15:30:46 p10bmc bmcwebd[296]: [http_response.hpp:213] 0x1353670 Response content provided but code was no-content or not_modified, which aren't allowed to have a body for url : "/redfish/v1/Systems/system" ``` Change-Id: I1ef618600642d355fc9f935d055b011e044caf5c Signed-off-by: Abiola Asojo <abiola.asojo@ibm.com>
2025-07-22Chassis: Update LocationIndicatorActive propertyJanet Adkins1-3/+3
Modify get/set of LocationIndicatorActive property for Chassis to use identifying association instead of hard-coding D-Bus path to led group.[1] History: Almost 5 years ago IBM added support for this property to the Chassis.[2] That original implementation assumed 1 chassis and just looked at the enclosure_identify_blink and enclosure_identify like the existing IndicatorLED property did. IBM renamed these functions getSystemLocationIndicatorActive and setSystemLocationIndicatorActive.[3] These functions are also used by the system resource. The interest from other companies has mostly been around IndicatorLED (old deprecated LED property).[4] Today, LEDs have the association documented above and used elsewhere like PowerSupplies, Fans, etc. Switching to this association: 1) follows the design 2) allows multiple chassis support 3) doesn't assume your system led is your chassis led. In the future: 1) system should also move to this association design 2) IndicatorLED should be deprecated - it has been 5 years This could be put behind a compile flag but this function is broken with the assumption the system/chassis are the same led. Let's just move to the new design. IBM drove all these changes in and although other companies have shown interest around LEDs in Redfish, there hasn't been much in OpenBMC, so let's just fix. [1] https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/58299 [2] https://gerrit.openbmc.org/c/openbmc/bmcweb/+/36886 [3] https://gerrit.openbmc.org/c/openbmc/bmcweb/+/57765 [4] https://gerrit.openbmc.org/c/openbmc/bmcweb/+/40969 Tested: - Redfish Service Validator passes - Confirm able to set and get LED 1. Get for Chassis ``` curl -k -H "X-Auth-Token: $token" -X GET https://${bmc}/redfish/v1/Chassis/chassis { "@odata.id": "/redfish/v1/Chassis/chassis", "@odata.type": "#Chassis.v1_22_0.Chassis", ... "LocationIndicatorActive": false, ... } ``` 2. Set for Chassis ``` curl -k -H "X-Auth-Token: $token" H "Content-Type: application/json" -X PATCH -d '{"LocationIndicatorActive":true}' https://${bmc}/redfish/v1/Chassis/chassis curl -k -H "X-Auth-Token: $token" -X GET https://${bmc}/redfish/v1/Chassis/chassis { "@odata.id": "/redfish/v1/Chassis/chassis", "@odata.type": "#Chassis.v1_22_0.Chassis", ... "LocationIndicatorActive": true, ... } ``` Change-Id: I78d07f82a8bbf91adb84e53178d3344ba95c9a14 Signed-off-by: Janet Adkins <janeta@us.ibm.com>
2025-07-21meson: break out test/meson.buildAlexander Hansen2-86/+88
Take advantage of nesting meson files in directories to make things more readable. e.g. file path literals become shorter. Tested: tests still build and pass. Change-Id: I20cca4f35fb326df33a337bdbadb9811b78962a7 Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
2025-07-17manager: Lower software version log severityDaniel Hsu1-1/+6
During the transition to using phosphor-settings-defaults-native for setting the software version, the version field may temporarily be empty. This change lowers the log severity for that case to avoid unnecessary warnings during expected intermediate states. ''' Jun 20 02:41:49 bmc bmcwebd[709]: [error_messages.cpp:1248] Internal Error /usr/src/debug/bmcweb/1.0+git/redfish-core/include/utils/sw_utils.hpp(126:32) `void redfish::sw_util::afterGetProperties(const std::shared_ptr<bmcweb::AsyncResp>&, const std::string&, bool, const std::string&, const std::string&, bool, const boost::system::error_code&, const dbus::utility::DBusPropertiesMap&)`: ''' Change-Id: I9123278f863fcf04107b42a5996ccb725c1bd870 Signed-off-by: Daniel Hsu <Daniel-Hsu@quantatw.com>
2025-07-14Implement zstd decompressionEd Tanous15-14/+373
Given the size of Redfish schemas these days, it would be nice to be able to store them on disk in a zstd format. Unfortunately, not all clients support zstd at this time. This commit implements reading of zstd files from disk, as well as decompressing zstd in the case where the client does not support zstd as a return type. Tested: Implanted an artificial zstd file into the system, and observed correct decompression both with an allow-encoding header of empty string and zstd. Change-Id: I8b631bb943de99002fdd6745340aec010ee591ff Signed-off-by: Ed Tanous <etanous@nvidia.com>
2025-07-13Extend expiry date of experimental multi-host flagOliver Brewka1-1/+1
As the 'experimental-redfish-multi-computer-system' flag is actively used for development the expiry has been extended. Tested: Inspection only Change-Id: I1bbf635a04b87ec59ec2eaabb01173258187092e Signed-off-by: Oliver Brewka <oliver.brewka@9elements.com>
2025-07-11Add SubordinateOverrides & Fix Log_services privilegesAbhishek Patel4-9/+164
SubordinateOverrides: This commit automates the creation of SubordinateOverrides privileges structures from the redfish privilege registry. In addition, it enhances the function of parse_registries.py. It reads SubordinateOverrides privilege registry from DMTF and generates const defines SubordinateOverrides for all the privilege registry entries in the same format that the Privileges struct accepts. Moreover, it generates unique const defines for all SubordinateOverrides target levels. Ex: EthernetInterface SubordinateOverrides has two "Targets": ["Manager", "EthernetInterfaceCollection"]. So parse_registries.py generates two unique const 1) Subordinate override for Manager -> EthernetInterface 2) Subordinate override for Manager -> EthernetInterfaceCollection -> EthernetInterface Note: if SubordinateOverrides privilege gets changed, then it automatically updates that route privilege, but if SubordinateOverrides target gets changed, then the user needs to update that manually. Fix Log_services privileges: In Log_services, some of the privileges not following the Redfish_1.1.0_PrivilegeRegistry registry. This commit contains the following LogServices privileges. 1) POST method ``` ComputerSystem -> LogServiceCollection -> LogService - POST /redfish/v1/Systems/<str>/LogServices/EventLog/Actions/LogService.ClearLog/ - POST /redfish/v1/Systems/<str>/LogServices/Dump/Actions/LogService.CollectDiagnosticData/ - POST /redfish/v1/Systems/<str>/LogServices/Dump/Actions/LogService.ClearLog/ - POST /LogServices/PostCodes/Actions/LogService.ClearLog/ ``` 2) DELETE method ``` ComputerSystem -> LogServiceCollection -> LogService -> LogEntryCollection -> LogEntry - DELETE /redfish/v1/Systems/<str>/LogServices/EventLog/Entries/<str>/ ``` This commit also changes the current privilege 1) ConfigureManager to ConfigureComponents. ``` DELETE /redfish/v1/Systems/<str>/LogServices/EventLog/Entries/<str> ``` 2) ConfigureCompnents -> ConfigureManager ``` POST /redfish/v1/Systems/<str>/LogServices/Dump/Actions/LogService.ClearLog/ POST /redfish/v1/Systems/<str>/LogServices/EventLog/Actions/LogService.ClearLog/ POST /redfish/v1/Systems/<str>/LogServices/Dump/Actions/LogService.CollectDiagnosticData/ ``` Tested: manually tested on Witherspoon system, there is no change in output. Run Redfish validator, with all different Privileges; Error Get: UUID: String '' does not match pattern '' this commit doesn't affect UUID Email sent to openbmc list: https://lists.ozlabs.org/pipermail/openbmc/2021-August/027232.html Change-Id: I37d8a2882f1cfaa59a482083f180fdd0805e2e7d Signed-off-by: Abhishek Patel <Abhishek.Patel@ibm.com> Signed-off-by: Myung Bae <myungbae@us.ibm.com>
2025-07-09Move http2 out of experimentalEd Tanous5-11/+10
Http2 support in bmcweb has been relatively stable for a while. The http2 implementation passes all known Redfish tests (some of which require ported to httpx to support http2), the UI loads, and so far as the project is concerned, is a complete improvement over the existing http1 stack. This commit removes the experimental classification from http2, and declares it ready for production use, while enabling it by default. note, that enabling this by default only makes the server advertise that http2 is available. Http2 must still be supported by the client to enable ALPN negotiation, so existing http1 clients that only support http1 will continue to function as they did before. Tested: Enabled http option and saw http2 advertised, http2 now takes effect. Change-Id: I92843a3afc532f0b2a64904bb872e5d84a1a54fe Signed-off-by: Ed Tanous <etanous@nvidia.com>
2025-07-09meson: use non-deprecated systemd packageconfigPatrick Williams1-1/+1
Systemd's packageconfig file has both `systemdsystemunitdir` and `systemd_system_unit_dir` defined. The non-underscore one appears to be a deprecated alias[1]. Move to the non-deprecated / underscore-separated variant. [1]: https://github.com/systemd/systemd/commit/4908de44b0a0409f84a7cdc5641b114d6ce8ba03 Change-Id: I7bf9b444aa8f04eb2b8ded05e502fee47e903639 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
2025-07-09Make LDAP arrays empty if not configuredEd Tanous1-2/+8
These arrays should not be populated if there are no handlers for these configured. Fixes https://github.com/openbmc/bmcweb/issues/105 Change-Id: Idbd04eb97ced75e44de6ed98aa1f0d410f0aebc7 Signed-off-by: Ed Tanous <etanous@nvidia.com>
2025-07-07Add ServiceIdentificationCorey Ethington5-2/+92
Implements GET and PATCH support for ServiceIdentification in Managers/bmc and service root. Tested: - Refish Service Validator passes - Tested on romulus: 1. GET initial value ``` curl -k "https://$BMC/redfish/v1" { ... } ``` ServiceIdentification is not yet present in service root, as expected ``` curl -k -H "X-Auth-Token: $XAUTH_TOKEN" "https://$BMC/redfish/v1/Managers/bmc" { ... "ServiceIdentification": "", ... } ``` 2. PATCH and GET with valid value ``` curl -k -X PATCH "https://$BMC/redfish/v1/Managers/bmc" -H "X-Auth-Token: $XAUTH_TOKEN" \ -H 'Content-Type: application/json' --data-raw '{"ServiceIdentification": "foo"}' { "@Message.ExtendedInfo": [ { "@odata.type": "#Message.v1_1_1.Message", "Message": "The request completed successfully.", "MessageArgs": [], "MessageId": "Base.1.19.Success", "MessageSeverity": "OK", "Resolution": "None." } ] } curl -k "https://$BMC/redfish/v1" { ... "ServiceIdentification": "foo", ... } curl -k -H "X-Auth-Token: $XAUTH_TOKEN" "https://$BMC/redfish/v1/Managers/bmc" { ... "ServiceIdentification": "foo", ... } ``` 3. PATCH and GET with invalid value ``` curl -k -X PATCH "https://$BMC/redfish/v1/Managers/bmc" -H "X-Auth-Token: $XAUTH_TOKEN" \ -H 'Content-Type: application/json' --data-raw '{"ServiceIdentification": "$$$"}' { "ServiceIdentification@Message.ExtendedInfo": [ { "@odata.type": "#Message.v1_1_1.Message", "Message": "The value provided for the property ServiceIdentification is not valid.", "MessageArgs": [ "ServiceIdentification" ], "MessageId": "Base.1.19.PropertyValueError", "MessageSeverity": "Warning", "Resolution": "Correct the value for the property in the request body and resubmit the request if the operation failed." } ] } curl -k -X PATCH "https://$BMC/redfish/v1/Managers/bmc" -H "X-Auth-Token: $XAUTH_TOKEN" \ -H 'Content-Type: application/json' --data-raw '{"ServiceIdentification": "2222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222"}' { "error": { "@Message.ExtendedInfo": [ { "@odata.type": "#Message.v1_1_1.Message", "Message": "The string 'ServiceIdentification' exceeds the length limit 99.", "MessageArgs": [ "ServiceIdentification", "99" ], "MessageId": "Base.1.19.StringValueTooLong", "MessageSeverity": "Warning", "Resolution": "Resubmit the request with an appropriate string length." } ], "code": "Base.1.19.StringValueTooLong", "message": "The string 'ServiceIdentification' exceeds the length limit 99." } } curl -k "https://$BMC/redfish/v1" { ... "ServiceIdentification": "foo", ... } curl -k -H "X-Auth-Token: $XAUTH_TOKEN" "https://$BMC/redfish/v1/Managers/bmc" { ... "ServiceIdentification": "foo", ... } ``` Change-Id: I5b71a73e947ec64cabb8d93c8503a18fb43b8937 Signed-off-by: Corey Ethington <cethington@coreweave.com>
2025-07-01fix description for redfish-updateservice-use-dbusJagpal Singh Gill1-4/+0
Update description for redfish-updateservice-use-dbus meson option. As this feature is enabled, drop the temporary and timeline related statements. Change-Id: Ie81faeed53f1db7bbd001d9b489d9ea1cb43810f Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>
2025-07-01docs: create docs folderAlexander Hansen11-6/+6
To better organize the docs and align with other repos [1],[2],[3],[4] create a folder for documentation. Links between the docs have been adjusted to match their new place. References: [1] https://github.com/openbmc/phosphor-logging/tree/master/docs [2] https://github.com/openbmc/entity-manager/tree/master/docs [3] https://github.com/openbmc/libpldm/tree/main/docs [4] https://github.com/openbmc/sdbusplus/tree/master/docs Change-Id: Ibf990d0d78548bc3407b7f98ccf6a650b1744939 Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
2025-06-30Implement LocationIndicatorActive for Manager resourceGeorge Liu2-0/+73
Implement LocationIndicatorActive for Manager schema to set and get the status of the location LED for the manager.[1] This property was added to the Manager schema in version v1_11_0. Uses the utility functions getLocationIndicatorActive() and setLocationIndicatorActive() to follow the association and get or set the LED value. [1] https://redfish.dmtf.org/schemas/v1/Manager.v1_22_0.json Tested: - Redfish Service Validator passes - Tested on p10bmc hardware simulator: 1. Get LocationIndicatorActive ``` curl -k -H "X-Auth-Token: $token" -X GET https://${bmc}/redfish/v1/Managers/bmc { "@odata.id": "/redfish/v1/Managers/bmc", "@odata.type": "#Manager.v1_14_0.Manager", ... "LocationIndicatorActive": false, "LogServices": { "@odata.id": "/redfish/v1/Managers/bmc/LogServices" }, ... } ``` 2. Set LocationIndicatorActive to true ``` curl -k -H "X-Auth-Token: $token" -H "Content-Type: application/json" -X PATCH -d '{"LocationIndicatorActive":true}' https://${bmc}/redfish/v1/Managers/bmc curl -k -H "X-Auth-Token: $token" -X GET https://${bmc}/redfish/v1/Managers/bmc { "@odata.id": "/redfish/v1/Managers/bmc", "@odata.type": "#Manager.v1_14_0.Manager", ... "LocationIndicatorActive": true, ... } ``` 3. Use busctl set-propery to change the value back to false ``` busctl get-property xyz.openbmc_project.LED.GroupManager /xyz/openbmc_project/led/groups/bmc_ingraham_identify xyz.openbmc_project.Led.Group Asserted b true busctl set-property xyz.openbmc_project.LED.GroupManager /xyz/openbmc_project/led/groups/bmc_ingraham_identify xyz.openbmc_project.Led.Group Asserted b false curl -k -H "X-Auth-Token: $token" -X GET https://${bmc}/redfish/v1/Managers/bmc { "@odata.id": "/redfish/v1/Managers/bmc", "@odata.type": "#Manager.v1_14_0.Manager", ... "LocationIndicatorActive": false, ... } ``` 4. Error returned when trying to set the value to non-boolean ``` curl -k -H "X-Auth-Token: $token" -H "Content-Type: application/json" -X PATCH -d '{"LocationIndicatorActive":1}' https://${bmc}/redfish/v1/Managers/bmc { "LocationIndicatorActive@Message.ExtendedInfo": [ { "@odata.type": "#Message.v1_1_1.Message", "Message": "The value '1' for the property LocationIndicatorActive is not a type that the property can accept.", "MessageArgs": [ "1", "LocationIndicatorActive" ], "MessageId": "Base.1.19.PropertyValueTypeError", "MessageSeverity": "Warning", "Resolution": "Correct the value for the property in the request body and resubmit the request if the operation failed." } ] } ``` 5. Error returned when specifying an unknown Manager resource ``` curl -k -H "X-Auth-Token: $token" -H "Content-Type: application/json" -X PATCH -d '{"LocationIndicatorActive":true}' https://${bmc}/redfish/v1/Managers/bmc2 { "error": { "@Message.ExtendedInfo": [ { "@odata.type": "#Message.v1_1_1.Message", "Message": "The requested resource of type Manager named 'bmc2' was not found.", "MessageArgs": [ "Manager", "bmc2" ], "MessageId": "Base.1.19.ResourceNotFound", "MessageSeverity": "Critical", "Resolution": "Provide a valid resource identifier and resubmit the request." } ], "code": "Base.1.19.ResourceNotFound", "message": "The requested resource of type Manager named 'bmc2' was not found." } } curl -k -H "X-Auth-Token: $token" -X GET https://${bmc}/redfish/v1/Managers/bmc2 { "error": { "@Message.ExtendedInfo": [ { "@odata.type": "#Message.v1_1_1.Message", "Message": "The requested resource of type Manager named 'bmc2' was not found.", "MessageArgs": [ "Manager", "bmc2" ], "MessageId": "Base.1.19.ResourceNotFound", "MessageSeverity": "Critical", "Resolution": "Provide a valid resource identifier and resubmit the request." } ], "code": "Base.1.19.ResourceNotFound", "message": "The requested resource of type Manager named 'bmc2' was not found." } } ``` Signed-off-by: George Liu <liuxiwei@inspur.com> Signed-off-by: Janet Adkins <janeta@us.ibm.com> Change-Id: I7155e2298962a950491da89e92f8480f98dbeccb
2025-06-27Rearrange featuresEd Tanous24-15/+35
The backends are different things compared to generic code. Today, these are all included in the /include folder, but it's not very clear what options control which backends, or how things map together. This also means that we can't separate ownership between the various companies. This commit is a proposal to try to create a features folder, separated by the code for the various backends, to make interacting with this easier. It takes the form features/<option name>/files.hpp features/<option name>/files_test.hpp Note, redfish-core was already at top level, and contains lots of code, so to prevent lots of conflicts, it's simply symlinked into that folder to make clear that it is a backend, but not to move the implementation and cause code conflicts. Tested: Unit tests pass. Code compiles. Change-Id: Idcc80ffcfd99c876734ee41d53f894ca5583fed5 Signed-off-by: Ed Tanous <etanous@nvidia.com>
2025-06-27Fix internal error of boot override propertiesAllen.Wang1-8/+12
Multihost system doesn't have host0 object and we do not plan to support this unnecessary feature at the moment. Do not raise an internal error to avoid causing system URI failures with a 500 return code. Tested on yosemite4: - Verified that no internal error occurs during the boot override process. Change-Id: I4d13db3c77be2ee709884cde813df9593b575530 Signed-off-by: Allen Wang <Allen_Wang@quantatw.com>
2025-06-26Map Error.Unavailable to something betterGunnar Mills1-1/+2
This commit is meant to kick off discussion on how we map errors from dbus to Redfish. Currently WIP. Looking for feedback. Do we want a new xyz.openbmc_project.Common.Error.ResourceInStandby that we can map to Redfish's resourceInStandby? Do we think PropertyValueExternalConflict should be mapped to something different? Are we okay with this commit, does this work for AppliedConfig? xyz.openbmc_project.Common.Error.Unavailable was added to Logging Entry's Resolved Property as an error. It is used for cases when the users attempts to set the Resolved property but is prevented until some action is taken, "the system is not currently in a state to allow this", the PDI review here has some more discussion[1]. The current mapping of xyz.openbmc_project.Common.Error.Unavailable to resourceInStandby was added to SetProperty here[2] in April and comes from this AppliedConfig error handling which was added in May 2021 by Jonathan at Intel[3]. Mapping Error.Unavailable to resourceInStandby is a big assumption that might apply in the AppliedConfig usecase but wouldn't overall. PropertyValueExternalConflict is a bit broader and might work in this AppliedConfig case? The PDI AppliedConfig[4] and AppliedConfig in smbios[5]. Redfish doesn't have a Temporary Unavailable to mean "the system is not currently in a state to allow this", PropertyValueExternalConflict is as close as we get. xyz.openbmc_project.Common.Error.NotAllowed maps to Redfish's propertyNotWritable and that is "this property can never be wrote". We map a few things to serviceTemporarilyUnavailable, the only Redfish error to use the word "Unavailable", but that is for temporarily unavailable and retry in x seconds. These Redfish errors can be found at: https://redfish.dmtf.org/registries/Base.1.19.0.json [1]: https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/74019 [2]: https://github.com/openbmc/bmcweb/commit/87c449664e5375abb040af6fad63ef965c311bec [3]: https://github.com/openbmc/bmcweb/commit/3cde86f14b7835775d7c37e993fb84a3cd01ef9d [4]: https://github.com/openbmc/phosphor-dbus-interfaces/blob/73c931fb942daa714bfff17e950b9d5622a25842/yaml/xyz/openbmc_project/Control/Processor/CurrentOperatingConfig.interface.yaml#L13 [5]: https://github.com/openbmc/smbios-mdr/blob/1d73dccc89f0bb9d1dce3543e5af6b3e3087d5f4/src/speed_select.cpp#L160 Tested: None. Change-Id: I4a48937b1801189acddd02c89aa01ca0cd15362b Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
2025-06-25EventService: Fix Redfish Validator errorJanet Adkins1-0/+5
The Redfish Validator fails when there is a SNMPTrap type of subscription. The Context property is a required property and is missing for these types of subscriptions. ``` VERBOSE1 - Context VERBOSE1 - value: n/a <class 'str'> VERBOSE1 - Mandatory Test: FAIL VERBOSE1 - FAIL ERROR - Context: Mandatory prop does not exist VERBOSE1 - EventDestination.v1_8_0.EventDestination, Counter({'skipOptional': 15, 'pass': 6, 'passGet': 1, 'passRedfishUri': 1, 'err.Edm.String': 1, 'failMandatoryExist': 1}) curl -s https://redfish.dmtf.org/schemas/v1/EventDestination.v1_8_0.jso | jq .definitions.EventDestination.required [ "Context", "@odata.id", "@odata.type", "Id", "Name", "SubscriptionType" ] Body Response of /redfish/v1/EventService/Subscriptions/snmp1: { "@odata.id": "/redfish/v1/EventService/Subscriptions/snmp1", "@odata.type": "#EventDestination.v1_8_0.EventDestination", "Destination": "snmp://X.XX.XXX.XX:XXX", "EventFormatType": "Event", "Id": "snmp1", "Name": "Event Destination", "Protocol": "SNMPv2c", "SubscriptionType": "SNMPTrap" } ``` The Context used to be part of the response for these subscriptions. It was removed by the commit 4b712a29 [1]. It was removed since the code was incorrect. The SNMP backend owns the subscription not bmcweb. The SNMP backend does not support context, so setting the Redfish Context property to an empty string so the validator will pass. Tested: - Redfish Service Validator passes ``` Body Response of /redfish/v1/EventService/Subscriptions/snmp1: { "@odata.id": "/redfish/v1/EventService/Subscriptions/snmp1", "@odata.type": "#EventDestination.v1_8_0.EventDestination", "Context": "", "Destination": "snmp://X.XX.XXX.XX:XXX", "EventFormatType": "Event", "Id": "snmp1", "Name": "Event Destination", "Protocol": "SNMPv2c", "SubscriptionType": "SNMPTrap" } INFO - *** /redfish/v1/EventService/Subscriptions/snmp1 ... VERBOSE1 - Context VERBOSE1 - value: <class 'str'> VERBOSE1 - Mandatory Test: OK DEBUG - (Edm.String, '', 'Edm.String', 'Property', 'Edm.String') VERBOSE1 - Success ... VERBOSE1 - ServiceRoot -> EventService -> Subscriptions -> Members#0, EventDestination.v1_8_0, EventDestination VERBOSE1 - @odata.id PASS VERBOSE1 - @odata.type PASS VERBOSE1 - Context PASS ... VERBOSE1 - EventDestination.v1_8_0.EventDestination, Counter({'skipOptional': 15, 'pass': 7, 'passGet': 1, 'passRedfishUri': 1}) ... INFO - Validation has succeeded. ``` [1] https://gerrit.openbmc.org/c/openbmc/bmcweb/+/65720 [2] https://github.com/openbmc/bmcweb/blob/0a8823b0c27b8124018c8b084976ae350ae5cf7f/redfish-core/lib/event_service.hpp#L946 Signed-off-by: Janet Adkins <janeta@us.ibm.com> Change-Id: I0431e390ea98e9927207e30df220465d882e84cd
2025-06-25Fix json-schema-installed version during schema updateMyung Bae109-108/+142
This fixes `update_schemas.py` so that the existing installed csdl and json symlinks are to be kept and also to be updated with the matching json schema version when DMTF schema version is upgraded. This commit also uses the symlinks to the closed relative paths like - `../schema/dmtf/installed/<schema>.xml -> ../csdl/<schema>.xml` - `../schema/dmtf/json-schema-installed/<json-file>.json -> ../json-schema/<json-file>.json` Tested: - Change VERSION in `update_schemas.py` and verify the generated files - CI passes - Redfish Service Validator passes Change-Id: Ib7fede7e4c39bdfc13da227eb1e737d96b6c2b5e Signed-off-by: Myung Bae <myungbae@us.ibm.com>
2025-06-25Sort JsonSchemas outputMyung Bae1-3/+11
This will show the sorted schema names for `/redfish/v1/JsonSchemas` so that reading or checking of JsonSchemas content is easier (e.g. Redfish Service Validator report). Tested: - GET /redfish/v1/JsonSchemas and check the output as sorted Change-Id: Ica0a8fd513e117a8bd4a533c58cffa0d1090e18c Signed-off-by: Myung Bae <myungbae@us.ibm.com>
2025-06-24Enhance log traces related to PCIe association errorsMyung Bae1-0/+4
When Redfish PCIeDevice GET fails due to the association error, sometimes it may be difficult to debug the root cause as bmcweb log entries do not show the related dbus object paths. This commit is to enhance ffdc log traces to show dbus object paths if the association is in error. The areas of the changes are: - the association error between pcie device to pcieSlot Tested: - Redfish Service Validator runs and passes Change-Id: I507260c38d7b7ba735832b470122b86967c22343 Signed-off-by: Myung Bae <myungbae@us.ibm.com>
2025-06-24redfish: manager: skip AccumulateSetPoint in zone config parsingPeter Yin1-1/+2
AccumulateSetPoint is a boolean type, but the current parsing logic for the xyz.openbmc_project.Configuration.Pid.Zone interface assumes all properties are of type double. This mismatch causes an internal error when processing AccumulateSetPoint Fixed bmcwebd: [openbmc_managers.hpp:284] Field Illegal AccumulateSetPoint bmcwebd: [error_messages.cpp:1250] Internal Error /usr/src/debug/ bmcweb/1.0+git/redfish-core/lib/openbmc/openbmc_managers.hpp(285:56) `redfish::asyncPopulatePid(const std::string&, const std::string&, const std::string&, const std::vector<std::__cxx11::basic_string<char>, std::allocator<std::__cxx11::basic_string<char> > >&, const std::shared_ptr<bmcweb::AsyncResp>&)::<lambda (const boost::system::error_code&, const dbus::utility:: ManagedObjectType&)>`: Change-Id: Idd11afa067fd20e047a28f72307231e2b76bc593 Signed-off-by: Peter Yin <peter.yin@quantatw.com>
generated by cgit v1.2.3 (git 2.39.0) at 2026-10-01 09:41:48 +0300