BMC/OpenBmc/bmcweb.git/src/crow_test.cpp, branch master

Remove security headers middleware test

2023-02-17T03:28:04+00:00

We haven't had security middleware for a long time. Signed-off-by: Ed Tanous Change-Id: Ie8b2803139921eda6168495ab3b0b39b0cb34fa7

Try to fix the lambda formatting issue

2022-06-01T16:10:35+00:00

clang-tidy has a setting, LambdaBodyIndentation, which it says: "For callback-heavy code, it may improve readability to have the signature indented two levels and to use OuterScope." bmcweb is very callback heavy code. Try to enable it and see if that improves things. There are many cases where the length of a lambda call will change, and reindent the entire lambda function. This is really bad for code reviews, as it's difficult to see the lines changed. This commit should resolve it. This does have the downside of reindenting a lot of functions, which is unfortunate, but probably worth it in the long run. All changes except for the .clang-format file were made by the robot. Tested: Code compiles, whitespace changes only. Signed-off-by: Ed Tanous Change-Id: Ib4aa2f1391fada981febd25b67dcdb9143827f43

catch exceptions as const

2021-10-06T17:39:54+00:00

Signed-off-by: Patrick Williams Change-Id: I93925bf34b4fec181a56d6524cbe9c6182a16b1f

Clean up utils

2020-10-07T18:39:41+00:00

Lots of the utils functions have been superceeded or replaced by std:: implementations, or are no longer needed because of the removal of middlewares. Tested: Ran on a bmc with this implemented. Pulled down the webui, and observed no issues. Code compiles and passes clang-tidy cert checks. Change-Id: If29bb5f4ba9979912aeb2a8fa4cbd9f4e4f32006 Signed-off-by: Ed Tanous

Deprecate the "" operator, and isEqP

2020-07-16T16:30:30+00:00

While a cool example of how to do string matching in constexpr space, the set of verbs available to HTTP has been fixed for a very long time. This was ported over to beast a while back, but we kept the API for.... mediocre reasons of backward compatibility. Remove that, and delete the now unused code. Tested: Built and loaded on a Witherspoon. Validator passes. Signed-off-by: Ed Tanous Change-Id: Iaf048e196f9b6e71983189877203bf80390df286 Signed-off-by: James Feist Signed-off-by: Gunnar Mills

clang-format: update to latest from docs repo

2020-06-11T20:46:30+00:00

This is from openbmc/docs/style/cpp/.clang-format Other OpenBMC repos are doing the same. Tested: Built and validator passed. Change-Id: Ief26c755c9ce012823e16a506342b0547a53517a Signed-off-by: Gunnar Mills

Fix a bunch of warnings

2019-10-10T23:25:26+00:00

using the list of warnings from here: https://github.com/lefticus/cppbestpractices/blob/e73393f25a85f83fed7399d8b65cb117d00b2231/02-Use_the_Tools_Available.md#L100 Seems like a good place to start, and would improve things a bit type-wise. This patchset attempts to correct all the issues in one shot. Tested: It builds. Will test various subsystems that have been touched Signed-off-by: Ed Tanous Change-Id: I588c26440e5a97f718a0f0ea74cc84107d53aa1e

bmcweb: Remove deprecatd ASIO interfaces

2019-01-12T01:38:02+00:00

boost::asio::io_service is removed in leiu of io_context, which is a closer match to the networking TS. Move us to that implementatio. This was an automated move using the following command: git grep -l 'io_service' | xargs sed -i 's/io_service/io_context/g' Change-Id: I46605521c01f79f86f6901ddf69ddc8c4bc24103 Signed-off-by: Ed Tanous

Move to clang-format-6.0

2018-09-05T15:44:12+00:00

This commit moves the codebase to the lastest clang-format file from upstream, as well as clang-format-6.0. Change-Id: Ice8313468097c0c42317fbb9e10ddf036e8cff4c Signed-off-by: Ed Tanous

Move over to upstream c++ style

2018-07-26T22:54:37+00:00

This patchset moves bmcweb over to the upstream style naming conventions for variables, classes, and functions, as well as imposes the latest clang-format file. This changeset was mostly built automatically by the included .clang-tidy file, which has the ability to autoformat and auto rename variables. At some point in the future I would like to see this in greater use, but for now, we will impose it on bmcweb, and see how it goes. Tested: Code still compiles, and appears to run, although other issues are possible and likely. Change-Id: If422a2e36df924e897736b3feffa89f411d9dac1 Signed-off-by: Ed Tanous