BMC/Intel-BMC/virtual-media.git/src, branch main

Include fstream (#7)

2022-05-04T20:31:49+00:00

Missing the fstream include is causing build errors that block the upstream sync, so adding it to fix the build. Tested: Confirmed that it builds. Signed-off-by: Jason M. Bills

Make mount/unmount dbus calls asynchronous

2022-03-14T21:20:54+00:00

Change the default behavior of mount/umount dbus calls from blocking to unblocking ones. Once mount/unmount is triggered, appropriate action is running in the background moving handling of operation result to async event. At the end of processing dbus completion signal is sent to client with uint value of operation status (identical with errno code). Tested: Manual scheduling of mount and unmount operations with monitoring dbus communication of virtual-media service - matching api calls with completion signal. Signed-off-by: Przemyslaw Czarnowski

Switch the build system to meson

2022-02-14T09:26:50+00:00

Due to requirements from community, new projects have to be built with meson. To unify with other projects some additional warnings has been enabled, so appropriate code updates has been implemented. This commit makes both meson and CMake available to simplyfy transition in openbmc. CMake support will be removed after switching to meson in openbmc will be accepted. Tested: Compiled and smoke tested. Signed-off-by: Przemyslaw Czarnowski

Force udev change event on init (#6)

2022-02-07T15:13:02+00:00

* Force udev change event on init This change provides temporary workaround for HSD HSD18020136609 ("Can not mount image using Virtual media and CIFS protocol"). When in initial state, additional udev change event is triggered for all NBD devices, which prevents from disconnection on first mount attempt after reboot. The actual issue is a regression, introduced after kernel update from 5.10.67 to 5.14.11. The exact source in kernel is yet to be located; after that an actual fix shall be provided and this change will be reverted. Abstracts echoToFile to a separate class, that may be used by other classes through inheritance. This way, writing to udev files can be handled by different object than UsbGadget. Tested: Successful mounts after reboot for all supported methods (Proxy, Legacy HTTPS, Legacy CIFS). Change-Id: I2ceb826c73b6e46938397060877d35a9fa1c0e03 Signed-off-by: MichalX Orzel

Add -Wextra, remove warnings (#1)

2022-01-26T15:51:08+00:00

Removed all -Wextra warnings in VM sources. -Wno-unused-parameter has to be disabled due to lots of such warnings in sdbusplus. Tested: Compilation generates no warnings Signed-off-by: Przemyslaw Czarnowski

virtual-media: Replace tmpnam with mkstemp

2021-11-16T14:56:21+00:00

In the mechanism of passing the password to client application a file with password is used. Until now, the file has been created with use of unsecure tmpnam function, which can be a subject of TOCTOU vulnerability. Changing tmpnam to mkstemp required some changes in the flow (std::fstream can't reuse file descriptor of opened file, appropriate file permissions are set by mkstemp). Tested: Manually. Password is passed to nbdkit, temporary file permissions are the same as before. Change-Id: Icdd1719cafa08946d5b06414a0db7fa4714cb7ee Signed-off-by: Czarnowski, Przemyslaw

virtual-media: Fix samba mount with latest kernel

2021-11-10T11:36:33+00:00

Latest changes in kernel introduces changes in mounting parameters. - nolock parameter is no longer used with cifs (before it was ignored) - shortened user version of username is no longer valid (even though it still in the codebase) Tested: Updated mount parameter list made CIFS mount possible again Change-Id: I0f0ecb1f3cdb19144246340e5df12203648648f5 Signed-off-by: Czarnowski, Przemyslaw

Cleanup mounted resources after application crash.

2021-10-28T14:21:37+00:00

On initial state application cleans mounted resources which were allocated by user befor application crashed. Without that busy slot is not avaialble anymore for user. Tested: 1. Mount CIFS share. 2. Send terminate signal to virtual-media (kill -9). 3. Mount CIFS share on the same slot as during step 1. Change-Id: I7088e94832fb7bec171a56f73bd66cd29e9b246f Signed-off-by: Krzysztof Richert

Override default libcurl CAInfo with empty string.

2021-08-27T17:19:10+00:00

This change allows virtual-media to pass a zero-length string to nbdkit curl plugin cainfo parameter, which will allow for capath to be used. Tested: Manually, with Virtual-Media HTTPS test in ATF. Change-Id: I14ffa2ecbb2bd6cadee3bb8929ef2e1b8bbbf157 Signed-off-by: Golgowski, Wiktor

Restricted TLS cipher suites to preferred ones

2021-08-25T16:11:28+00:00

Updated TLS 1.2 cipher list and added TLS1.3 cipher list. Tested by Oleksandr Shulzhenko on local setup. Change-Id: I218c245d8ddf7e54dae258a39cd78c3255027b6e Signed-off-by: Karol Niczyj