BMC/Intel-BMC/virtual-media.git/src/state/initial_state.hpp, branch main

Make mount/unmount dbus calls asynchronous

2022-03-14T21:20:54+00:00

Change the default behavior of mount/umount dbus calls from blocking to unblocking ones. Once mount/unmount is triggered, appropriate action is running in the background moving handling of operation result to async event. At the end of processing dbus completion signal is sent to client with uint value of operation status (identical with errno code). Tested: Manual scheduling of mount and unmount operations with monitoring dbus communication of virtual-media service - matching api calls with completion signal. Signed-off-by: Przemyslaw Czarnowski

Switch the build system to meson

2022-02-14T09:26:50+00:00

Due to requirements from community, new projects have to be built with meson. To unify with other projects some additional warnings has been enabled, so appropriate code updates has been implemented. This commit makes both meson and CMake available to simplyfy transition in openbmc. CMake support will be removed after switching to meson in openbmc will be accepted. Tested: Compiled and smoke tested. Signed-off-by: Przemyslaw Czarnowski

Force udev change event on init (#6)

2022-02-07T15:13:02+00:00

* Force udev change event on init This change provides temporary workaround for HSD HSD18020136609 ("Can not mount image using Virtual media and CIFS protocol"). When in initial state, additional udev change event is triggered for all NBD devices, which prevents from disconnection on first mount attempt after reboot. The actual issue is a regression, introduced after kernel update from 5.10.67 to 5.14.11. The exact source in kernel is yet to be located; after that an actual fix shall be provided and this change will be reverted. Abstracts echoToFile to a separate class, that may be used by other classes through inheritance. This way, writing to udev files can be handled by different object than UsbGadget. Tested: Successful mounts after reboot for all supported methods (Proxy, Legacy HTTPS, Legacy CIFS). Change-Id: I2ceb826c73b6e46938397060877d35a9fa1c0e03 Signed-off-by: MichalX Orzel

Add -Wextra, remove warnings (#1)

2022-01-26T15:51:08+00:00

Removed all -Wextra warnings in VM sources. -Wno-unused-parameter has to be disabled due to lots of such warnings in sdbusplus. Tested: Compilation generates no warnings Signed-off-by: Przemyslaw Czarnowski

Cleanup mounted resources after application crash.

2021-10-28T14:21:37+00:00

On initial state application cleans mounted resources which were allocated by user befor application crashed. Without that busy slot is not avaialble anymore for user. Tested: 1. Mount CIFS share. 2. Send terminate signal to virtual-media (kill -9). 3. Mount CIFS share on the same slot as during step 1. Change-Id: I7088e94832fb7bec171a56f73bd66cd29e9b246f Signed-off-by: Krzysztof Richert

Change log level to Info

2021-05-06T14:18:07+00:00

Due to security reasons "user/username" has to be removed from the information that is logged by application. Sensitive data has been moved to "Debug"" level (lowest one) and default one has moved one level up to "Info". Also some important information allowing to catch basic errors has been upgraded to "Info". Tested: Manually, mounting both Legacy mode remote types (HTTPs and CIFS) and checking if journal for VirtualMedia service does not contain sensitive information. Change-Id: Ie6c3a79c94637e3632af76daf957e986b2dd3b6d Signed-off-by: Czarnowski, Przemyslaw

WriteProtected value uses reversed logic

2021-01-11T09:02:38+00:00

When mounting image with WriteProtected set to true, it is shown to be false and vice versa. Change-Id: Id5ff0f0deb5d5822279dd02af0deeb7586dcd065 Signed-off-by: Anna Platash

Virtual Media does not propagate information

2020-11-06T11:28:20+00:00

between Redfish and Web UI WriteProtected field was not updated in bmcweb. Added new property WriteProtected to MountPoint interface to allow bmcweb updating the WriteProtected field value properly. Tested on manually on ArcherCity by mounting images via RedFish interface with and without write protection. Change-Id: I9f642ace2462c52bf964d2e54b0f59fac1b06738 Signed-off-by: Anna Platash

Add missing "ImageURL" property to MountPoint interface

2020-07-28T16:22:25+00:00

It fixes problem with missing information on VirtualMedia Redfish resource after user mounts media using legacy method. Part of VirtualMedia Redfish resource after fix: { ... "ConnectedVia": "URI", "Id": "Slot_2", "Image": null, "ImageName": "smb://127.0.0.1/public/openSUSE-15.1-x86_64.iso", "Inserted": true, ... } Tested: - Mounted and ejected media using legacy method with success. - Received proper details about mounted image from Redfish. Signed-off-by: Wludzik, Jozef Change-Id: I445b37aac27dd290ce07f589834c0a6a10d2ceef

VirtualMedia throw EBUSY exception when receive invalid event in

2020-07-23T23:06:44+00:00

actiavting/deactivating states Previously mount/unmount waited until timeout occurs, when operation was already process it could finish before the timeout causing mount/unmount to get false positive/negative results. Tested: - Mount/Unmount dbus calls cause EBUSY exception in actiavting/deactivating states Change-Id: Idaacde212531c963aec304ac87e536d014d9d8d2 Signed-off-by: Karol Wachowski