Age | Commit message (Collapse) | Author | Files | Lines |
|
I wrote this binding and I'm fine with it being GPL + BSD dual-licensed,
as is recommended for new DT bindings.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Acked-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20200925235828.228626-3-lkundrak@v3.sk
Signed-off-by: Vinod Koul <vkoul@kernel.org>
|
|
This has been added in error -- the PHY block doesn't have a reset pin.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Reviewed-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20200925235828.228626-2-lkundrak@v3.sk
Signed-off-by: Vinod Koul <vkoul@kernel.org>
|
|
Setting 'additionalProperties: false' is frequently omitted, but is
important in order to check that there aren't extra undocumented
properties in a binding.
Ideally, we'd just add this automatically and make this the default, but
there's some cases where it doesn't work. For example, if a common
schema is referenced, then properties in the common schema aren't part
of what's considered for 'additionalProperties'. Also, sometimes there
are bus specific properties such as 'spi-max-frequency' that go into
bus child nodes, but aren't defined in the child node's schema.
So let's stick with the json-schema defined default and add
'additionalProperties: false' where needed. This will be a continual
review comment and game of wack-a-mole.
Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Mark Brown <broonie@kernel.org>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Reviewed-by: Benjamin Gaignard <benjamin.gaignard@st.com>
Acked-by: Stephen Boyd <sboyd@kernel.org> # clock
Acked-by: Lee Jones <lee.jones@linaro.org>
|
|
Running `make dt_binging_check`, gives the error:
DTC Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.example.dt.yaml
Error: Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.example.dts:20.41-42 syntax error
FATAL ERROR: Unable to parse input tree
This is because the example uses the macro GPIO_ACTIVE_HIGH which
is defined in gpio.h but the include of this header is missing.
Add the include to fix the error.
Fixes: f6f149604eef ("dt-bindings: phy: Add binding for marvell,mmp3-hsic-phy")
Link: https://lore.kernel.org/r/20200124105753.15976-1-dafna.hirschfeld@collabora.com
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Olof Johansson <olof@lixom.net>
|
|
This is the PHY chip for USB HSIC on MMP3 platform.
Link: https://lore.kernel.org/r/20191220065314.237624-4-lkundrak@v3.sk
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Signed-off-by: Olof Johansson <olof@lixom.net>
|