diff options
author | Lars-Peter Clausen <lars@metafoo.de> | 2014-02-17 16:16:53 +0400 |
---|---|---|
committer | Mark Brown <broonie@linaro.org> | 2014-02-18 05:07:33 +0400 |
commit | c924dc68f7371582cb420c003faadb700cd4f76c (patch) | |
tree | b7dd0e7f19bb4dcbebecd93a0273b31234ee26dd /sound/soc/codecs/ssm2602.h | |
parent | f75ac2d9bd8211c1890ad591046aef0783ad6416 (diff) | |
download | linux-c924dc68f7371582cb420c003faadb700cd4f76c.tar.xz |
ASoC: ssm2602: Split SPI and I2C code into different modules
There are a few known (minor) problems with having the support code for both I2C
and SPI in the same module:
* We need to be extra careful to make sure to not build the driver into the
kernel if one of the subsystems is build as a module (Currently only I2C
can be build as a module).
* The module init path error handling is rather ugly. E.g. what should be
done if either the SPI or the I2C driver fails to register? Most drivers
that implement SPI and I2C in the same module currently fallback to
undefined behavior in that case. Splitting the the driver into two
modules, one for each bus allows the registration of the other bus driver
to continue without problems if one of them fails.
This patch splits the ssm2602 driver into 3 modules. One core module that
implements the device logic, but is independent of the bus method used. And one
module for SPI and I2C each that registers the drivers and sets up the regmap
struct for the bus.
While we are at it also cleanup the include section of the ssm2602 driver and
remove unneeded includes.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
Diffstat (limited to 'sound/soc/codecs/ssm2602.h')
-rw-r--r-- | sound/soc/codecs/ssm2602.h | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/sound/soc/codecs/ssm2602.h b/sound/soc/codecs/ssm2602.h index fbd07d7b73ca..747538847689 100644 --- a/sound/soc/codecs/ssm2602.h +++ b/sound/soc/codecs/ssm2602.h @@ -28,6 +28,20 @@ #ifndef _SSM2602_H #define _SSM2602_H +#include <linux/regmap.h> + +struct device; + +enum ssm2602_type { + SSM2602, + SSM2604, +}; + +extern const struct regmap_config ssm2602_regmap_config; + +int ssm2602_probe(struct device *dev, enum ssm2602_type type, + struct regmap *regmap); + /* SSM2602 Codec Register definitions */ #define SSM2602_LINVOL 0x00 |