summaryrefslogtreecommitdiff
path: root/sound/sh
diff options
context:
space:
mode:
authorLi Zefan <lizf@cn.fujitsu.com>2009-04-03 03:57:30 +0400
committerLinus Torvalds <torvalds@linux-foundation.org>2009-04-03 06:04:54 +0400
commit0670e08bdfc67272f8c3087030417465629b8073 (patch)
tree44a4e3b6059aeb8c2a97d5fb8ccf743a2eaafd07 /sound/sh
parent099fca3225b39f7a3ed853036038054172b55581 (diff)
downloadlinux-0670e08bdfc67272f8c3087030417465629b8073.tar.xz
cgroups: don't change release_agent when remount failed
Remount can fail in either case: - wrong mount options is specified, or option 'noprefix' is changed. - a to-be-added subsys is already mounted/active. When using remount to change 'release_agent', for the above former failure case, remount will return errno with release_agent unchanged, but for the latter case, remount will return EBUSY with relase_agent changed, which is unexpected I think: # mount -t cgroup -o cpu xxx /cgrp1 # mount -t cgroup -o cpuset,release_agent=agent1 yyy /cgrp2 # cat /cgrp2/release_agent agent1 # mount -t cgroup -o remount,cpuset,noprefix,release_agent=agent2 yyy /cgrp2 mount: /cgrp2 not mounted already, or bad option # cat /cgrp2/release_agent agent1 <-- ok # mount -t cgroup -o remount,cpu,cpuset,release_agent=agent2 yyy /cgrp2 mount: /cgrp2 is busy # cat /cgrp2/release_agent agent2 <-- unexpected! Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> Cc: Paul Menage <menage@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'sound/sh')
0 files changed, 0 insertions, 0 deletions