diff options
author | Xin Long <lucien.xin@gmail.com> | 2016-09-28 21:55:44 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2016-09-30 09:08:57 +0300 |
commit | 1cceda7849809a8857fd9f26efe8846506c710e1 (patch) | |
tree | fbdd3dec3706dabe2ef7d83e8c78a1f4e224ceb3 /net/sunrpc | |
parent | 75b005b949d3dc93b526c3da0a750fd1fc9a703a (diff) | |
download | linux-1cceda7849809a8857fd9f26efe8846506c710e1.tar.xz |
sctp: fix the issue sctp_diag uses lock_sock in rcu_read_lock
When sctp dumps all the ep->assocs, it needs to lock_sock first,
but now it locks sock in rcu_read_lock, and lock_sock may sleep,
which would break rcu_read_lock.
This patch is to get and hold one sock when traversing the list.
After that and get out of rcu_read_lock, lock and dump it. Then
it will traverse the list again to get the next one until all
sctp socks are dumped.
For sctp_diag_dump_one, it fixes this issue by holding asoc and
moving cb() out of rcu_read_lock in sctp_transport_lookup_process.
Fixes: 8f840e47f190 ("sctp: add the sctp_diag.c file")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sunrpc')
0 files changed, 0 insertions, 0 deletions