diff options
author | David S. Miller <davem@davemloft.net> | 2014-10-06 05:15:23 +0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-10-06 05:15:23 +0400 |
commit | f408c3d956c987844dcb7c6837abfbb0331fb7f6 (patch) | |
tree | 64d8c2369c8e0587796d0148afe1a9b0e91efa42 /net/sctp | |
parent | 3a67c9ccad926a168d8b7891537a452018368a5b (diff) | |
parent | 96aacededcc601f5af894ead6b481e76cc8db2cd (diff) | |
download | linux-f408c3d956c987844dcb7c6837abfbb0331fb7f6.tar.xz |
Merge branch 'spider_net'
Antoine Tenart says:
====================
net: spider_net: fix possible bitops errors
Dan reported a possible signedness issue on the pxa168_eth driver. While
having a look at it, I came across a similar problem in the spider_net
driver.
Here is one proposal to fix it. The first patch rework the
spider_net_set_mac() function by removing the spider_net_get_mac_address()
call and using memcpy() to set netdev->dev_addr (which is what's done in
lots of Ethernet drivers) and the second one fix the actual signedness
issue.
If for any reason you really want to keep a call to
spider_net_get_mac_address() because the memcpy() is somehow not good
enough here, we can also come up with a solution involving a temporary
unsigned char variable.
I couldn't test these changes, so please do.
====================
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp')
0 files changed, 0 insertions, 0 deletions