diff options
| author | David S. Miller <davem@davemloft.net> | 2005-08-23 21:13:06 +0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2005-08-23 21:13:06 +0400 |
| commit | 89ebd197eb2cd31d6187db344d5117064e19fdde (patch) | |
| tree | d017e5c04afcd33d99a2bf8554332c5754df8c36 /net/ipv4 | |
| parent | 0fbbeb1ba43bd04f0f1d4f161b7f72437a1c8a03 (diff) | |
| download | linux-89ebd197eb2cd31d6187db344d5117064e19fdde.tar.xz | |
[TCP]: Unconditionally clear TCP_NAGLE_PUSH in skb_entail().
Intention of this bit is to force pushing of the existing
send queue when TCP_CORK or TCP_NODELAY state changes via
setsockopt().
But it's easy to create a situation where the bit never
clears. For example, if the send queue starts empty:
1) set TCP_NODELAY
2) clear TCP_NODELAY
3) set TCP_CORK
4) do small write()
The current code will leave TCP_NAGLE_PUSH set after that
sequence. Unconditionally clearing the bit when new data
is added via skb_entail() solves the problem.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
| -rw-r--r-- | net/ipv4/tcp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index ddb6ce4ecff2..69b1fcf70077 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -584,7 +584,7 @@ static inline void skb_entail(struct sock *sk, struct tcp_sock *tp, sk_charge_skb(sk, skb); if (!sk->sk_send_head) sk->sk_send_head = skb; - else if (tp->nonagle&TCP_NAGLE_PUSH) + if (tp->nonagle & TCP_NAGLE_PUSH) tp->nonagle &= ~TCP_NAGLE_PUSH; } |