diff options
| author | Maxim Mikityanskiy <maximmi@mellanox.com> | 2020-08-17 16:34:06 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-08-27 10:31:48 +0300 |
| commit | 507d7ac63fad384a74dd5ce462aa001df4bc2353 (patch) | |
| tree | 3f2dac57259a797e2697c8f4a39f71ef5a2f71a9 /lib/test_overflow.c | |
| parent | e53140320193d7520195934d7e004de4567393f9 (diff) | |
| download | linux-507d7ac63fad384a74dd5ce462aa001df4bc2353.tar.xz | |
ethtool: Account for hw_features in netlink interface
[ Upstream commit 2847bfed888fbb8bf4c8e8067fd6127538c2c700 ]
ethtool-netlink ignores dev->hw_features and may confuse the drivers by
asking them to enable features not in the hw_features bitmask. For
example:
1. ethtool -k eth0
tls-hw-tx-offload: off [fixed]
2. ethtool -K eth0 tls-hw-tx-offload on
tls-hw-tx-offload: on
3. ethtool -k eth0
tls-hw-tx-offload: on [fixed]
Fitler out dev->hw_features from req_wanted to fix it and to resemble
the legacy ethtool behavior.
Fixes: 0980bfcd6954 ("ethtool: set netdev features with FEATURES_SET request")
Signed-off-by: Maxim Mikityanskiy <maximmi@mellanox.com>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'lib/test_overflow.c')
0 files changed, 0 insertions, 0 deletions