diff options
| author | Maxim Mikityanskiy <maximmi@mellanox.com> | 2020-08-17 16:34:07 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-08-27 10:31:49 +0300 |
| commit | 1c0be9a99c9cf32a026d5a01e0e39e8c5d816ff3 (patch) | |
| tree | ced8d680d727441150da8c4b7af2284203c78adf /lib/test_overflow.c | |
| parent | 507d7ac63fad384a74dd5ce462aa001df4bc2353 (diff) | |
| download | linux-1c0be9a99c9cf32a026d5a01e0e39e8c5d816ff3.tar.xz | |
ethtool: Don't omit the netlink reply if no features were changed
[ Upstream commit f01204ec8be7ea5e8f0230a7d4200e338d563bde ]
The legacy ethtool userspace tool shows an error when no features could
be changed. It's useful to have a netlink reply to be able to show this
error when __netdev_update_features wasn't called, for example:
1. ethtool -k eth0
large-receive-offload: off
2. ethtool -K eth0 rx-fcs on
3. ethtool -K eth0 lro on
Could not change any device features
rx-lro: off [requested on]
4. ethtool -K eth0 lro on
# The output should be the same, but without this patch the kernel
# doesn't send the reply, and ethtool is unable to detect the error.
This commit makes ethtool-netlink always return a reply when requested,
and it still avoids unnecessary calls to __netdev_update_features if the
wanted features haven't changed.
Fixes: 0980bfcd6954 ("ethtool: set netdev features with FEATURES_SET request")
Signed-off-by: Maxim Mikityanskiy <maximmi@mellanox.com>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'lib/test_overflow.c')
0 files changed, 0 insertions, 0 deletions