diff options
| author | Johan Hovold <johan@kernel.org> | 2017-10-11 15:02:58 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-11-21 12:24:35 +0300 |
| commit | 3ebf0608d9f7f32f4ecde00d7bfdc2a6a098f06d (patch) | |
| tree | c1444804b6472c8633bd7f9b92e01f0ca8510a78 /drivers/usb/serial/garmin_gps.c | |
| parent | 031bd81488143bfdc51d38b88ee85898dfd4c2e6 (diff) | |
| download | linux-3ebf0608d9f7f32f4ecde00d7bfdc2a6a098f06d.tar.xz | |
USB: serial: garmin_gps: fix memory leak on probe errors
commit 74d471b598444b7f2d964930f7234779c80960a0 upstream.
Make sure to free the port private data before returning after a failed
probe attempt.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/serial/garmin_gps.c')
| -rw-r--r-- | drivers/usb/serial/garmin_gps.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c index c72ffbd913ad..91e7e3a166a5 100644 --- a/drivers/usb/serial/garmin_gps.c +++ b/drivers/usb/serial/garmin_gps.c @@ -1413,6 +1413,12 @@ static int garmin_port_probe(struct usb_serial_port *port) usb_set_serial_port_data(port, garmin_data_p); status = garmin_init_session(port); + if (status) + goto err_free; + + return 0; +err_free: + kfree(garmin_data_p); return status; } |