diff options
| author | Nathan Chancellor <natechancellor@gmail.com> | 2018-09-25 01:17:03 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-09-27 06:23:04 +0300 |
| commit | 1c492a9d55ba99079210ed901dd8a5423f980487 (patch) | |
| tree | 40c9844ebef97a7c8a07d55f69f6a8b6748e9849 /drivers/net/vxlan.c | |
| parent | d4859d749aa7090ffb743d15648adb962a1baeae (diff) | |
| download | linux-1c492a9d55ba99079210ed901dd8a5423f980487.tar.xz | |
qed: Avoid constant logical operation warning in qed_vf_pf_acquire
Clang warns when a constant is used in a boolean context as it thinks a
bitwise operation may have been intended.
drivers/net/ethernet/qlogic/qed/qed_vf.c:415:27: warning: use of logical
'&&' with constant operand [-Wconstant-logical-operand]
if (!p_iov->b_pre_fp_hsi &&
^
drivers/net/ethernet/qlogic/qed/qed_vf.c:415:27: note: use '&' for a
bitwise operation
if (!p_iov->b_pre_fp_hsi &&
^~
&
drivers/net/ethernet/qlogic/qed/qed_vf.c:415:27: note: remove constant
to silence this warning
if (!p_iov->b_pre_fp_hsi &&
~^~
1 warning generated.
This has been here since commit 1fe614d10f45 ("qed: Relax VF firmware
requirements") and I am not entirely sure why since 0 isn't a special
case. Just remove the statement causing Clang to warn since it isn't
required.
Link: https://github.com/ClangBuiltLinux/linux/issues/126
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/vxlan.c')
0 files changed, 0 insertions, 0 deletions