summaryrefslogtreecommitdiff
path: root/drivers/net/bonding/bond_alb.c
diff options
context:
space:
mode:
authordingtianhong <dingtianhong@huawei.com>2013-10-24 07:09:03 +0400
committerDavid S. Miller <davem@davemloft.net>2013-10-28 00:36:28 +0400
commit6b6c526147bb00b5788a2f48463481dd30c29b71 (patch)
tree7332c6151f274a5178699974ffde90122d8a183e /drivers/net/bonding/bond_alb.c
parenta00f6fcc7d0c62a91768d9c4ccba4c7d64fbbce3 (diff)
downloadlinux-6b6c526147bb00b5788a2f48463481dd30c29b71.tar.xz
bonding: remove bond read lock for bond_mii_monitor()
The bond slave list may change when the monitor is running, the slave list is no longer protected by bond->lock, only protected by rtnl lock(), so we have 3 ways to modify it: 1.add bond_master_upper_dev_link() and bond_upper_dev_unlink() in bond->lock, but it is unsafe to call call_netdevice_notifiers() in write lock. 2.remove unused bond->lock for monitor function, only use the existing rtnl lock(). 3.use rcu_read_lock() to protect it, of course, it will transform bond_for_each_slave to bond_for_each_slave_rcu() and performance is better, but in slow path, it is ignored. so I remove the bond->lock and move the rtnl lock to protect the whole monitor function. Signed-off-by: Ding Tianhong <dingtianhong@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bonding/bond_alb.c')
0 files changed, 0 insertions, 0 deletions