diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2017-07-17 10:58:54 +0300 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@s-opensource.com> | 2017-07-26 12:46:42 +0300 |
commit | f3aa68405d907cdec852078d73a200608d5aa473 (patch) | |
tree | f73ec61f48398d009de864cad07aa9d7e353eb5e /drivers/media | |
parent | 9f5039ba440e499d85c29b1ddbc3cbc9dc90e44b (diff) | |
download | linux-f3aa68405d907cdec852078d73a200608d5aa473.tar.xz |
media: staging: atomisp: array underflow in ioctl
I noticed an array underflow in ov5693_enum_frame_size(). The code
looks like this:
int index = fse->index;
if (index >= N_RES)
retur -EINVAL;
fse->index is a u32 that comes from the user. We want negative values
to be counted as -EINVAL but they aren't. There are several ways to fix
this but I feel like the best fix for future proofing is to change the
type of N_RES from int to unsigned long to make it the same as if we
were comparing against ARRAY_SIZE().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/media')
0 files changed, 0 insertions, 0 deletions