diff options
author | Arnd Bergmann <arnd@arndb.de> | 2010-06-02 16:28:52 +0400 |
---|---|---|
committer | Arnd Bergmann <arnd@arndb.de> | 2010-09-15 23:00:48 +0400 |
commit | 609146fdb319cebce93be550938ab852f7bade90 (patch) | |
tree | 9cac0f94d17294c2a58ec1d39f86e5d7e5bb1c82 /drivers/input | |
parent | d851b6e04ee978b0c1b187bee682592aa72f22ea (diff) | |
download | linux-609146fdb319cebce93be550938ab852f7bade90.tar.xz |
ipmi: autoconvert trivial BKL users to private mutex
All these files use the big kernel lock in a trivial
way to serialize their private file operations,
typically resulting from an earlier semi-automatic
pushdown from VFS.
None of these drivers appears to want to lock against
other code, and they all use the BKL as the top-level
lock in their file operations, meaning that there
is no lock-order inversion problem.
Consequently, we can remove the BKL completely,
replacing it with a per-file mutex in every case.
Using a scripted approach means we can avoid
typos.
file=$1
name=$2
if grep -q lock_kernel ${file} ; then
if grep -q 'include.*linux.mutex.h' ${file} ; then
sed -i '/include.*<linux\/smp_lock.h>/d' ${file}
else
sed -i 's/include.*<linux\/smp_lock.h>.*$/include <linux\/mutex.h>/g' ${file}
fi
sed -i ${file} \
-e "/^#include.*linux.mutex.h/,$ {
1,/^\(static\|int\|long\)/ {
/^\(static\|int\|long\)/istatic DEFINE_MUTEX(${name}_mutex);
} }" \
-e "s/\(un\)*lock_kernel\>[ ]*()/mutex_\1lock(\&${name}_mutex)/g" \
-e '/[ ]*cycle_kernel_lock();/d'
else
sed -i -e '/include.*\<smp_lock.h\>/d' ${file} \
-e '/cycle_kernel_lock()/d'
fi
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Corey Minyard <cminyard@mvista.com>
Cc: openipmi-developer@lists.sourceforge.net
Diffstat (limited to 'drivers/input')
0 files changed, 0 insertions, 0 deletions